From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dick Newsgroups: gmane.emacs.bugs Subject: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size Date: Mon, 20 Dec 2021 00:20:55 -0500 Message-ID: <87o85byhqg.fsf@dick> References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34558"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) Cc: 52676-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 20 07:55:46 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzCaI-0008rF-1j for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Dec 2021 07:55:46 +0100 Original-Received: from localhost ([::1]:46204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzCaG-000445-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Dec 2021 01:55:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzB7a-0001VT-LL for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2021 00:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzB7a-0002QP-7j for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2021 00:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzB7a-0006hW-1b for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2021 00:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Dec 2021 05:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52676-done@debbugs.gnu.org id=D52676.163997766525686 (code D ref 52676); Mon, 20 Dec 2021 05:22:01 +0000 Original-Received: (at 52676-done) by debbugs.gnu.org; 20 Dec 2021 05:21:05 +0000 Original-Received: from localhost ([127.0.0.1]:48714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzB6e-0006gE-NT for submit@debbugs.gnu.org; Mon, 20 Dec 2021 00:21:04 -0500 Original-Received: from mail-qk1-f178.google.com ([209.85.222.178]:40800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzB6c-0006fQ-35 for 52676-done@debbugs.gnu.org; Mon, 20 Dec 2021 00:21:03 -0500 Original-Received: by mail-qk1-f178.google.com with SMTP id p4so8338339qkm.7 for <52676-done@debbugs.gnu.org>; Sun, 19 Dec 2021 21:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:cc:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=oJ9pvAjPVqtNUAkBoKykwKhg79Rt0HChrWayNXPWu38=; b=Wpv4N5r6oNGzdElVlUnMsXRaujKgf0cLWIrU4wQtoTckelhtBaRKlVSbwmoBZua3YQ 5PK2rXxW/kUF5xebY+qhkJ1QiSl1zf4ZLMOrXanVNbfmpRV48FvHuAmgMgPI4lLwNKXw byWTMqPbiMAF8WKaAp6cZSDfhz37h7qLuB2eKPyw17cphEOsAopoNh/uDv5cYcsvpWf5 2XzEW7JsPqA6BFImqsQPSZaNtGH+te7PODU8CPMwfJG0Nz5UANUbs4UL2fjnf0jKrofN o235RdqM3u9pNO2rRxxdT+fPzW4lge1SwJCLfY/v+BgtApD3mIE0zmHDkBaQwlfLxshe 1Yog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oJ9pvAjPVqtNUAkBoKykwKhg79Rt0HChrWayNXPWu38=; b=w6yKSt6QKKZJBKk7PP2O4zpnea24F1cxX89PUIHE00o2hO4YGZu0To4wbLmw+vS4vm 7pPC/3RhdU62gCvKV5RqZzwYdxYdlxnsmNidFeeOv9zRfXcT/g6QtzCgDRuv/o1lbIeW XFtcbIJqvwiJlKKPY5chgH3PVSDD585U0odC1mN7aK+0yWqAEAaxW9J6P6b4tIr6udcx kBEcBhAGs4A3vdvmDl4I163ipMXwMdz0vY4JAzJUStYO67GbiGdQEQunTbVL6Vc4Tqva vIrrYRn44Y3DeuhTVbLmH8Jr2l8/XMYc1tFM4OiVLvv32V/N2d1Zm4D/a1vyY69tDeOK TZCw== X-Gm-Message-State: AOAM530jOISHyH7lVCBqZ+7k6iaMsaQkGZXplGx+GQzxpiwZp6EyKkQV HXFC6BKkNf/fiS+z2NebJ86uthg1Ru8= X-Google-Smtp-Source: ABdhPJzhmPtCTLbznd4xD5L84dQ1mWCcIBEodENIWtjEuaQXXiMfd6itrFtx5W2SvVBybhE9I+qJ1A== X-Received: by 2002:ae9:e80b:: with SMTP id a11mr8551988qkg.716.1639977656318; Sun, 19 Dec 2021 21:20:56 -0800 (PST) Original-Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id h22sm10130785qkk.14.2021.12.19.21.20.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 19 Dec 2021 21:20:56 -0800 (PST) In-Reply-To: <87h7b43qjb.fsf@yahoo.com> (Po Lu's message of "Mon, 20 Dec 2021 11:26:32 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222771 Archived-At: I am sure there was a way to do what you wanted without resorting to what you did. Perhaps I've been too harsh on you. You've gotten a lot of poor (but earnest) counsel from emacs-devel. What sucks is the statute of limitations on function signature changes is short. Once released, that jank, incomprehensibly specific parameter "ignore-line-at-end" is here to stay. (defmacro xdisp-tests--visible-buffer (&rest body) (declare (debug t) (indent 0)) `(progn (switch-to-buffer "his-fooness") (unwind-protect (progn ,@body) (let (kill-buffer-query-functions) (kill-buffer "his-fooness"))))) (xdisp-tests--visible-buffer (cl-flet ((test-it (what from to) (erase-buffer) (save-excursion (insert what)) (let ((dims (window-text-pixel-size nil from to nil nil nil t)) (dims* (window-text-pixel-size nil from to))) (cl-assert dims (cons (car dims*) (- (cdr dims*) (save-excursion (goto-char to) (if (> (line-end-position) (line-beginning-position)) (line-pixel-height) 0)))))))) (let ((text "foo\nbar")) (test-it text 1 (1+ (length text)))) (let ((text "foo\nbar\n")) (test-it text 1 (1+ (length text)))) (let ((text "foo\nbar\nbaz")) (test-it text 1 (1+ (length text)))) (let ((text "foo\nbar\n")) (test-it text 1 (1+ (length "foo\nbar"))))))