bug#52778: 29.0.50; refill-mode issues in org-mode

bug#52778: 29.0.50; refill-mode issues in org-mode

[Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Reproduction steps:

1. run "emacs -Q"
2. type C-x C-f test.org RET
3. enter the following:

first

last

* bye

4. type M-x refill-mode RET
5. position the cursor after the word "last"
6. type RET

Expected: newline (same as RET after "first")

Actual: mangled text ("last * bye")

Rudy


In GNU Emacs 29.0.50 (build 5, x86_64-apple-darwin21.2.0, NS appkit-2113.20 Version 12.1 (Build 21C52))
 of 2021-12-23 built on Workstation.local
Repository revision: 2fa7feca336dd16c57ffef072e0f0da6fffe4c5f
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.1

Configured using:
 'configure --with-json --with-xwidgets --with-native-compilation'

Configured features:
ACL DBUS GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP XIM XWIDGETS ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Org

Minor modes in effect:
  pdf-occur-global-minor-mode: t
  emms-mode-line-mode: t
  telega-root-auto-fill-mode: t
  telega-active-locations-mode: t
  telega-patrons-mode: t
  telega-mode-line-mode: t
  TeX-PDF-mode: t
  flymake-mode: t
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  shell-dirtrack-mode: t
  corfu-global-mode: t
  corfu-mode: t
  vertico-mode: t
  marginalia-mode: t
  global-diff-hl-mode: t
  diff-hl-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-hl-todo-mode: t
  display-fill-column-indicator-mode: t
  global-subword-mode: t
  subword-mode: t
  save-place-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  savehist-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/Users/salutis/.emacs.d/elpa/transient-20211208.1819/transient hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/transient
/Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/emacs-lisp/eieio-compat hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/obsolete/eieio-compat

Features:
(refill pdf-sync pdf-annot pdf-outline pdf-links pdf-history pdf-occur
ibuf-ext ibuffer ibuffer-loaddefs tablist tablist-filter
semantic/wisent/comp semantic/wisent semantic/wisent/wisent
semantic/util-modes semantic/util semantic semantic/tag semantic/lex
semantic/fw mode-local cedet pdf-isearch pdf-misc pdf-tools pdf-view
pdf-cache pdf-info pdf-util pdf-macs diary-lib diary-loaddefs cal-iso
holidays hol-loaddefs cal-move rect swift-mode swift-mode-imenu
swift-mode-repl swift-mode-beginning-of-defun swift-mode-font-lock
swift-mode-standard-types swift-mode-indent swift-mode-lexer conf-mode
sh-script executable gnutls epa-file mailalias smtpmail qp quail shadow
bbdb-message mail-extr view helpful trace edebug info-look help-fns
radix-tree elisp-refs tramp-cmds vterm tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat term ehelp vterm-module
term/xterm xterm eglot array jsonrpc ert debug backtrace xref pcase
mhtml-mode css-mode smie js sgml-mode facemenu org-duration org-pomodoro
alert log4e gntp org-timer hl-line emms-mode-line network-stream nsm
emms-player-mpd emms-url tq emms-player-simple emms-browser sort
emms-playlist-sort emms-last-played emms-volume emms-volume-sndioctl
emms-volume-mixerctl emms-volume-pulse emms-volume-amixer
emms-playlist-mode emms-source-playlist emms-source-file locate
emms-cache emms-info emms-later-do emms emms-compat ox-md ox-odt rng-loc
rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table
ox-ascii ox-publish ox citar-org oc-csl citeproc citeproc-itemgetters
citeproc-biblatex citeproc-bibtex citeproc-cite citeproc-subbibs
citeproc-sort citeproc-name citeproc-formatters citeproc-number rst
citeproc-proc citeproc-disamb citeproc-itemdata
citeproc-generic-elements citeproc-macro citeproc-choose citeproc-date
citeproc-context citeproc-prange citeproc-style citeproc-locale
citeproc-term f citeproc-rt citeproc-lib citeproc-s let-alist queue
org-id org-refile citar s parsebib citar-file misearch multi-isearch
telega-obsolete telega telega-tdlib-events telega-webpage
visual-fill-column telega-root telega-info telega-chat telega-modes
telega-company telega-user telega-notifications notifications
telega-voip telega-msg telega-tme telega-sticker telega-i18n
telega-vvnote bindat telega-ffplay telega-media telega-sort
telega-filter telega-ins telega-folders telega-inline telega-tdlib
telega-util rainbow-identifiers dired-aux color telega-server
telega-core telega-customize cus-edit cus-start cus-load emacsbug
sendmail goto-addr bug-reference preview tex-buf font-latex latex
latex-flymake tex-ispell tex-style tex texmathp tex-mode flymake-proc
flymake compile image-file image-converter disp-table magit-extras
char-fold face-remap magit-bookmark magit-submodule magit-obsolete
magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull
magit-fetch magit-clone magit-remote magit-commit magit-sequence
magit-notes magit-worktree magit-tag magit-merge magit-branch
magit-reset magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode
diff git-commit log-edit add-log magit-core magit-autorevert
magit-margin magit-transient magit-process with-editor shell server
magit-mode transient magit-git magit-section magit-utils crm dash
orderless cursor-sensor vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs
vc-rcs project consult-vertico consult recentf tree-widget paredit
edmacro kmacro bbdb bbdb-site timezone modus-vivendi-theme
modus-operandi-theme modus-themes corfu vertico marginalia pdf-loader
diff-hl log-view pcvs-util vc-dir ewoc vc diminish yasnippet hl-todo
finder-inf fortune display-fill-column-indicator ob-sqlite ob-sql ob-C
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs ob-R org-clock cl ls-lisp cap-words superword subword
saveplace autorevert filenotify comp comp-cstr warnings delsel savehist
elfeed-link elfeed-show elfeed-search elfeed-csv elfeed elfeed-curl
elfeed-log xml-query bookmark pp elfeed-db elfeed-lib vc-git diff-mode
vc-dispatcher org-element avl-tree generator ol-eww eww xdg url-queue
thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect
gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015
mm-view mml-smime smime dig gnus-sum shr pixel-fill kinsoku svg dom
gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap
nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range message yank-media rmc puny rfc822 mml mml-sec epa derived
epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus
nnheader gnus-util text-property-search mail-utils mm-util mail-prsvr
wid-edit ol-docview doc-view jka-compr image-mode exif dired
dired-loaddefs ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi cl-extra
help-mode org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color
ring org-list org-faces org-entities noutline outline easy-mmode
org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex
iso8601 time-date ol rx org-keys oc org-compat advice org-macs
org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs
tex-site info package browse-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt
bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget keymap hashtable-print-readable backquote threads
xwidget-internal dbusbind kqueue cocoa ns lcms2 multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 1522350 259411)
 (symbols 48 66889 20)
 (strings 32 380215 32116)
 (string-bytes 1 34369447)
 (vectors 16 132734)
 (vector-slots 8 2987120 202528)
 (floats 8 20839 1362)
 (intervals 56 33701 15099)
 (buffers 992 68))

-- 
"Programming reliably --- must be an activity of an undeniably mathematical nature […] You see, mathematics is about thinking, and doing mathematics is always trying to think as well as possible." -- Edsger W. Dijkstra (1981)

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#52778: 29.0.50; refill-mode issues in org-mode

[Eli Zaretskii]

> Date: Fri, 24 Dec 2021 15:15:00 +0100
> From:  Rudolf Adamkovič via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> 
> Reproduction steps:
> 
> 1. run "emacs -Q"
> 2. type C-x C-f test.org RET
> 3. enter the following:
> 
> first
> 
> last
> 
> * bye
> 
> 4. type M-x refill-mode RET
> 5. position the cursor after the word "last"
> 6. type RET
> 
> Expected: newline (same as RET after "first")
> 
> Actual: mangled text ("last * bye")

Doesn't Org mode have its own bug tracker?

bug#52778: 29.0.50; refill-mode issues in org-mode

[Ihor Radchenko]

Eli Zaretskii <eliz@gnu.org> writes:

>> 4. type M-x refill-mode RET
>> 5. position the cursor after the word "last"
>> 6. type RET
>> 
>> Expected: newline (same as RET after "first")
>> 
>> Actual: mangled text ("last * bye")
>
> Doesn't Org mode have its own bug tracker?

Yes, but this particular report appears to be relevant to Emacs.

We had the same issue reported in
https://orgmode.org/list/3715730.BJ41AJB0qc@yksi

It looks like refill-mode ignores `fill-paragraph-function'.

Best,
Ihor

bug#52778: 29.0.50; refill-mode issues in org-mode

[Eli Zaretskii]

> From: Ihor Radchenko <yantar92@gmail.com>
> Cc: Rudolf Adamkovič <salutis@me.com>,
>   52778@debbugs.gnu.org
> Date: Fri, 24 Dec 2021 23:04:21 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> 4. type M-x refill-mode RET
> >> 5. position the cursor after the word "last"
> >> 6. type RET
> >> 
> >> Expected: newline (same as RET after "first")
> >> 
> >> Actual: mangled text ("last * bye")
> >
> > Doesn't Org mode have its own bug tracker?
> 
> Yes, but this particular report appears to be relevant to Emacs.

What about the other issues that Rudolf reported lately? they all have
to do with Org, AFAICT.

bug#52778: 29.0.50; refill-mode issues in org-mode

[Ihor Radchenko]

Eli Zaretskii <eliz@gnu.org> writes:

> What about the other issues that Rudolf reported lately? they all have
> to do with Org, AFAICT.

You are right. I do not actively watch Emacs bug tracker and I had no
information about Rudolf's previous reports today.

Yet, we should probably prioritise discussion of refill-mode issue in
this thread.

I did some debugging for refill-mode in Org.
`refill-post-command-function' calls `refill-fill-paragraph-at', which
not only ignores `fill-paragraph-function', but even
`fill-forward-paragraph-function'. `forward-paragraph' is hard-coded,
I consider to be a bug.

P.S.

Rudolf,

Could you kindly use M-x org-submit-bug-report to prepare your
future bug reports related to Org mode?

Best regards,
Ihor

bug#52778: 29.0.50; refill-mode issues in org-mode

[Eli Zaretskii]

> From: Ihor Radchenko <yantar92@gmail.com>
> Cc: salutis@me.com,  52778@debbugs.gnu.org
> Date: Fri, 24 Dec 2021 23:40:16 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > What about the other issues that Rudolf reported lately? they all have
> > to do with Org, AFAICT.
> 
> You are right. I do not actively watch Emacs bug tracker and I had no
> information about Rudolf's previous reports today.

Did you look at them now?  I meant bugs 52771 and 52772.

bug#52778: 29.0.50; refill-mode issues in org-mode

[Ihor Radchenko]

Eli Zaretskii <eliz@gnu.org> writes:

>> You are right. I do not actively watch Emacs bug tracker and I had no
>> information about Rudolf's previous reports today.
>
> Did you look at them now?  I meant bugs 52771 and 52772.

Yes. One is fixed already. The other one should probably be forwarded to
Org ML. However, I am not sure what is the right way to redirect
messages from Emacs bug tracker to Org ML. Usually, Kyle takes care
about this part.

Best,
Ihor

bug#52778: 29.0.50; refill-mode issues in org-mode

[Eli Zaretskii]

> From: Ihor Radchenko <yantar92@gmail.com>
> Cc: salutis@me.com,  52778@debbugs.gnu.org
> Date: Sat, 25 Dec 2021 22:39:15 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> You are right. I do not actively watch Emacs bug tracker and I had no
> >> information about Rudolf's previous reports today.
> >
> > Did you look at them now?  I meant bugs 52771 and 52772.
> 
> Yes. One is fixed already. The other one should probably be forwarded to
> Org ML. However, I am not sure what is the right way to redirect
> messages from Emacs bug tracker to Org ML. Usually, Kyle takes care
> about this part.

Thanks, I'm sure Kyle will DTRT.

bug#52778: 29.0.50; refill-mode issues in org-mode

[Ihor Radchenko]

Ihor Radchenko <yantar92@gmail.com> writes:

> I did some debugging for refill-mode in Org.
> `refill-post-command-function' calls `refill-fill-paragraph-at', which
> not only ignores `fill-paragraph-function', but even
> `fill-forward-paragraph-function'. `forward-paragraph' is hard-coded,
> I consider to be a bug.

Let me bump this bug report.
AFAIU, it belongs to emacs.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#52778: 29.0.50; refill-mode issues in org-mode

[Eli Zaretskii]

> From: Ihor Radchenko <yantar92@posteo.net>
> Cc: Eli Zaretskii <eliz@gnu.org>,  salutis@me.com,  52778@debbugs.gnu.org
> Date: Sat, 29 Oct 2022 05:04:56 +0000
> 
> Ihor Radchenko <yantar92@gmail.com> writes:
> 
> > I did some debugging for refill-mode in Org.
> > `refill-post-command-function' calls `refill-fill-paragraph-at', which
> > not only ignores `fill-paragraph-function', but even
> > `fill-forward-paragraph-function'. `forward-paragraph' is hard-coded,
> > I consider to be a bug.
> 
> Let me bump this bug report.
> AFAIU, it belongs to emacs.

Patches to modify refill.el to behave according to fill.el's protocols
will be welcome, of course.