From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: 54225@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
lomov.vl@yandex.ru
Subject: bug#54225: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call
Date: Thu, 03 Mar 2022 15:36:09 +0100 [thread overview]
Message-ID: <87o82nhzmu.fsf@gnus.org> (raw)
In-Reply-To: <20220303030035.570230-1-kyle@kyleam.com> (Kyle Meyer's message of "Wed, 2 Mar 2022 22:00:35 -0500")
Kyle Meyer <kyle@kyleam.com> writes:
> The macroexp-warn-and-return call added to with-demoted-errors in
> d52c929e31f (2022-02-04) is incorrect. The with-demoted-errors format
> string is passed as MSG, the actual message is passed as FORM, and the
> form is passed as CATEGORY, leading to with-demoted-errors returning
> "Missing format argument".
>
> * lisp/subr.el (with-demoted-errors): Call macroexp-warn-and-return
> with correct arguments.
[...]
> - (macroexp-warn-and-return format "Missing format argument" exp))))
> + (macroexp-warn-and-return "Missing format argument" exp))))
The code flow in with-demoted-errors is pretty confusing. Can it be
improved upon instead of tweaked this way? (`format' here will be
"Error: %S" at least in some cases, I guess?)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-03 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 3:00 bug#54225: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call Kyle Meyer
2022-03-03 14:36 ` Lars Ingebrigtsen [this message]
2022-03-04 0:21 ` Michael Heerdegen
2022-03-03 15:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o82nhzmu.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=54225@debbugs.gnu.org \
--cc=kyle@kyleam.com \
--cc=lomov.vl@yandex.ru \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).