From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Thu, 17 Mar 2022 20:45:57 +0100 Message-ID: <87o824z7ka.fsf@gmail.com> References: <87sftyweb2.fsf@gmail.com> <861r1iyrvw.fsf@mail.linkov.net> <87zgo6owaf.fsf@gmail.com> <86k0f9xnrn.fsf@mail.linkov.net> <87tuedp6pl.fsf@gmail.com> <861r1g7n3b.fsf@mail.linkov.net> <87o84jcx5x.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86sfrjia5u.fsf@mail.linkov.net> <87ilseyks7.fsf@gmail.com> <868rt9wwji.fsf@mail.linkov.net> <871qz11w82.fsf@gmail.com> <86ilsc7e31.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12075"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 53126@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 17 20:47:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUw5W-0002qE-6D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 20:47:10 +0100 Original-Received: from localhost ([::1]:52276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUw5U-0007Tl-SC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 15:47:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUw5O-0007TZ-Dm for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 15:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUw5O-0001sz-5D for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 15:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUw5O-0003hg-3d for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.164754636814172 (code B ref 53126); Thu, 17 Mar 2022 19:47:02 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 17 Mar 2022 19:46:08 +0000 Original-Received: from localhost ([127.0.0.1]:55242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUw4W-0003gW-2O for submit@debbugs.gnu.org; Thu, 17 Mar 2022 15:46:08 -0400 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:39697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUw4U-0003ft-7Q for 53126@debbugs.gnu.org; Thu, 17 Mar 2022 15:46:06 -0400 Original-Received: by mail-ej1-f43.google.com with SMTP id dr20so12603572ejc.6 for <53126@debbugs.gnu.org>; Thu, 17 Mar 2022 12:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sWkc5Zk5xTpjgSApnpMIDQFCzdRXU0Yrn9ZKLlRYYNI=; b=eF0XdzJdJlQARLA/M3AAfeOZWoB5MqSaDrnuaCm51LALfRfXxhluS36i/HEE9k0fW3 9sayPwj42jgedzbKhtFwfanQqCErrB9WUZ0QYx61CCGgvzE+sJpCUZe0YkZl4TPayP4P JwhHwuzYF4U3eisPiEMf2H/4p7CHfWUyf4vHMpYQokgUjGnSCloA101t5nGMPiPkSm1d kpZzHXphysJVFa6hy2zt9Qm9bKCtlTem+ff0aUbNu25f97j+8PB1Fi8jlm4AC74N6dxX d8l0F+CEm0fOaaZaDSgExb0mv65+QIULentg0wtHvtdw7oIQa0gpCr90Jf+1sroV70Tn Stnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sWkc5Zk5xTpjgSApnpMIDQFCzdRXU0Yrn9ZKLlRYYNI=; b=YXFtRdpsevS/3qH4IoCoA6QL7dLnJ5T1pCYyLEidb78EumRL1m/ibpEiQNhqZfSZfu LRXSvaSmfZ+3cuT4oPxE9qngHpbg7y6bI50tfapw8vuBFUsRhc1Vw/ZdjEQX31gSxWZU l8IWzKMP1ffGK9zuH6ai4L7UrC2+dpNQ1aDcTI9OZkjFuDh1qWSO+QB29fStq0WAi0hC ZXlAVIboXNe/f+gna63jcT3wORRM6ppLq7cd1b2kroSMGutz2a+KtYmelnvZxUpPZMrz J6/n+HtRQMEkAYMKzq1gLaXCWcAybbpnmuigBTjht11X19OYuy/6WfLTkKI0wK8OZbp7 MkAw== X-Gm-Message-State: AOAM533v/YU9Z4cU7n7FR42F5yQTPijHyHQ5IcLIQ6CoWR7lRwuvOr8h QLYYMFLIiaWOlL7AMOe3+WKNm2NEfUY= X-Google-Smtp-Source: ABdhPJwVno+o2SkAdxWl1zXtr/p/UG7b/skz5XuFHBPkLSfdSrbtsj74WyFrQJY8dQs6Vl9RvXJWPg== X-Received: by 2002:a17:906:2ad5:b0:6cf:9cca:d9db with SMTP id m21-20020a1709062ad500b006cf9ccad9dbmr5999869eje.252.1647546360035; Thu, 17 Mar 2022 12:46:00 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::758e]) by smtp.gmail.com with ESMTPSA id v4-20020a170906338400b006d5aca9fc80sm2690362eja.106.2022.03.17.12.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 12:45:59 -0700 (PDT) In-Reply-To: <86ilsc7e31.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 17 Mar 2022 19:05:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228508 Archived-At: On Thu, 17 Mar 2022 at 19:05, Juri Linkov wrote: >>> When I tried your latest patch, it still flashes when it starts >>> the perform-replace loop. >> >> Does it always happen for you? I see this occasionally, and as far as I >> can tell it's random. > > It happens every time when starting perform-replace from isearch. Interesting, I can't see thing flash at that particular place. But I've replaced the unwind-protect by a more fine-grained condition-case. Let me know if it helps. > The biggest hunk in your patch are changes in query-replace-read-args > starting from 'condition-case error'. Would it be possible to simplify > this part? Maybe by some refactoring? The only refactoring opportunity I see it to define (defun replace-regexp-function (delimited-flag) (or replace-regexp-function delimited-flag (and replace-char-fold (not regexp-flag) #'char-fold-to-regexp))) which can be used in 3 places. Should I do that? Otherwise, I dont' see much room for improvement. There are a lot of moving parts there, so to me things already turned out surprisingly short.