From: Sean Whitton <spwhitton@spwhitton.name>
To: Nobuyoshi Nakada <nobu.nakada@gmail.com>, 54932@debbugs.gnu.org
Subject: bug#54932: 28.1; electric-help doesn't work when `help-char' has meta-prefix
Date: Thu, 14 Apr 2022 14:39:12 -0700 [thread overview]
Message-ID: <87o813jqf3.fsf@melete.silentflame.com> (raw)
In-Reply-To: <7da42cdb-945e-ecbd-ce0b-2c7209d23bfc@gmail.com>
Hello,
On Thu 14 Apr 2022 at 06:04PM +09, Nobuyoshi Nakada wrote:
> --- 28.1/lisp/ehelp.el.gz
> +++ site-lisp/ehelp.el.gz
> @@ -76,7 +76,9 @@
> (define-key map [?\C-7] 'electric-help-undefined)
> (define-key map [?\C-8] 'electric-help-undefined)
> (define-key map [?\C-9] 'electric-help-undefined)
> - (define-key map (char-to-string help-char) 'electric-help-help)
> + (define-key map
> + (if (characterp help-char) (char-to-string help-char) (vector help-char))
> + 'electric-help-help)
> (define-key map "?" 'electric-help-help)
> (define-key map " " 'scroll-up)
> (define-key map [?\S-\ ] 'scroll-down)
Couldn't `vector' be used unconditionally?
--
Sean Whitton
prev parent reply other threads:[~2022-04-14 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 9:04 bug#54932: 28.1; electric-help doesn't work when `help-char' has meta-prefix Nobuyoshi Nakada
2022-04-14 13:51 ` Lars Ingebrigtsen
2022-04-14 21:39 ` Sean Whitton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o813jqf3.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=54932@debbugs.gnu.org \
--cc=nobu.nakada@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).