From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 08:28:37 +0200 Message-ID: <87o80lhg9b.fsf@fastmail.fm> References: <87sfpxhkuz.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: "55149@debbugs.gnu.org" <55149@debbugs.gnu.org>, "monnier@iro.umontreal.ca" To: "M. Ian Graham" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 08:31:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njxgu-0004D1-Kn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 08:31:53 +0200 Original-Received: from localhost ([::1]:58976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njxgt-0008T9-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 02:31:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njxg6-0008PU-BW for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 02:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njxg6-0001ta-1K for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 02:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njxg5-0005aA-RL for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 02:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 06:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs Original-Received: via spool by 55149-submit@debbugs.gnu.org id=B55149.165112742021401 (code B ref 55149); Thu, 28 Apr 2022 06:31:01 +0000 Original-Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 06:30:20 +0000 Original-Received: from localhost ([127.0.0.1]:45058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxfQ-0005Z7-74 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 02:30:20 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:40753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njxfN-0005Yq-Px for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 02:30:18 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 75E6A320097C; Thu, 28 Apr 2022 02:30:11 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Apr 2022 02:30:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651127410; x=1651213810; bh=GJzhYZxwl8 s8FzB3GCLsG+SR9hAKcXGvgbXj0NdwkLg=; b=ZXqlhkcKDxjUvvzErO6fzxq0/U 9nHcZdxyoNMKIHegUuwknMUZ8NfU7d/8jaEjq/Q+dl1bWaMVIf7zlBf5X4NMsElD KisyYfHr72dohEB0oIkb2t59wxisyXzWAi5uSJ2jroQpxavdLnvblHTmAzXMnpj8 yMyClKTWdBjPLYMGSbIZbfq4YO1S+RJE+h0EzzqLRyKcwIlMdUivOZMp1wMS8m76 404R0QoMAtL8QpHgcubItRCmePHlhl/MDQWFvliPIvuR9lGd1hjpwiI5yutCPf+u LykrUftTffQPb5QKiXLIv8upckDMNItR4bOvyHAB/EupCj1UgvsIP4/0q2LA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651127410; x= 1651213810; bh=GJzhYZxwl8s8FzB3GCLsG+SR9hAKcXGvgbXj0NdwkLg=; b=v a06Eh2vpO64bvDSJ8ZBrufh3st3KPLaFnAaNyRyuAcn9m7b0DMki8PsDR6QD3J/h SqPCKOmuzbgcIFOesvdF/8nX5McdJVIhJKl5jfB3xDvjbd6mZmA/xLKQtlekxxei 9UasHoPaTmK1fJEaSXPxlcL0hA1225L8K+b1uUrazP0EIivRGa0qQjoN+Y9icM51 QcloHj7mYtuDFFJqChKh2BVaYNJKS+imGqSll5Qhw73RR8VmDU4+Bx7rIU5k1rgw yXhdhCrpbDeGeO2Rb4bWroyFqGHWsJpMLlnYtHilM9XEPOVqjkiPZNFXkp6xQzSH GEJdBpm7kBWDByyKEXnaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehthhhorhhnsehfrghs thhmrghilhdrfhhmqeenucggtffrrghtthgvrhhnpeegffeihfejkeeuieeuheettefghe etgfffgeefudehjeeihffgheetkeethfdvgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 02:30:10 -0400 (EDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230833 Archived-At: "M. Ian Graham" writes: >> Oh, you are right. But I was able to extract (at least one of) the >> problematic with-editor advice(s) which cause the breakage. > >> Save the below as bug-recipe.el: > > Nice find. Confirmed on my end that this breaks emacsclient commands > after f30625943e but not before. Had to add a require 'cl-lib to the > top, otherwise works perfectly with bare emacs -Q. Oh, well, the recipe can even be simplyfied to defining just a do-nothing advice! --8<---------------cut here---------------start------------->8--- (advice-add 'server-visit-files :after #'server-visit-files--with-editor-file-name-history-exclude) (defun server-visit-files--with-editor-file-name-history-exclude (files _proc &optional _nowait) nil) (server-start) --8<---------------cut here---------------end--------------->8--- Bye, Tassilo