From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45767: bug#45768: icomplete-mode does not provide in region completion for dabbrev-completion Date: Sat, 07 May 2022 17:51:42 +0200 Message-ID: <87o809mjch.fsf@gnus.org> References: <255598638.117929.1610282275124@office.mailbox.org> <87k0ayh499.fsf@gnus.org> <87mtftvea7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24204"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45768@debbugs.gnu.org, simon254@mailbox.org, 45767@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 07 17:52:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnMjB-00062f-3K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 May 2022 17:52:17 +0200 Original-Received: from localhost ([::1]:50068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnMj8-0005sR-ID for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 May 2022 11:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnMiw-0005rv-LU for bug-gnu-emacs@gnu.org; Sat, 07 May 2022 11:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnMiw-0000Lk-Ct for bug-gnu-emacs@gnu.org; Sat, 07 May 2022 11:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnMiw-0003bw-Aw for bug-gnu-emacs@gnu.org; Sat, 07 May 2022 11:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 May 2022 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45767-submit@debbugs.gnu.org id=B45767.165193871713870 (code B ref 45767); Sat, 07 May 2022 15:52:02 +0000 Original-Received: (at 45767) by debbugs.gnu.org; 7 May 2022 15:51:57 +0000 Original-Received: from localhost ([127.0.0.1]:52723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnMir-0003bZ-Lk for submit@debbugs.gnu.org; Sat, 07 May 2022 11:51:57 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnMip-0003bH-Nc; Sat, 07 May 2022 11:51:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=A6s36RI0HfeOkU67XcYBdDXUQjENCwxaQt8Wf7nJC+o=; b=C4t0emD3VmxCVLe5OOaNB3AZJa 5GNrLTyHu1GOJgE48i3QWD+GmdG4dUkO4KG/Y9tO41lIVPw6sLmBxRKf9t3u4/VApopTMgmaMvfZa DuqUWb3SH1UAHXkZeYiUiJ6U72p+8BR+aamVjVW0UHNGTZJAp44miHu1A5oeQX4CV0Mo=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnMig-0004kH-9x; Sat, 07 May 2022 17:51:48 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAM1BMVEX+/v708uzo6OjX 2+P36qX78GmVteylyPi0nlBnbJg7Kz5gWV6GdIJmmenMrKdQL1n///+8OYdKAAAAAWJLR0QQlbIN LAAAAAd0SU1FB+YFBw8zIwSutokAAAEQSURBVEjH7ZXRbsMgDEXj6xYKpvD/fzsbk6qatDiR9jBV Oy1pI3FiMIZs29+GFGjbAILfGj8LAOtnYZpzEAGvB5IHxHGEz4BWe78/wvK/8rj+Eo4F68TkgnWn QLgwmM+Bbgtiq1pGlCO6OzeknLM2pijCLoBYFY6FZUCfr4QR8Hjc5xd5GiVFc6gLFpHWpEq04LzQ mtIrwu1JzwWxGfMoOBbS5JlsHTxUIHhJ60/vvRUlWDnqvTRtDBlOJIiMqgkqGJarE0JfoDgtTGvO c8n2UzXMa/Kspv0UDoVZ0+/nabhyugNsIqeFVodWkNbSa/aBYJ2rDEEbQwyOh+TvkPjt889lruaT +4nd+V3o/ZeG9AXjkQl+TX/cwAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wNS0wN1QxNTo1MToz NSswMDowMCO9Z+AAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDUtMDdUMTU6NTE6MzUrMDA6MDBS 4N9cAAAAAElFTkSuQmCC X-Now-Playing: Eberhard Weber's _Fluid Rustle_: "Quiet Departures" In-Reply-To: (Stefan Monnier's message of "Sat, 07 May 2022 10:22:32 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231597 Archived-At: Stefan Monnier writes: > No, it's not working as intended: what I wrote just means that the > problem is in `dabbrev-completion` which shouldn't just call > `completion-in-region` as it does. It should either do it within > a let-binding of `completion-in-region-mode-predicate` or with a call > to `completion-at-point` instead (which will take care to bind > `completion-in-region-mode-predicate`). > > I just pushed a patch doing the latter (and providing a new > `dabbrev-capf` function). Ah; thanks. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no