From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40750: Use error face for errors Date: Mon, 23 May 2022 13:55:12 +0200 Message-ID: <87o7zompjz.fsf_-_@gnus.org> References: <87eeie8ebe.fsf@gnus.org> <87ee9dnzp5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2703"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "40750@debbugs.gnu.org" <40750@debbugs.gnu.org>, Drew Adams , ndame To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 23 13:56:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6g4-0000VP-Ox for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 13:56:48 +0200 Original-Received: from localhost ([::1]:56202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt6g1-0006bp-OJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 07:56:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6fK-0006QU-91 for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 07:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nt6fJ-0006hV-IA for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 07:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nt6fJ-0002ak-Ho for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 07:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 May 2022 11:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40750 X-GNU-PR-Package: emacs Original-Received: via spool by 40750-submit@debbugs.gnu.org id=B40750.16533069289915 (code B ref 40750); Mon, 23 May 2022 11:56:01 +0000 Original-Received: (at 40750) by debbugs.gnu.org; 23 May 2022 11:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:47489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt6el-0002Zr-MQ for submit@debbugs.gnu.org; Mon, 23 May 2022 07:55:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt6eh-0002Zb-0f for 40750@debbugs.gnu.org; Mon, 23 May 2022 07:55:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pw8qPK0AsxV1qSOLl60Hpm7Qxxj/iybewdHL4SbHWBw=; b=EaP52fZlMaE7aFBBjigXQwkq0f OSVvyaFlexnVoXKGa9caqXbwzNsnIY5Je44afySp0uV4+HC8pqJpEDKIZTRgdWP29XIdx9DFTj7rH Bjwoml5nrb5Mhw4035AO1AGG38V8DH5UFs8h+/SxuufLPUHw+jBdcH8pmYPs8KXXBXEk=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6eX-0001fT-DW; Mon, 23 May 2022 13:55:15 +0200 X-Now-Playing: Muslimgauze's _Mort Aux Vaches_: "Jaagheed Zarb" In-Reply-To: (Stefan Kangas's message of "Sat, 25 Sep 2021 09:59:17 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232957 Archived-At: Stefan Kangas writes: > Of course, the error face should not just remove any faces that are > already there; that precludes making e.g. keybindings stand out with the > `help-key-binding' face. So you would need to give the error-message > face lower priority. I started poking at this a bit, and I realised that I've never actually seen an error message that has any kind of face. And that's because print_error_message uses princ on the strings we give error/signal, and princ discards all text properties. So there's nothing here to merge, really -- the strings, when they come out of Ferror_message_string, are property-less. I think. And users can already alter the look of the error message by just using command-error-function: (setq command-error-function (lambda (data _ _) (message "%s" (propertize (error-message-string data) 'face 'error)))) So I don't think there's anything much here to implement, really, unless we really want to start defaulting error messages to use a particular face. And I don't think we want that? So I'm adding some more pointers to command-error-function from relevant doc strings, because finding that variable wasn't trivial, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no