From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 55838@debbugs.gnu.org
Subject: bug#55838: 29.0.50; Eshell string-split subscript indexing splits too much
Date: Wed, 08 Jun 2022 14:11:33 +0200 [thread overview]
Message-ID: <87o7z39wy2.fsf_-_@gnus.org> (raw)
In-Reply-To: <ec8ceb92-c93e-7ff7-5e59-4b88b088e2d9@gmail.com> (Jim Porter's message of "Tue, 7 Jun 2022 18:41:30 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
> Here's a patch for this. It changes the behavior of
> `eshell-apply-indices' to use `eshell-convert-to-number' (when the
> expansion isn't wrapped in double-quotes) instead of the
> more-aggressive `eshell-convert'. I think `eshell-convert-to-number'
> is the right thing here, since Eshell already converts number-like
> strings to actual numbers in most cases.
Sounds good to me; pushed to Emacs 29.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-08 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 1:36 bug#55838: 29.0.50; Eshell string-split subscript indexing splits too much Jim Porter
2022-06-08 1:41 ` bug#55838: 29.0.50; [PATCH] " Jim Porter
2022-06-08 12:11 ` Lars Ingebrigtsen [this message]
2022-06-08 13:38 ` Eli Zaretskii
2022-06-08 23:06 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7z39wy2.fsf_-_@gnus.org \
--to=larsi@gnus.org \
--cc=55838@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).