From: Lars Ingebrigtsen <larsi@gnus.org>
To: dick.r.chiang@gmail.com
Cc: 56329@debbugs.gnu.org
Subject: bug#56329: 29.0.50; [PATCH] RET at EOB of *Server* (gnus)
Date: Fri, 01 Jul 2022 12:48:22 +0200 [thread overview]
Message-ID: <87o7y9az2h.fsf@gnus.org> (raw)
In-Reply-To: <87o7y96ezm.fsf@dick> (dick r. chiang's message of "Thu, 30 Jun 2022 17:03:25 -0400")
dick.r.chiang@gmail.com writes:
> +(defsubst gnus-server--server-name (which)
> + (when-let ((server
> + (save-excursion
> + (let (prop)
> + (while (and (null (setq prop (get-text-property (point-at-bol) which)))
> + (zerop (forward-line -1))))
> + prop))))
> + (symbol-name server)))
> +
> (defun gnus-server-server-name ()
> - (let ((server (get-text-property (point-at-bol) 'gnus-server)))
> - (and server (symbol-name server))))
> + (gnus-server--server-name 'gnus-server))
This will make commands like `gnus-server-yank-server' fail (you can't
yank a server after the final server), I think?
So this has to be fixed the hard way, like gnus-group-mode does it --
i.e., sprinkle (when (eobp) ...) into the commands where an action on
the final line also makes sense to select the final server.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-07-01 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 21:03 bug#56329: 29.0.50; [PATCH] RET at EOB of *Server* (gnus) dick.r.chiang
2022-07-01 10:48 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7y9az2h.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=56329@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).