From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Date: Tue, 13 Sep 2022 13:59:00 +0200 Message-ID: <87o7vj32pn.fsf@gnus.org> References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> <87leqn20gn.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40821"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57755@debbugs.gnu.org, dick To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 13 14:00:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY4aR-000AG6-7K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 14:00:19 +0200 Original-Received: from localhost ([::1]:55502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oY4aQ-0005P4-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 08:00:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY4aA-0005O1-Ha for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 08:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oY4aA-0004xA-7O for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 08:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oY4aA-0005ZC-2o for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166307035221286 (code B ref 57755); Tue, 13 Sep 2022 12:00:02 +0000 Original-Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 11:59:12 +0000 Original-Received: from localhost ([127.0.0.1]:49111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4ZM-0005XG-87 for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:59:12 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4ZJ-0005Wz-VP for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 07:59:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Jwnqr0GFDIJeidwEVtvQFVVTtaUyU/3JJqLFjyvO3Yg=; b=nlz66Bb3OFZD0sLQG5aDYoOZXh C+kWZXdZBizId7V2F5kmSPqT56xwDBBQ6UsPXYl8oa2fRuYTh/CqAelaFHsEBQibzd/e8NtIVH0Tu jutxVksB9Yg3L5QEq6PJRmgYjLawr9duq58NtNT5eoq0JUR7EFpn5j+htxVYERmtrjrI=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY4ZB-0002Kc-Mx; Tue, 13 Sep 2022 13:59:03 +0200 In-Reply-To: <87leqn20gn.fsf@yahoo.com> (Po Lu's message of "Tue, 13 Sep 2022 15:32:56 +0800") X-Now-Playing: Hood's _Field Report_: "Field Report a) i An Overcast Sky Part 2" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242346 Archived-At: Po Lu writes: >> + call2 (intern ("string-trim-right"), build_string (err->message), > > What coding system is err->message? We had a make_string here before, so that's not really a change. But, yes, it should probably do some encoding here. > And calling intern with a static string is IMHO an anti-pattern that > should not be introduced further into our code. Fixed.