From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Wed, 21 Sep 2022 12:39:31 -0700 Message-ID: <87o7v8ple4.fsf@melete.silentflame.com> References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38341"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Juri Linkov , 57807-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 21:40:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ob5Zy-0009je-El for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 21:40:20 +0200 Original-Received: from localhost ([::1]:57470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ob5Zw-000370-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 15:40:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ob5Zi-00035G-UN for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 15:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ob5Zi-0000Cx-2T for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 15:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ob5Zh-00031H-MU for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 15:40:01 -0400 Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57807 X-GNU-PR-Package: emacs Mail-Followup-To: 57807@debbugs.gnu.org, spwhitton@spwhitton.name, spwhitton@spwhitton.name Original-Received: via spool by 57807-done@debbugs.gnu.org id=D57807.166378918011571 (code D ref 57807); Wed, 21 Sep 2022 19:40:01 +0000 Original-Received: (at 57807-done) by debbugs.gnu.org; 21 Sep 2022 19:39:40 +0000 Original-Received: from localhost ([127.0.0.1]:35281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob5ZM-00030Z-2m for submit@debbugs.gnu.org; Wed, 21 Sep 2022 15:39:40 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob5ZK-00030L-0o for 57807-done@debbugs.gnu.org; Wed, 21 Sep 2022 15:39:39 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C0A145C0174; Wed, 21 Sep 2022 15:39:32 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 21 Sep 2022 15:39:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663789172; x=1663875572; bh=wvbOkIPAyM juoB0La3aU2BsBUeYR3FxIcBsRdPlFhSw=; b=ovT9j/Y4uWzzN1I3T4EF5nE1uu l4mdDkfvWAjgzJKcGiwOiGwQLLUVaU70/22TxJ1moLWfAyd+YWoQFkKlEI8VLGON DrerGumfv9D5MUU6ryn24kyA7E8EvEGT96JWJHA5r06QvDVlfTtQxiByLZz00BJ0 8lzz9p0KT5NLXKErposiJ/HL8XB/zqSYZuukG6M0+pjdO2ejiQIXRaegZldSch0Y yJJjD1Ucf0xOsFL6Gi7EFSty/uLH+dqfXeM36gEnqtB3V7w8FctDoVfznCakROfC JlpHBiPVF4oVXsWO8/75MM4aAnWQ1uUqqcQNlP5GuPXMp2Nl5tV5mK06ZF9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663789172; x=1663875572; bh=wvbOkIPAyMjuoB0La3aU2BsBUeYR 3FxIcBsRdPlFhSw=; b=nNpdKmCK86/k/S1mt7KoXAjfQtgmbOgrsRc6i/xj3NEs GlbLRBcRSRW8oNcRPC7HjdKktysB9Mc4DGoW0RxRavneSlQW2NoIovQIzsJNYXE+ SJKGrJbEthhixpfILZ2vk92pRXEzcysVYdmHB/ZntMLTeGrS/e/gf1qwqBaBVvNx NjB/vAndn6Gg/RYDVVjX+dI8qvSu1jTphj4PDwV4K5JM8XW+04Y7GNrbKmgy9Vtg Qdz1z5CO0GuTE1Q9q7thaGGqjp3gXkKG7hg6OrFAcwEpCVljz9wLRaSTduqolHHf RsclvS8ihAJnNvwlO3uX6zrdw9abFh5zGyd7Q3N4dQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefuddgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Sep 2022 15:39:32 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 8E5D17F2FD9; Wed, 21 Sep 2022 12:39:31 -0700 (MST) In-Reply-To: <864jx0o903.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 21 Sep 2022 21:52:28 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243377 Archived-At: On Wed 21 Sep 2022 at 09:52PM +03, Juri Linkov wrote: > Adding vc-pre-command-functions as a counterpart of the existing > vc-post-command-functions is a nice solution. I tested everything, > and there are no more problems. Thanks for implementing this feature. Thank you for testing it. > After you will push it, it would be good also to try to generalize it > to other vc commands. The problem is that some commands already use > C-u for other purposes, such as 'C-u C-x v L' asks for a limit. What > would be a possible way to set vc-want-edit-command-p without using a > prefix arg? Maybe to add a new command that will only set > vc-want-edit-command-p for the next vc command, and bind it to > e.g. 'C-x v c'. Then 'C-x v c C-x v L' will allow editing the root > log command. Right. It would be good to find a way to make all this consistent. It's unfortunate that C-x v l and C-x v P were different to begin with. Regarding your idea, how about 'C-x V V'? It's easier to type, won't clash with another command we might want to put on 'c', and feels a bit like C-x 4 4, C-x 5 5 etc. Though, to be honest, I'd prefer it if we could come up with something involving multiple 'C-u'. -- Sean Whitton