From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#57556: 28.1; Eshell not finding executables in PATH when tramp-integration loaded Date: Sun, 09 Oct 2022 20:01:10 +0200 Message-ID: <87o7ukdggp.fsf@gmx.de> References: <87h715j5gy.fsf@gmx.de> <0480c49e-75da-68c4-d255-242ff65323fe@gmail.com> <87czbsjyby.fsf@gmx.de> <877d1vthto.fsf@gmx.de> <871qrrffzj.fsf@gmx.de> <2d1f17a5-554d-1b1f-7bcb-52e3839d9d0c@gmail.com> <87wn9iehl1.fsf@gmx.de> <00448968-481d-9bdd-b0c8-7bc3d04e5d60@gmail.com> <87fsfzh4if.fsf@gmx.de> <67159bc7-b50c-ed93-ae3e-154b240b9eb7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28048"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57556@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 09 20:02:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohacx-00074g-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 20:02:15 +0200 Original-Received: from localhost ([::1]:33652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohacw-0007xs-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 14:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohack-0007xR-Q0 for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 14:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohack-00080J-Ht for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 14:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohacj-0007td-VS for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 14:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Oct 2022 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57556 X-GNU-PR-Package: emacs Original-Received: via spool by 57556-submit@debbugs.gnu.org id=B57556.166533848330307 (code B ref 57556); Sun, 09 Oct 2022 18:02:01 +0000 Original-Received: (at 57556) by debbugs.gnu.org; 9 Oct 2022 18:01:23 +0000 Original-Received: from localhost ([127.0.0.1]:44899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohac6-0007sk-KP for submit@debbugs.gnu.org; Sun, 09 Oct 2022 14:01:22 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:60877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohac3-0007sW-Rp for 57556@debbugs.gnu.org; Sun, 09 Oct 2022 14:01:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665338472; bh=eUHKesT1lQbzdSGYuONmdOKbIEbr1mZHFPMLiwZqIJY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=KlUWXDW5VQFlNLnqgYDa3cRkIQqYjxd5b8m79JeWdHNnS4Lhq1ekuiB23wtLhbAcc k32JtLT15aaLn7mIxv736AnhdsmnFkr6UIurr9opBO4LdCIH3GBbnoZdnweXv/rl/B twlSD3LF7w3HsT1mB/0NW4y9/yD+inrSAQdfsuqQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.148.171]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCKFu-1opsKo2fR4-009MS7; Sun, 09 Oct 2022 20:01:12 +0200 In-Reply-To: <67159bc7-b50c-ed93-ae3e-154b240b9eb7@gmail.com> (Jim Porter's message of "Sat, 8 Oct 2022 15:09:13 -0700") X-Provags-ID: V03:K1:qeDAldSi17XOtDdfnkJUOBe9HzWT3mudsvXARiWP0vKrmhuVCmE 0suXfyHNfPkjsEhPeGqIORj2hfkcqo0hl+c2IOpG/4nJ1fKu1jexPlzZTdo/FXsyREEwfj8 Gu/sKyKVriVl5dIYbqorZw1HjLacJWei3wDY+YLKKHGqhNnx2xAGyBKqa0acpKP8ykkg0vo 5F8oLOLMgRQF4Qy7xVd5Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:yvanpVXdhC8=:Bk+AY7VYoKdNFokR4OkXeu 3jRADu0Zj6soMUCw59ZNuk1alzAZYDIKOSzAiJJLMQGw1vQRgSpOzlmQe8s2LOdNaseOpKPlm nMw30tIkq7hJ4l1VoOdmrFnxdqV3cNlwrOAksM/2OydL1n6tKoVVYhQvp51yBK/WA9yX8ywz5 6ukyt8wJrTtl7AcWU0P/nCNKmWO7Ta+Bq/ZbPt/S1XlvdbOgX4F3fHwCsdzmELeTxhfc4UEo3 AVFV5xN/abi6s4uAUH4a1qmxFJAJNgBQpYdkHZ36YL6buxZFAQvArhSQFid/ymRjBGxk4rqrD QxNRJA87FGIc0XQd96RFNcYTgJqlLNZX4deNTqbV7oH4AuGyLj2DoL6YnYeSbADraWIwyEWtg zx7zMTqMNoRlq2oYoqTP0lbHTnHH+wMkzgtkAdOG7Fg7QlWpoRaZy9KbSJFvKgdEOkPt89i8K B4sQH30IcJUxH91TKCbzMIctW2vfdnitQRl3SpXxOwmA1ab/7X/0NGRWZinFW4kzvMfJq/245 1KYnGqZg+PrMe/AHIEDEOuYH9iemEnIboV6GVyUyRaajnn5stog77QIuS8J5elqQRFLsr7B9p adpISlWplrJdKycf3UM5OI/lCQqGj1XnAAADU66A6/Z8GlA42/4XsmaMYIyaOzn0oXAoF6Sg1 rint+Z7clwnTnIe5GijjNdnfZTkLFV8yMiTXCL/lazU2WHcNXMvJfMVOQG5+z1zN9QiPZTCOy 3bIJR+Cil7l1Y94rG2Wv691TuHr0R3vJkrT9gFzYF6xS1boAQxm7wvEN/iqcAYG4uH+8dnAi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244970 Archived-At: Jim Porter writes: Hi Jim, > Thanks, this makes connection-local variables a lot clearer to > me. Since this seems pretty tricky to get right for people who don't > know much about connection-local variables, maybe it would make sense > to add some helper functions for anyone who wants to do something > similar? > > I attached an updated version of my connection-local.el that tries to > pull out the additions you made into some helpers. What do you think? I gave it a short reading, and in general it looks OK (comments below). Do you want to provide a patch for files-x.el with this? This patch shall also extent the "Connection Local Variables" section of the Elisp manual. This section is already quite long (~150 lines), and speaks almost about static setting of connection-local variables. You bring dynamic settings here, maybe a subsection would help to structure. And feel free to restructure the other, long text if you believe it would help. Add an example. Btw, do you have write access to the Emacs git repo? If not I recommend to ask the maintainers (Eli or Lars) for this. > (defun connection-local-profile-name () > "Get a connection-local profile name. > > This allows `connection-local-setq' to use this profile name when > setting variables connection-locally. In theory, a user of these > functions could locally override this function if they wanted to > change the naming scheme." The profile name is derived from default-directory, I would make this more obvious in the function name and the docstring. > (when connection-local-criteria > (intern (concat > "auto-connection-local-profile/" > (symbol-name (plist-get connection-local-criteria :application)) > "/" (or (file-remote-p default-directory) "local"))))) It is not guaranteed that the :application property exists. See the docstring of connection-local-criteria-alist: "All properties are optional ...". > (defun with-connection-local-application-variables-1 (application body-fun) > "Apply connection-local variables for APPLICATION in `default-directory'. > Call BODY-FUN with no args, and then unwind connection-local variables." Please say that APPLICATION must be a symbol, and shouldn't be nil (if this is what you want). Best regards, Michael.