bug#53848: [PATCH] Tweak Notmuch EBDB insinuate

bug#53848: [PATCH] Tweak Notmuch EBDB insinuate

[Utkarsh Singh]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hello,

IMHO it would be really helpful if EBDB insinuation can be hooked with
`notmuch-message-mode-hook' for the cases where `notmuch-message-mode'
is not preceded by `notmuch-show-mode'.  For eg. "directly" executing
`notmuch-mua-new-mail' command.

Thank you,
Utkarsh Singh
-- 
Utkarsh Singh
https://utkarshsingh.xyz/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 737 bytes --]

From ba05872b80d5cebcf9258c4ff5ed9deca545b09c Mon Sep 17 00:00:00 2001
From: Utkarsh Singh <utkarsh190601@gmail.com>
Date: Mon, 7 Feb 2022 20:11:52 +0530
Subject: [PATCH] ebdb-notmuch.el: Tweak Notmuch EBDB insinuate

---
 ebdb-notmuch.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ebdb-notmuch.el b/ebdb-notmuch.el
index a945b56..c01df9d 100644
--- a/ebdb-notmuch.el
+++ b/ebdb-notmuch.el
@@ -70,6 +70,7 @@ the value of `ebdb-default-window-size'."
       (define-key notmuch-message-mode-map (kbd "TAB") #'ebdb-complete-mail))))
 
 (add-hook 'notmuch-show-mode-hook #'ebdb-insinuate-notmuch)
+(add-hook 'notmuch-message-mode-hook #'ebdb-insinuate-notmuch)
 
 (provide 'ebdb-notmuch)
 ;;; ebdb-notmuch.el ends here
-- 
2.35.1

bug#53848: [PATCH] Tweak Notmuch EBDB insinuate

[Eric Abrahamsen]

Utkarsh Singh <utkarsh190601@gmail.com> writes:

> Hello,
>
> IMHO it would be really helpful if EBDB insinuation can be hooked with
> `notmuch-message-mode-hook' for the cases where `notmuch-message-mode'
> is not preceded by `notmuch-show-mode'.  For eg. "directly" executing
> `notmuch-mua-new-mail' command.

Okay, sounds good, thanks for the report! I'll make sure the insinuation
function is idempotent, then add this additional hook.

Thanks,
Eric

bug#53848: [PATCH] Tweak Notmuch EBDB insinuate

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Okay, sounds good, thanks for the report! I'll make sure the insinuation
> function is idempotent, then add this additional hook.

This was half a year ago, but then there was now followup here.  Was
this patch merged?

bug#53848: [PATCH] Tweak Notmuch EBDB insinuate

[Eric Abrahamsen]

On 09/08/22 14:55 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Okay, sounds good, thanks for the report! I'll make sure the insinuation
>> function is idempotent, then add this additional hook.
>
> This was half a year ago, but then there was now followup here.  Was
> this patch merged?

Ahem! It was not, thanks for the push. I've just done a new release of
EBDB, and am closing this now.