From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Date: Mon, 12 Dec 2022 20:05:52 +0100 Message-ID: <87o7s8o31r.fsf@gmail.com> References: <86y1rhhvsi.fsf@mail.linkov.net> <87edt6419r.fsf@gmail.com> <864ju0r002.fsf@mail.linkov.net> <83iligqyva.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59918@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 20:07:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4o90-0004zu-PX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 20:07:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4o8m-0002Pf-AF; Mon, 12 Dec 2022 14:07:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4o8k-0002PR-N4 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 14:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4o8k-00008a-98 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 14:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4o8j-0002ce-RE for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 14:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 19:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59918 X-GNU-PR-Package: emacs Original-Received: via spool by 59918-submit@debbugs.gnu.org id=B59918.167087196210062 (code B ref 59918); Mon, 12 Dec 2022 19:07:01 +0000 Original-Received: (at 59918) by debbugs.gnu.org; 12 Dec 2022 19:06:02 +0000 Original-Received: from localhost ([127.0.0.1]:54740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4o7m-0002cE-7P for submit@debbugs.gnu.org; Mon, 12 Dec 2022 14:06:02 -0500 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:40575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4o7k-0002bp-2x for 59918@debbugs.gnu.org; Mon, 12 Dec 2022 14:06:00 -0500 Original-Received: by mail-ed1-f45.google.com with SMTP id e13so14389373edj.7 for <59918@debbugs.gnu.org>; Mon, 12 Dec 2022 11:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7z43xXIPvJXeiOnIIWwuO9yysHVjs2blQTX/TeekOgs=; b=B7TeKtwxKqyQfcx6MrNfb0tzdOBVj/6cOrR88pZdvCFcnXlHjvRTl372Dt5lZItH6Y rE2mllRezcnU8qHahkjQnGqOp+Wj8Wo+Wv/VMNAMV+xatUkt2k5Mm1J/3G7bjTXeeNN+ mv/OG9T+fLGjCRa6kWV/H0elFSiJUg1cBdiSGTNs2O1tKplnORKczwIls7M2T8kxDfwd 6mxjBQts3T1vuhAIEVAh+ttOIUkjdJD9d2XwKrBKt5D/WJ+j7w4UvffsBEwvNmqbfcBh zMhXkHuZmPRplnunCh2S+bpXYEupEmkO/JOs7FJsJJ4kF9k6TQUgEbjKKPOKHLjDa4Jl mxSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7z43xXIPvJXeiOnIIWwuO9yysHVjs2blQTX/TeekOgs=; b=QXMlcRXJzl5GB7ckZfs3P6+Vwg4zqohcsik7KlVVMwQ926b+y0wzwlYQtp3jJ1Pf46 MRgEaFFWD4vcSp576JkjACPQcdHYis+fY4cb8yCay2RO/oSxhfYCmneradOrz0jvohL7 xJtv7gJ4Zh7pKaeozZiqdM7iOZKiSRBePyH00PfcrFL0BTy1BjTiHezvZWelXkyQTOgv qWHS6IaDchEu436pU8QiPXa1zNYMxuqco691q2GHTKXyTb+BM4XnnFTaq7l46b/Mej/1 waCbzdt4aEtN1NYXBp1DWz2fGQt7zoScYGHvzXbzknU5IC3ZKoj0Na0ELHoGgmmqBmJ8 vZhg== X-Gm-Message-State: ANoB5plX/iDojoFYn2UJP+GxyWyySrpfnyPfCAyV5Irc690DC+kgHaFh amFMn1ulauCYWb9lbIvJhpYUs54J4LA= X-Google-Smtp-Source: AA0mqf58IQTPdTizT4+nFRD0fWAbWtEJfnKffyTXXaAK3P94Zm5BKbwtGMWlg4jx0TvZ5YEMaKdxbA== X-Received: by 2002:a05:6402:c2:b0:461:568b:fb22 with SMTP id i2-20020a05640200c200b00461568bfb22mr14414811edu.8.1670871953591; Mon, 12 Dec 2022 11:05:53 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::a4bf]) by smtp.gmail.com with ESMTPSA id s21-20020aa7cb15000000b0047021294426sm196614edt.90.2022.12.12.11.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 11:05:53 -0800 (PST) In-Reply-To: <83iligqyva.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Dec 2022 20:07:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250745 Archived-At: On Mon, 12 Dec 2022 at 20:07, Eli Zaretskii wrote: >> Cc: 59918@debbugs.gnu.org >> From: Juri Linkov >> Date: Mon, 12 Dec 2022 19:43:25 +0200 >> >> >> 1. (setq enable-recursive-minibuffers t) >> >> 1. M-! is C-a >> >> 2. M-% is >> >> >> >> Matches are lazy-highlighted in the original buffer, >> >> but the replacement is going to be used to replace >> >> matches in the minibuffer. >> > >> > I guess this happens because minibuffer-selected-window returns the >> > original buffer. I think this patch does the trick? >> >> We need to wait until Eli decides whether to install this >> to emacs-29 or master. > > I admit that I don't understand the patch. minibuffer-selected-window > returns a window, not a buffer, and it returns the window that you > didn't want, AFAIU. The check in the patch is whether the buffer of the minibuffer-selected-window is the current buffer. It's meant to fail when you are about to start a recursive minibuffer. > Or maybe I don't understand the root cause -- could one of you please > elaborate on what happens and why this is the right patch? The original code assumed that when you are about to activate a minibuffer, the current buffer will become the (window-buffer (minibuffer-selected-window)). This is not true if you are entering a recursive minibuffer, hence the check. It may or may not be the best patch, but I would say it's the safe one if were to fix this in Emacs 29. I would also say the issue rare and basically cosmetic. > Also, was this code introduced in Emacs 28/29 or earlier? New in Emacs 29.