From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mail@daniel-mendler.de, 60867@debbugs.gnu.org
Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument
Date: Fri, 20 Jan 2023 17:11:55 +0100 [thread overview]
Message-ID: <87o7qtyylw.fsf@gmail.com> (raw)
In-Reply-To: <87h6wm1rfz.fsf@gmail.com> (Robert Pluim's message of "Thu, 19 Jan 2023 16:20:48 +0100")
tags 60867 fixed
close 60867 29.1
quit
>>>>> On Thu, 19 Jan 2023 16:20:48 +0100, Robert Pluim <rpluim@gmail.com> said:
>>>>> On Thu, 19 Jan 2023 13:27:02 +0200, Eli Zaretskii <eliz@gnu.org> said:
>>> From: Robert Pluim <rpluim@gmail.com>
>>> Cc: mail@daniel-mendler.de, 60867@debbugs.gnu.org
>>> Date: Thu, 19 Jan 2023 11:40:50 +0100
>>>
>>> >>>>> On Thu, 19 Jan 2023 12:23:17 +0200, Eli Zaretskii <eliz@gnu.org> said:
>>>
>>> >> From: Robert Pluim <rpluim@gmail.com>
>>> >> Cc: 60867@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>>> >> Date: Thu, 19 Jan 2023 10:55:49 +0100
>>> >>
>>> >> Eli, is this too much for emacs-29?
>>>
Eli> I think this is fine, as all of those functions are new in Emacs 29,
Eli> right?
>>>
>>> Yes, theyʼre all new for emacs-29.
Eli> Then patches to make them more consistent are okay, but please make
Eli> sure you don't need to update the documentation (doc strings, NEWS,
Eli> and the manuals).
Robert> The elisp manual needed adjusting, but not because of this change, the
Robert> description of `keymap-set-after' was inaccurate.
Anyway, Iʼve pushed the fix for this issue whilst I think about
Danielʼs points about `key-parse'.
Robert
--
Closing.
Committed as c7e02eaa3d
prev parent reply other threads:[~2023-01-20 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 18:20 bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Daniel Mendler
2023-01-17 17:13 ` Robert Pluim
2023-01-17 17:18 ` Daniel Mendler
2023-01-18 8:36 ` Robert Pluim
2023-01-18 10:29 ` Daniel Mendler
2023-01-19 9:55 ` Robert Pluim
2023-01-19 10:08 ` Daniel Mendler
2023-01-19 10:16 ` Robert Pluim
2023-01-19 10:39 ` Daniel Mendler
2023-01-19 11:05 ` Robert Pluim
2023-01-19 11:19 ` Daniel Mendler
2023-01-19 15:27 ` Robert Pluim
2023-01-19 15:38 ` Daniel Mendler
2023-01-19 10:23 ` Eli Zaretskii
2023-01-19 10:40 ` Robert Pluim
2023-01-19 11:27 ` Eli Zaretskii
2023-01-19 15:20 ` Robert Pluim
2023-01-20 16:11 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7qtyylw.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=60867@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).