From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer Date: Sat, 08 Apr 2023 10:58:36 +0000 (UTC) Message-ID: <87o7nymyhw.fsf@catern.com> References: <864jpsrgaz.fsf@mail.linkov.net> <86h6tr4pi8.fsf@mail.linkov.net> <87sfdbmmmh.fsf@catern.com> <838rf2opa0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62700@debbugs.gnu.org, sbaugh@janestreet.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 08 12:59:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl6Hw-0005Sa-7w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Apr 2023 12:59:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pl6Hf-0007rl-UB; Sat, 08 Apr 2023 06:59:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl6He-0007rM-Dg for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 06:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pl6He-00038a-5Y for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 06:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pl6He-0000J1-2L for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 06:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62700 X-GNU-PR-Package: emacs Original-Received: via spool by 62700-submit@debbugs.gnu.org id=B62700.16809515251151 (code B ref 62700); Sat, 08 Apr 2023 10:59:02 +0000 Original-Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 10:58:45 +0000 Original-Received: from localhost ([127.0.0.1]:57818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl6HN-0000IV-2I for submit@debbugs.gnu.org; Sat, 08 Apr 2023 06:58:45 -0400 Original-Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:10820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl6HK-0000IF-HF for 62700@debbugs.gnu.org; Sat, 08 Apr 2023 06:58:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=obqPaUbs1G+bz2KVrN2c3nzmouOBmIopXjiOQPjnWqA=; b=oTaXY+HY/PQoqoMVdEoYLvqo92IDDYZbP2Hr8SvhxvU9r0xJ/KICtv7HsHtutm+a68XI dlDGkgslLXMBwoHtbXvhW5/M9wCFQhGKL6OIKd9CmtgIshDgKSc886X+ZaKl0pgnaFlY4K Jr8fqw/UfHec/SIuyY2jCF3uJ6zmfAYC/f94/uaLYcaIAKL99g0WlB7ISBrTe9SUJFaAjm mJ3SXVxSGGh641gNwcfk7E0ddTKnTyUpxVfQg/CasJloPZ157i08ISNNAhdKqMmXhZC0/8 zvH94o5E4d5jw1dPOj03I9ZxJ2rhPlTWXosJ+WBK0JYJelQwujdIT7qe06kImCbQ== Original-Received: by filterdrecv-7457b4c9b5-8g6rq with SMTP id filterdrecv-7457b4c9b5-8g6rq-1-643148DC-8 2023-04-08 10:58:36.431887909 +0000 UTC m=+3929067.403543096 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-21 (SG) with ESMTP id UUQFZKz-S4CXAeY6AQ_pIA Sat, 08 Apr 2023 10:58:36.180 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id B801E60087; Sat, 8 Apr 2023 06:58:35 -0400 (EDT) In-Reply-To: <838rf2opa0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Apr 2023 09:34:47 +0300") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbIuvspdchYWlOzP/LeaPJBY99B/wt77jJyMusF8N/+KTehVkrDIlPqzSES9ZYqLzIz35CcD2Nlugxo6OPzl5u7NFIj9yVon74KbZCpns+cU8uVEeJEnLlNkHZtIjstJ4at+wGdg2jfoQJbOdHb2AdFMWS/qijDyARKMxK28II3kEQ== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259469 Archived-At: Eli Zaretskii writes: >> Cc: 62700@debbugs.gnu.org, Spencer Baugh >> From: sbaugh@catern.com >> Date: Fri, 07 Apr 2023 21:02:47 +0000 (UTC) >> >> Juri Linkov writes: >> > Changing the API will definitely cause problems with backwards-compatibility. >> > But maybe you could find a simple heuristic that would decide what base-suffix >> > to set in minibuffer-completion-help? Then no API changes will be needed. >> >> Thank you for the guidance and suggestion. >> >> Here's one heuristic which works decently well: > > If this is for master, I'm fine with such changes. But if you intend > to request installing this on emacs-29, then I will object making > non-trivial changes in any code that is not specific to the M- and > M- bindings that are new in Emacs 29. I don't want to risk any > regressions in general-purpose completion code at this late stage. OK, that's no problem, this can be done by just let-binding completion-base-affixes in minibuffer-{previous,next,choose}-completion so that it only affects new code. That will be a bit uglier to read so I'll do that if this approach seems reasonable with some review.