From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63271: 29.0.90; broken mouse-face Date: Thu, 11 May 2023 14:23:58 +0800 Message-ID: <87o7mrcrnl.fsf@yahoo.com> References: <86zg6kuwz5.fsf@mail.linkov.net> <83354ckrvo.fsf@gnu.org> <86h6sq3che.fsf@mail.linkov.net> <83y1m2hbp6.fsf@gnu.org> <87fs89k8r0.fsf@yahoo.com> <86fs88xbrx.fsf@mail.linkov.net> <833548dm6y.fsf@gnu.org> <86ednrur9e.fsf@mail.linkov.net> <83y1lyby15.fsf@gnu.org> <878rdy7ki8.fsf@gmx.net> <83ttwmbrve.fsf@gnu.org> <87ild2y81p.fsf@gmx.net> <86r0rqfxnn.fsf@mail.linkov.net> <87h6smh7pi.fsf@gmx.net> <86mt2eyotu.fsf@mail.linkov.net> <86pm79jpdf.fsf@mail.linkov.net> <83h6sl9up5.fsf@gnu.org> <24b4118b21a468c0eb23@heytings.org> <83bkisa1tg.fsf@gnu.org> <87sfc3g07a.fsf@yahoo.com> <834joj76hg.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gregory@heytings.org, stephen.berman@gmx.net, 63271@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 11 08:25:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwzk7-000A1g-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 May 2023 08:25:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwzjd-0007qz-D0; Thu, 11 May 2023 02:25:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwzja-0007qc-Tl for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 02:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwzja-00082D-L1 for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 02:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwzja-0002Wt-3Z for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 02:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 May 2023 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63271 X-GNU-PR-Package: emacs Original-Received: via spool by 63271-submit@debbugs.gnu.org id=B63271.16837862579655 (code B ref 63271); Thu, 11 May 2023 06:25:02 +0000 Original-Received: (at 63271) by debbugs.gnu.org; 11 May 2023 06:24:17 +0000 Original-Received: from localhost ([127.0.0.1]:49529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwziq-0002Vf-N2 for submit@debbugs.gnu.org; Thu, 11 May 2023 02:24:17 -0400 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:33906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwzil-0002VL-Qg for 63271@debbugs.gnu.org; Thu, 11 May 2023 02:24:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1683786246; bh=eO5tLyJzqa+KKcf3upCGBtHaAKuuoDtoT/J6y3pYgZc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=oG0Ffwnxazdjz74hGt4TNC8k9qKy7XHk7Zqgnj4CpHk9rWrIYXj0INPZcN4M6scoiCe5GfvaEtzNeKwu/lpH+U9DqbA6Ce8IXMD98POXg3UF6jwnqWf7VlVSO+htPDeMmi/PFLJAFYaHY9/2rMT/fztZ6ExmHBf3dF9qoLiGIS9FdPm9ar1/ufXhxj1Sj7bmvh/CZMkuzwUl5lnHjmFPCpCG6MMVYsbq3SbuIbGWm04fSTFcvW3j+7GkPT7MAz1EbuH2lryp6KWZuiOmzmURFcoTuJD9+zXuWyKKpK0CaCBQTBJYXIWj3BdZbnkufIRbvx+jdqb8tVnSeIny7QVhAQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1683786246; bh=zgjCpc6YzOedo+3NmF5Mc2/ndauYXNcL6J6ld9rlnYG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mb1t62KplM/WjU9DpCJc1IPPHXXa/cCQzPeDT9bWB3FsHxBRIXq4h/GxJQaZTB3z+zLcbacfwP5GQHk9hcY5egOa0Rp0HRI/TG3dB5uehTDEBhjTZ+Aei2+QCnzLmz6J0kAfZFJ32YkfzlIEYkY/IeUvA7NJauBFyHpJ2mpQaVGGZbbx+in6duoBr1qOguVS8cDpo8JZriLs+U9LRbDsfvmiAs6T9mva7TM2jXHkQ4OK9laOEn31/49yT0uoLr+/wXIOk/DZWlkYmxRvupvAfE/fjCTHw7tWABzF18q8cGypYZhBOEpA5G8tcXENzsd9bswM4uVJccMLEmQknWB/DA== X-YMail-OSG: 9pDysq0VM1mn13nyTcGplWnBQ224ZpAZanL8.s2wgtMnAYgKxLhFrBf5Tn4l2_w oLDjRS6_kE340VtanfLvQQKtQCiLhHNc0GgQS_l8WE1OK.W1IH.NKtkt1NTeBU_9ZbP2S3BzG3dl AOtfQ2dytEH47snbXZrTRV8QD1zEtAu_EfFZ9oPEL5CfgYnSlipLBm0GZdeW7vk91FG.Js8kJKXq si9PKJrnFCk7dNsf.sfJtBMZPmB4h9VkhP63jjaNF6GB9fulbDqL8DAnSG.QlM_5ysnOjpWCELeW MpMpM3J9F91vZ9YUxKPGCH0zhFL.5CmLjfnSUCIXSA1.Cv3_BhH8iNmBjvEk9xOn7kjsSZhx53go H2NQNqaUa7bnooIZ0POs9G8ChFkNTSsUp57qIVQyWyt0ZumhvL1kiZzVT44HIk119h0QULjxSj3T .HeAXQawAWwJnm.1z90VsgxcDZBRiONxaC.LgQeqMDdeTrJmckAqLQGPWMDxa94EZdOXGClyuxTL jYu0tDGnrj2jrUddXEBMCUmAB4EhIziCRNZVG5UF73xCPI_RFTYcBEnWibMyKsEfBGXcotP2r1yr UvH9Npvg99MlZ4R4.U18xaaXfDpJ7fZeUdNmGXoraBHr0tjXSbLg6qXXGMUMNEldWIbXVaXy3aHu D2jcbCiFYlGXUM5mk64DRV.uVjnpxdl33_iGaBBkjlP8owWZzpYeVi9rkwU3wTvmO9pT09QKDS5r LtQS6YGFlhyDDCaDSTKohUcjjjRSoRyvTWumA4nsh2OEG0AjcB69vFH7Qp.T5dkbjXBaj.y5bmZK OvHtcebnicMB3xfK3n1MK_pThjsrF2xKVIYa0sfuTf X-Sonic-MF: X-Sonic-ID: 5731072b-325b-48fe-af5a-5b3fa3f5f065 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Thu, 11 May 2023 06:24:06 +0000 Original-Received: by hermes--production-sg3-748897c457-h6mnq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 160caf25ca97b16c6226ac69c6c20fbd; Thu, 11 May 2023 06:24:03 +0000 (UTC) In-Reply-To: <834joj76hg.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 May 2023 09:00:11 +0300") X-Mailer: WebService/1.1.21471 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261544 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: Gregory Heytings , juri@linkov.net, >> 63271@debbugs.gnu.org, stephen.berman@gmx.net >> Date: Thu, 11 May 2023 08:51:05 +0800 >> >> Eli Zaretskii writes: >> >> > Po Lu, was that change intentional? If not, let's remove that line or >> > move it under some conditional that doesn't include all Cairo builds. >> > If it was intentional, please explain why, and let's take it from >> > there. >> >> It was needed to prevent drawing overhangs as part of the cursor from >> overwriting surrounding characters with the glyph string background. >> >> Unfortunately, I don't remember why it was needed, though I think the >> underlying reason has been fixed. > > So can we undo that now? If there is still a reason for doing > something special there, it will pop up sooner or later, and we can > deal with it at that time. At the very least, the setting of > s->background_filled_p should not be done when s->hl is one of the > last 3 values in enum draw_glyphs_face, I think, and maybe also when > s->for_overlaps is zero. > > I'd like to fix this soon, because I want to make another pretest of > 29.1. Yes, but please wait a day or two for me to get to a machine where I can test this. Thanks.