From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice. Date: Mon, 22 May 2023 14:46:37 +0200 Message-ID: <87o7mcjzyq.fsf@gmail.com> References: <4ACD9E26-B5A6-412E-8DFC-C09C05A4EACD@mac.com> <871qj8lp8u.fsf@gmail.com> <83zg5wpq0h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , toddasmith@mac.com, Stefan Monnier , 63625@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 14:47:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q14wb-000AC8-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 14:47:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q14wM-0007dt-TL; Mon, 22 May 2023 08:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q14wJ-0007dk-JD for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 08:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q14wJ-00029h-08 for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 08:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q14wI-0007h2-H3 for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 08:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63625 X-GNU-PR-Package: emacs Original-Received: via spool by 63625-submit@debbugs.gnu.org id=B63625.168475961429554 (code B ref 63625); Mon, 22 May 2023 12:47:02 +0000 Original-Received: (at 63625) by debbugs.gnu.org; 22 May 2023 12:46:54 +0000 Original-Received: from localhost ([127.0.0.1]:33887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q14w6-0007gY-Mk for submit@debbugs.gnu.org; Mon, 22 May 2023 08:46:54 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:55604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q14w0-0007gH-NK for 63625@debbugs.gnu.org; Mon, 22 May 2023 08:46:49 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f607839b89so4628705e9.3 for <63625@debbugs.gnu.org>; Mon, 22 May 2023 05:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684759599; x=1687351599; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=aimc18ggE6oBVMqRsYf/raJR1PieUP+936bVy7eDvy0=; b=r1T0IUb7OUjENtC2mi8N9R7RXRXWnbiWOhy1JVPxpHrkM8gy1Ksycs5rcoFP8/OhCg T0iRSEEZlSAw3zw2yJcWF3mqAhh0dS7INBBsqJcJ8gn7O6KvJZm3QsX79l4FE4Vsj8xE SV2yjLj9GJFXtGH2aF8IxMEbVB7Ny/EshGKeu8P20FBEBPEuJRKruqJtG8Z8q452a6vj 4ebZgJfqFip9f0jVQKx+mg6FXe6CS+0bRrU5Sb61TP4YJo6gMHaj4ASy4aIRYIy99H5a Sil+kPQKtmWVpc5nMJBitQAlBW0smmrsGYRUwlIF6WwdEoENV3GM2fSN4Qw8w4D+koGY 7/Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684759599; x=1687351599; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aimc18ggE6oBVMqRsYf/raJR1PieUP+936bVy7eDvy0=; b=GeWA87mJ8m0umr7KYL7HT1zClngJjjkl0XJLVm1ou5pElM95US9eO/+PSqnfNaI+kZ ec4GISer8oyZSwDP2Zv38jap5tCkmqgYFk+T1KjFhyXqzmwZX7LJXpjziRLrEvp8Y8CZ yKuODkibfDreUIRJS22u0hvgtCKmIsFwfLTnIc9X7OHCq5PuAPYLO6j9qEdp3JEQb1YL O+1zwrFGVpPej41z5tr201k64llQXdwcdvgNur7XLhHp4Q0TkKeepSNSeoljg9dx3GgN 3xUVKLyELeidNDRL84veDF+TsryBdnak5jBBLqOR9m06gs8rwRlNYPiAgNhH97164Q58 Ogzw== X-Gm-Message-State: AC+VfDx1mCylzVreSH+BLtgMOXxSekwEh9s7D59b1C/YhvF7QFw6Yn+2 X5IhgSZXH7K4uFs/P8orYNg= X-Google-Smtp-Source: ACHHUZ4z/HbVMShREtBowBBeHMdde3dhRC/KFmrXC+w97pq4rAJzMaTl0zd+0sjxTo3K1sK/adRr0w== X-Received: by 2002:a1c:c911:0:b0:3f5:772:f333 with SMTP id f17-20020a1cc911000000b003f50772f333mr6655400wmb.4.1684759598685; Mon, 22 May 2023 05:46:38 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id q1-20020a7bce81000000b003f4248dcfcbsm11534284wmj.30.2023.05.22.05.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 05:46:38 -0700 (PDT) In-Reply-To: <83zg5wpq0h.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 May 2023 14:25:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262148 Archived-At: >>>>> On Mon, 22 May 2023 14:25:02 +0300, Eli Zaretskii said: >> Cc: todd smith >> From: Robert Pluim >> Date: Mon, 22 May 2023 10:55:13 +0200 >>=20 >> This is because we didn=CA=BCt respect DRY. package.el should use the >> package support of `loaddefs-generate', but that doesn=CA=BCt expose= the >> requisite feature of `loaddefs-generate--rubric' (maybe on master it= does). >>=20 >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index 78017b77677..31e5e0809a8 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -1107,8 +1107,9 @@ package-generate-autoloads >> ;; Add the directory that will contain the autoload file to >> ;; the load path. We don't hard-code `pkg-dir', to avoid >> ;; issues if the package directory is moved around. >> + (directory-file-name >> (or (and load-file-name (file-name-directory load-file-name)) >> - (car load-path))))) >> + (car load-path)))))) >> (let ((buf (find-buffer-visiting output-file))) >> (when buf (kill-buffer buf))) >> auto-name)) Eli> Thanks. Eli> Philip, Stefan: any comments or suggestions? Two other things: 1. Can `load-file-name' ever be nil here? 2. Should we just use $# instead of `load-file-name=CA=BC'? (I also have a sneaking suspicion that this adding to `load-path' is being done twice, but I=CA=BCll look at that when this issue is fixed) Robert --=20