From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63842: 30.0.50; Slow 'gnus-summary-refer-thread' Date: Sun, 18 Jun 2023 22:57:32 +0200 Message-ID: <87o7lco5dv.fsf@ledu-giraud.fr> References: <871qiu6m1f.fsf@ledu-giraud.fr> <87bkhxl9th.fsf@ust.hk> <87ilc44r3u.fsf@ledu-giraud.fr> <831qiduv5f.fsf@gnu.org> <87352rr8vz.fsf@ledu-giraud.fr> <87fs6rashz.fsf@ust.hk> <87352ppwed.fsf@ledu-giraud.fr> <87ttv54myy.fsf@ust.hk> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24470"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 63842@debbugs.gnu.org, cohen@andy.bu.edu To: Andrew Cohen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 18 22:58:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAzTY-00064v-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jun 2023 22:58:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAzTJ-0007Js-HT; Sun, 18 Jun 2023 16:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzTG-0007JO-T0 for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 16:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAzTG-0003ME-Ko for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 16:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAzTG-0007ZK-Gf for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 16:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63842 X-GNU-PR-Package: emacs Original-Received: via spool by 63842-submit@debbugs.gnu.org id=B63842.168712185829059 (code B ref 63842); Sun, 18 Jun 2023 20:58:02 +0000 Original-Received: (at 63842) by debbugs.gnu.org; 18 Jun 2023 20:57:38 +0000 Original-Received: from localhost ([127.0.0.1]:55066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzSr-0007Yd-Tn for submit@debbugs.gnu.org; Sun, 18 Jun 2023 16:57:38 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:5465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzSp-0007YU-Ke for 63842@debbugs.gnu.org; Sun, 18 Jun 2023 16:57:36 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=D57DYWQ9 qKltrpYSMougrasV0LXvLY5Ns5ncX5DZFC4=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=HJSDXDt9O1kRJW2pgG8YbjqFnFbvvn xDmaTyhnlLgNJquLn7KO3RGXOqi4eenfqB7v9R9q3tqjWwqdn3HJGACA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=D57DYWQ9qKltrpYS MougrasV0LXvLY5Ns5ncX5DZFC4=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=W0y738L/8ESpn0aRxgXhhvmsuSsgffjlusUiYw 6UJXuSAjZPdyVvN4j/IOISAdanw8DIxrfQUSoIy85ahUfZhUe9gcHxkFSXNvWv7ENoik48 roJsJAPbROwuf9Tl28iuMxbFmwm+ahzybkXvIYvHQ62wnNFC6tEbYDXlKSJBC0aGWMQLIR vgOSiKYt30coaSvhqcrNDC87MsxE0Xc4Sg4L+XFH5AGJn2c1oRID08LM7CwwhBZ8puvtbG dlOy0LmILsBSoa55pcPH1ImQ4U3Io7UGxFkcWJoBNoJZP2E+GxHTTarbrOXk29n6h45WW+ b53MqrDfLLZHF20RpbYi0NUw== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id e72c7e3a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 18 Jun 2023 22:57:33 +0200 (CEST) In-Reply-To: <87ttv54myy.fsf@ust.hk> (Andrew Cohen's message of "Sun, 18 Jun 2023 08:45:41 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263658 Archived-At: Andrew Cohen writes: > OK, I think I understand the problem. > > Before the change that Manuel identified as the culprit of the slowdown, > thread referral resulted in the creation of a new ephemeral group to > hold the search results. One of the major features of the changes was > to try to add the articles from the search to the existing summary > buffer rather than create a new one (this is an important improvement > for a variety of reasons; for example, changes made in the additional > ephemeral buffer would be overriden when exiting the originating > buffer). > > So what Manuel is seeing: previously the new ephemeral group parses only > the headers for the articles in the thread, while in the current > implementation where the newly found articles are simply added to the > existing summary buffer, all the headers in the original buffer are > parsed. > > I need to figure out the right way to fix this. I think parsing the full > set of headers is the right thing, but since it is slow that creates a > problem. In the meantime, Manuel can you try setting > 'gnus-refer-thread-use-search to t and see if this resolves your > problem? (This should effectively restore the old behavior of creating a > new ephemeral group to hold the search result). So I have tested with 'gnus-refer-thread-use-search' set to t and it works (and is fast) as it was before. But, as you said, this creates a new nnselect group. >From my tiny testing set, it does not seems to me that parsing all the headers is the way to go: the call to 'gnus-search-run-query' in gnus-search.el line 2206 directly returns direcly the correct set of messages and the call to 'gnus-get-newsgroup-headers-xover' later looks like some "deep" search (eg. on subject content). Best regards, -- Manuel Giraud