From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64344: [PATCH] Make calculator work with customized mode-line Date: Thu, 29 Jun 2023 10:46:11 +0200 Message-ID: <87o7kyd5bg.fsf@gmx.net> References: <87jzvn4f4e.fsf@pub.pink> <83jzvmu2r1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7180"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: john muhl , 64344@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 10:47:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEnJB-0001cZ-DV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 10:47:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEnIv-0000bF-Lb; Thu, 29 Jun 2023 04:47:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEnIt-0000at-Bb for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 04:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEnIt-0001lt-1s for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 04:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEnIs-0000dF-CK for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 04:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64344-submit@debbugs.gnu.org id=B64344.16880283862384 (code B ref 64344); Thu, 29 Jun 2023 08:47:02 +0000 Original-Received: (at 64344) by debbugs.gnu.org; 29 Jun 2023 08:46:26 +0000 Original-Received: from localhost ([127.0.0.1]:52227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEnII-0000cO-98 for submit@debbugs.gnu.org; Thu, 29 Jun 2023 04:46:26 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:34937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEnID-0000c7-0b for 64344@debbugs.gnu.org; Thu, 29 Jun 2023 04:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1688028374; x=1688633174; i=stephen.berman@gmx.net; bh=N+lq8URUZ4nQR3A1IZfq6RTOHdX2UCpo1vvOY2KmuRw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=VZ1yawPJGha1NeHc6QxUULpg0KGhWTyLtr/LDB4av0sSoGRRQI9DYcyGZDZxXxuLGf2zoZ7 VIlLg4a2c4PT2vSU9Gizu2kh79Zsaz3Hhc4J86TXFNrZKY0lpmw5alyBJ2o+EW2c7qb0ytyUG Zt2ydyHFXJsNMUFGWkCNSHiTAYHqUeKHUD27tirBXHmawcdw6T+QtSvL15AzVCjZHs0KaNJhs 0Tf/YhITQpdGOVQTE7uTZaZryStEPkrB/kB54xchnLgXYUGAjIGNlUmysS5LwgtirOVcP4qkI crGIRiMIemmWirfd5/QEXYV9fSs/dNbqDeOr0W296NPhYHCI1i1w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([89.246.37.236]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MDhhN-1qMnmT1xPr-00Akjh; Thu, 29 Jun 2023 10:46:14 +0200 In-Reply-To: <83jzvmu2r1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Jun 2023 10:49:38 +0300") X-Provags-ID: V03:K1:EAMDsXEP1YKn6up7Fsj6XUoI3Ha/mpxxAKdasvGm2RbssjYj6kJ oLb8fYlsZl4bUJKRsiCrcOW8/SELYumRXUym2OFmoNEdLyxoIztCj8T1Zq5Ra4RhuPjLQBs x/GZ+zzukK5iukkD682siVt3cMuPLVLeuFp1mebOtbYrHdsyHAMt0m+5hDFyCfXzUYeLw48 cMKuzFK578jdERKGUk86w== UI-OutboundReport: notjunk:1;M01:P0:Yohf2xL5xDc=;uegeN2JMjjC2v7boLkEEkNR+IGz 7CRCh7twAgF5z16gIk3JlJf8lOYcPtW5jbX6ei/fry611brDV2OZ1irW0y6Se8b7J1ZLbutnY KnMQmAGwL/xG7SM/OEHMXAX74p8YO60D5sJElLTYvrQrLMHGkFL2s/bZdW7uhv2L1smeogCze srBDi3SY2UuN98QYMAS+U2/MPah3RG2yFC/0F7ISWzsVhZh+uEUubNnIONIOc+S102IOdUxlH yxEBoOMs7mSTAM4NJro1j8mQGxC+pmswMH3QhqC95GmcSLU2Qv0OmqKe8Q0cuqB28ka0/vyvd 8pMKnJJ5RmnQEiXMe3nxO4iuTDPuOLuHa37V/NEO8aafOZFX+f5Mc7uDDVg73a8uYcaaf1Nu7 m2cinsF5hitAGNJInmnerYC5B6EIdTixYpgOwHR3G4trAxwv4aWET0MdFkpKFa5Rlv0xgPNW+ 8xnZdetqdNBrLkNu/k0NSFsenZ1uagD0NaFbtNwyrDs54ewSVykWzZ2dryYBeCp4baOxMGCLe o/IBVg/OcGGv84+eP5qYM4ilxLkIN+F9ryyZ2DBuRFF8P3Rl2RMujzbmRmdOvRtv43V0bKsLq 1dH++HN+b/Uyfh57yzDiNRHtkP64j/WxcSZAYXxeXo007/px3MIa5WbuS9vZNplPd3Q+MHE8/ vBUYm3/xe6TT7C4v63r2vu+WVGsj7RSz7984V8r87QKE5skkTd4tlR1AmYgpHKAJFpw6LC5dK hfBHlzenBCyc63+isMRC5I3IjCLcA+aQ5Y8jAzEwig6J+rXigvADWEoTpUk7Lps6M+mAPpX+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264267 Archived-At: On Thu, 29 Jun 2023 10:49:38 +0300 Eli Zaretskii wrote: >> Date: Wed, 28 Jun 2023 13:23:45 -0500 >> From: john muhl via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> calculator.el doesn=E2=80=99t work after customizing the mode-line. It a= ssumes >> the line-width is always an integer but after using customize it is a >> dotted list. >>=20 >> - emacs -Q >> - M-x customize-apropos-faces RET mode-line RET >> - Ensure =E2=80=98mode-line-face=E2=80=99 has a box property with vert= ical and >> horizontal widths. The default config includes these already. >> - Set for current session >> - M-x calculator RET >> =3D> calculator: Wrong type argument: number-or-marker-p, (1 . -1) > > Thanks. > >> diff --git a/lisp/calculator.el b/lisp/calculator.el >> index bf2ac9b6215..6af6464d2f4 100644 >> --- a/lisp/calculator.el >> +++ b/lisp/calculator.el >> @@ -746,7 +746,7 @@ calculator-need-3-lines >> ;; use 3 lines >> (let* ((bx (face-attribute 'mode-line :box)) >> (lh (plist-get bx :line-width))) >> - (and bx (or (not lh) (> lh 0)))) >> + (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh) 0)))) Why is the state of the mode-line face shown as "EDITED, shown value does not take effect until you set or save it." before setting it in the above recipe? In fact, I see nine such faces in the buffer *Customize Faces* with -Q (the state of all other faces is shown as "STANDARD"). Steve Berman