From: "J.P." <jp@neverwas.me>
To: Fernando de Morais <fernandodemorais.jf@gmail.com>
Cc: 62444@debbugs.gnu.org, emacs-erc@gnu.org, daniel@dpettersson.net
Subject: bug#62444: [PATCH] erc: Fix "dcc get" flag parsing
Date: Fri, 07 Jul 2023 21:24:38 -0700 [thread overview]
Message-ID: <87o7kn6neh.fsf__47946.2720382557$1688790332$gmane$org@neverwas.me> (raw)
In-Reply-To: <878rbrxfkl.fsf@gmail.com> (Fernando de Morais's message of "Sat, 08 Jul 2023 00:11:38 -0300")
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
Hi Fernando,
Fernando de Morais <fernandodemorais.jf@gmail.com> writes:
> I can no longer receive files from senders whose
> nicknames contains a "|" pipe character.
>
> Example:
>
> /DCC GET EXAMPLE|Nick file_name.txt
>
> ERC returns in its buffer (followed by an *Apropos* buffer showing up in
> another window):
>
> *** DCC: Nick undefined subcommand. GET, CHAT and LIST are defined.
Thanks for the heads up. This looks like my bad. Would something like
the attached (untried) maybe suffice as a temporary workaround?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fernando.diff --]
[-- Type: text/x-patch, Size: 861 bytes --]
diff --git a/lisp/erc/erc-compat.el b/lisp/erc/erc-compat.el
index 29892b78a39..6f091668087 100644
--- a/lisp/erc/erc-compat.el
+++ b/lisp/erc/erc-compat.el
@@ -461,10 +461,14 @@ erc-compat--28-split-string-shell-command
(defmacro erc-compat--split-string-shell-command (string)
;; Autoloaded in Emacs 28.
- (list (if (fboundp 'split-string-shell-command)
- 'split-string-shell-command
- 'erc-compat--28-split-string-shell-command)
- string))
+ `(progn
+ (advice-add 'shell-backward-command :override #'goto-char)
+ (unwind-protect
+ ,(list (if (fboundp 'split-string-shell-command)
+ 'split-string-shell-command
+ 'erc-compat--28-split-string-shell-command)
+ string)
+ (advice-remove 'shell-backward-command #'goto-char))))
(provide 'erc-compat)
next prev parent reply other threads:[~2023-07-08 4:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 15:25 bug#62444: [PATCH] erc: Fix "dcc get" flag parsing Daniel Pettersson
2023-03-26 4:10 ` J.P.
[not found] ` <87a600xidp.fsf@neverwas.me>
2023-03-27 3:50 ` J.P.
2023-04-05 18:27 ` Daniel Pettersson
2023-04-08 22:53 ` J.P.
2023-07-08 3:22 ` Fernando de Morais
[not found] ` <878rbrxfkl.fsf@gmail.com>
2023-07-08 4:24 ` J.P. [this message]
2023-07-08 12:56 ` Fernando de Morais
[not found] ` <87sf9ywohp.fsf@gmail.com>
2023-07-08 14:18 ` J.P.
[not found] ` <87ttue32rd.fsf@neverwas.me>
2023-07-09 18:02 ` Fernando de Morais
[not found] ` <871qhh55g2.fsf@gmail.com>
2023-07-14 2:22 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87o7kn6neh.fsf__47946.2720382557$1688790332$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=62444@debbugs.gnu.org \
--cc=daniel@dpettersson.net \
--cc=emacs-erc@gnu.org \
--cc=fernandodemorais.jf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).