unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64795@debbugs.gnu.org
Subject: bug#64795: 30.0.50; manual-entry [(1) fails
Date: Tue, 25 Jul 2023 03:05:34 +0200	[thread overview]
Message-ID: <87o7k0u7fl.fsf@web.de> (raw)
In-Reply-To: <831qgxs7y2.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Jul 2023 17:25:09 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> How about the patch below?

I think it works well now.

> -(defvar Man-name-regexp "[-[:alnum:]_­+][-[:alnum:]_.:­+]*"
> +(defvar Man-name-regexp "[-[:alnum:]_­+[@][-[:alnum:]_.:­+]*"
>    "Regular expression describing the name of a manpage (without section).")

And this also works well now.
  
>  (defvar Man-section-regexp "[0-9][a-zA-Z0-9+]*\\|[LNln]"
> @@ -937,7 +937,9 @@ Man-completion-table
>                           "-k" (concat (when (or Man-man-k-use-anchor
>                                                  (string-equal prefix ""))
>                                          "^")
> -                                      prefix))))
> +                                      (if (string-equal prefix "")
> +                                          prefix
> +                                        (shell-quote-argument prefix))))))

I wonder however: why did you add that `shell-quote-argument' wrapper?
I think there is no shell involved.  It doesn't seem to have an effect
here, but I'm not sure if there are not more problems possible like the
one involving the empty string.

Or do you expect that some people might set `manual-program' to
something involving a shell?


Thx,

Michael.





  reply	other threads:[~2023-07-25  1:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-23  0:58 bug#64795: 30.0.50; manual-entry [(1) fails Michael Heerdegen
2023-07-23 19:23 ` Eli Zaretskii
2023-07-24  0:15   ` Michael Heerdegen
2023-07-24 14:25     ` Eli Zaretskii
2023-07-25  1:05       ` Michael Heerdegen [this message]
2023-07-25 11:45         ` Eli Zaretskii
2023-07-26  3:20           ` Michael Heerdegen
2023-07-26 14:31             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7k0u7fl.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=64795@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).