From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Thu, 10 Aug 2023 11:56:36 +0000 (UTC) Message-ID: <87o7jfi00b.fsf@catern.com> References: <86wn10e1wl.fsf@mail.linkov.net> <482a1ebc-165c-a0a4-98c0-5c404d1b1d0d@gutov.dev> <86jzwyxnxb.fsf@mail.linkov.net> <86o7m91z22.fsf@mail.linkov.net> <86pm6py6k4.fsf@mail.linkov.net> <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> <86353axu48.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30475"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 63648@debbugs.gnu.org, Spencer Baugh To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 13:57:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qU4I2-0007fU-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 13:57:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU4Ho-00050B-Oz; Thu, 10 Aug 2023 07:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU4Hm-0004yQ-T4 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 07:57:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU4Hm-00004t-JZ for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 07:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qU4Hm-0007RE-G5 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.169166860428565 (code B ref 63648); Thu, 10 Aug 2023 11:57:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 10 Aug 2023 11:56:44 +0000 Original-Received: from localhost ([127.0.0.1]:41584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU4HT-0007Qf-Rn for submit@debbugs.gnu.org; Thu, 10 Aug 2023 07:56:44 -0400 Original-Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:4844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU4HS-0007QS-Co for 63648@debbugs.gnu.org; Thu, 10 Aug 2023 07:56:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=vEAnyvyUOzuFOi+sxd89jmdxR5d03H7xjt9B48kf7Sg=; b=o3ZSBFB6+uQnJm3ViAyYwkQQfPk44sa1sItkVdPVTcvdheJiEHoIVqF197teNNqdHXD6 kfBxXtqe5VWo6baOJLVEZ4yYJNIQiOYWfxgzTBc1sOqi51cxmPOOw+n+b5V+76hvkJE/BI aflqfXpbEw39jBxGDj7nIJ02uFE21W51kBBFkNVmMYrpRLY7XPCaoWrVYQe1RmsJNRbZMc X0yfrZO1sml1KeZO1bNHvbH89uoA/63XWZ5kmv38Jx6fB030EH6tmUlE/tVmgqvVrea40j reXmQ+ZuwsWsPcLWKH/9pzsDAHpJv/M9uvPaHTCe7C1ZclgzwfeEhP6qoiaoQiyg== Original-Received: by filterdrecv-d7bbbc8bf-nxr9l with SMTP id filterdrecv-d7bbbc8bf-nxr9l-1-64D4D074-3A 2023-08-10 11:56:36.834326247 +0000 UTC m=+7906618.920059610 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-7 (SG) with ESMTP id DAOgYDLkRHeDX_BFj_FYPA Thu, 10 Aug 2023 11:56:36.754 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=linkov.net Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 7489860094; Thu, 10 Aug 2023 07:56:36 -0400 (EDT) In-Reply-To: <86353axu48.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 02 Jun 2023 09:40:55 +0300") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbJqotK6NVcN+vV1sHFPZkcoyPdSypNCFPlY2VFquoyx1J8ELMK8Qrxm4VMCLc4sLSyxigfnrriZBH18ygq4ZjfIpMBeaIwb7KW3Ujer9cWskDs+psI3rHKqxE6ZN117se9fmvFMjiyX1ckcJv5hSO6ix1vstcF6aTZ1/9mwvhHX0g== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267124 Archived-At: Juri Linkov writes: >>>>> 1. the current buffer should remain the same for the next command; >>>>> 2. the buffer-local value of 'default-directory' should remain the same; >>>>> 3. the next command should have a new value of 'default-directory'. >>>>> >>>>> I see no way to satisfy all these requirements. >>>> >>>> Except adding a variable like 'project-current-directory-override' >>>> somewhere inside 'command_loop_1'. >>> And indeed with the following patch replacing the current definition of >>> 'project-switch-project' with just: >>> (defun project-switch-project (dir) >>> (interactive (list (funcall project-prompter))) >>> (setq next-default-directory dir)) >> >> Note that we'd need to keep the previous implementation for a number of >> years anyway, to retain compatibility with older emacsen. > > Then some version-depending condition could be added. > >>> 'C-x p p (select project ...) RET M-& pwd RET' confirms that >>> the command runs in the selected project directory. >>> Whereas the original buffer keeps its previous buffer-local value >>> of 'default-directory'. >> >> I suggest you bring up this feature addition on emacs-devel, or otherwise >> wait for a review from Eli, at least. >> >> It's not a big addition, but it's a distinct new feature (the >> next-default-directory var). > > Indeed, such code addition better to be discussed on emacs-devel. Did this end up being discussed on emacs-devel? I am still quite interested in this feature. > But first need to ensure that it works with 'C-x p p'. > Currently it works with keys from the global map such as > 'C-x p p M-& pwd RET', but not with keys from 'project-prefix-map', e.g. > 'C-x p p f'. Maybe in addition to (setq next-default-directory dir) > also need to use 'set-transient-map' with 'project-prefix-map'.