From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65666: Lockfiles break package-vc-install-from-checkout Date: Fri, 01 Sep 2023 12:52:24 +0000 Message-ID: <87o7imvywn.fsf@posteo.net> References: <83edjicui8.fsf@gnu.org> <87edjiop5o.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29898"; mail-complaints-to="usenet@ciao.gmane.io" Cc: adam.porter@47ap.net, Eli Zaretskii , 65666@debbugs.gnu.org To: joseph@breatheoutbreathe.in Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 14:53:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qc3e1-0007Xc-KN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 14:53:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qc3dv-0000km-3V; Fri, 01 Sep 2023 08:52:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc3dt-0000kd-HR for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 08:52:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qc3dt-0006eB-8P for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 08:52:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qc3e1-00027t-Nw for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 08:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65666 X-GNU-PR-Package: emacs Original-Received: via spool by 65666-submit@debbugs.gnu.org id=B65666.16935727648150 (code B ref 65666); Fri, 01 Sep 2023 12:53:01 +0000 Original-Received: (at 65666) by debbugs.gnu.org; 1 Sep 2023 12:52:44 +0000 Original-Received: from localhost ([127.0.0.1]:60045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3dk-00027N-HB for submit@debbugs.gnu.org; Fri, 01 Sep 2023 08:52:44 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:60123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3di-00027A-CS for 65666@debbugs.gnu.org; Fri, 01 Sep 2023 08:52:43 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4F655240027 for <65666@debbugs.gnu.org>; Fri, 1 Sep 2023 14:52:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693572747; bh=Z7RrZ90d0OK8ACNxeEub438ccc1RYu031Kdu8qMwyeQ=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=cKeZfQdVHxXP8h0isMdTZ/Twl1m+VYvTgLpZ+5XaZ9iM0YVGSVSowRjkin9s+/Ova RSQBQOAk16xPb8sqTFxXj11KdpNHA63zyRyoaXB2R8+h3lXWURDYg6mZvcVo76799a oKyKMp+1DyNParagykU0TEVTed89sRMaP2o52yEi6+RAF58qYR07vPDZu3EKwWscmK h+FAyiKr47ddbw9ewe5YM8Nn/ae7mg/wZaAmXM7MEdoPqGmzz9I9yvu08lme5dfelr /7b65y4ahMqrgBBkIkijLABNowYqK7eFVM81umP/GZGcOW42G7j6qn53veKX7zB2+S uQdIeCp6JnmSw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RcdGf3f7dz9rxR; Fri, 1 Sep 2023 14:52:26 +0200 (CEST) In-Reply-To: (joseph@breatheoutbreathe.in's message of "Fri, 01 Sep 2023 06:18:39 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268878 Archived-At: joseph@breatheoutbreathe.in writes: > Eli Zaretskii writes: >> We should not try to native-compile lock files, obviously. Some code >> na=C3=AFvely uses "*.el" to find all the Lisp files; it should filter out >> lock files. > > Please see attached patch. > >> P.S. Please always say in what version of Emacs you see the problem >> you report. Bonus points for including all of the information >> collected by report-emacs-bug about your system and Emacs >> configurations. > > Thanks - I'm on 29.0.92. I'll include that information next time. > > From 7b38b0bfd8c9da08daf734f6d0062d31dd54b947 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Thu, 31 Aug 2023 23:11:53 -0700 > Subject: [PATCH] Don't native compile lock files > > * lisp/emacs-lisp/package.el (package--delete-directory): > Check that each file exists before compiling. > --- > lisp/emacs-lisp/package.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index e1172d69bf0..52a538e0627 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -2485,6 +2485,7 @@ compiled." > (when (featurep 'native-compile) > (cl-loop > for file in (directory-files-recursively dir "\\.el\\'") > + when (file-exists-p file) > do (comp-clean-up-stale-eln (comp-el-to-eln-filename file)))) > (if (file-symlink-p (directory-file-name dir)) > (delete-file (directory-file-name dir)) LGTM, but I wonder if there is a better way to detect lockfiles specifically? If not, I can imagine that just using `file-exists-p' would a too broad check, in the sense that it could make it difficult to find other issues?