unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Ko Nishi <kohnish@gmx.com>
Cc: 66093-done@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#66093: Eglot over tramp sshfs/sftp
Date: Tue, 26 Sep 2023 18:59:19 +0200	[thread overview]
Message-ID: <87o7ho7tw8.fsf@gmx.de> (raw)
In-Reply-To: <trinity-8bf85c45-39ed-4fac-9000-71240ebfd3b5-1695719024830@3c-app-mailcom-bs01> (Ko Nishi's message of "Tue, 26 Sep 2023 11:03:44 +0200")

Version: 29.2

Ko Nishi <kohnish@gmx.com> writes:

> Hi Micheal,

Hi Ko,

> It works pretty good on emac29.1! Thank you.

Thanks for the feedback. I've pushed the patch to the repositories,
slightly modified. It will appear with Emacs 29.2 as well as on GNU ELPA
later this week, as Tramp 2.6.1.3.

> The only thing it doesn't work is vc-root-dir on a current file.  Like
> within sshfs eshell, it returns properly, but according the
> interactive functions in my init.el that does work based on current
> file, it returns nil.

Yes. tramp-sshfs.el does not offer an implementation for
`vc-registered'. To be precise, it offers the function

--8<---------------cut here---------------start------------->8---
    (vc-registered . ignore)
--8<---------------cut here---------------end--------------->8---

Therefore, all files are not under VC control. This won't change.

> Btw, indeed, you might be right about async option, but sshfs "might"
> performce nicely for go to definition for eglot sometimes, but it's
> just an impression, I could be totally wrong if I actually measure it.

Pls tell me if you see more optimization knobs to be implemented. ATM, I
believe we have done what's possible with this bug, so I'm closing it.

> Best regards,
> Ko

Best regards, Michael.





      reply	other threads:[~2023-09-26 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 17:52 bug#66093: Eglot over tramp sshfs/sftp Ko Nishi
2023-09-19  7:46 ` Michael Albinus
2023-09-19 18:59   ` Ko Nishi
2023-09-20  9:14     ` Michael Albinus
2023-09-22 18:02     ` Michael Albinus
2023-09-22 18:11       ` Michael Albinus
2023-09-26  9:03         ` Ko Nishi
2023-09-26 16:59           ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7ho7tw8.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=66093-done@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=kohnish@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).