unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
	65896@debbugs.gnu.org, Ihor Radchenko <yantar92@posteo.net>,
	look@strawberrytea.xyz
Subject: bug#65896: 30.0.50; folding text with text properties prevents background from extending past the newline
Date: Fri, 29 Sep 2023 09:12:07 +0200	[thread overview]
Message-ID: <87o7hla1x4.fsf@gmail.com> (raw)
In-Reply-To: <86o7huvjrh.fsf@mail.linkov.net> (Juri Linkov's message of "Fri,  22 Sep 2023 09:40:42 +0300")

Juri Linkov <juri@linkov.net> writes:

>> FWIW, I would invite motivated hackers to check out magit-section and
>> see if outline-mode could be taught a new "folding style" that would use
>> the same folding principles.  My own wandering through the EIEIO maze
>> has been too brief to yield anything useful, but AFAICT the salient
>> points are:
>>
>> * setting the 'invisible overlay's BEG at the start of the "section
>> body" (after the heading's newline),
>>
>> * storing bookkeeping information (such as this beginning position) in a
>> 'magit-section property applied to the heading, so that
>> magit-section-show can retrieve that information when invoked by the
>> user with point on that heading.
>>
>> I would imagine outline.el could grow a user option to adjust overlay
>> boundaries this way, so the heading's newline would remain visible, and
>> so would any :extend property on that newline… although perhaps I'm
>> missing some key differences between outline-mode and magit-section-mode
>> that may derail this train of thought.
>
> I tried, but the conclusion was that this requires changes in the display engine.

Could you expand on what exactly you tried, and what limitations you
faced?  (Apologies if you went over this somewhere else and I missed it)

My point was that magit-section exists right now, with no changes to the
display engine, with the exact feature set of outline.el *and* the
ability to keep heading faces extended after folding sections.  So,
unless I've missed a crucial difference between the two libraries, I
don't see why outline.el could not "learn new tricks".

(FWIW magit-section advertises itself as "sections for read-only
buffers", but if there's something in there that could not be made to
work for writable buffers, I have not found it yet)








  parent reply	other threads:[~2023-09-29  7:12 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 18:00 bug#65896: 30.0.50; folding text with text properties prevents background from extending past the newline StrawberryTea
2023-09-12 18:51 ` Eli Zaretskii
2023-09-12 20:51   ` Kévin Le Gouguec
2023-09-12 21:35     ` LemonBreezes
2023-09-13 11:54       ` Eli Zaretskii
2023-09-20 12:50         ` Ihor Radchenko
2023-09-21 11:07           ` Eli Zaretskii
2023-09-22 10:12             ` Ihor Radchenko
2023-09-22 11:56               ` Eli Zaretskii
2023-09-22 12:00                 ` Ihor Radchenko
2023-09-22 12:48                   ` Eli Zaretskii
2023-09-23 10:51                     ` Ihor Radchenko
2023-09-23 11:11                       ` Eli Zaretskii
     [not found]                         ` <871qep2l2z.fsf@localhost>
2023-09-23 12:38                           ` Eli Zaretskii
2023-09-23 12:59                             ` Ihor Radchenko
2023-09-23 13:10                               ` Eli Zaretskii
2023-09-23 14:06                                 ` Ihor Radchenko
2023-09-23 18:33                                   ` StrawberryTea
2023-09-23 19:05                                     ` Eli Zaretskii
2023-09-23 19:05                                       ` StrawberryTea
2023-09-24  5:00                                         ` Eli Zaretskii
2023-09-24  7:53                                           ` StrawberryTea
2023-09-24 10:19                                             ` Ihor Radchenko
2023-09-24 11:59                                               ` Eli Zaretskii
2023-09-24 18:30                                                 ` StrawberryTea
2023-09-25  4:38                                                   ` Eli Zaretskii
2023-09-26  8:18                                                 ` Ihor Radchenko
2023-09-29  5:47                                                   ` Eli Zaretskii
2024-01-22 14:45                                                   ` Ihor Radchenko
2024-01-23 19:14                                                     ` Kévin Le Gouguec
2024-01-24 16:42                                                       ` Ihor Radchenko
2024-01-25  7:46                                                         ` Kévin Le Gouguec
2024-01-25 13:47                                                           ` Ihor Radchenko
2023-09-21 12:54           ` Eli Zaretskii
2023-09-21 21:07             ` Kévin Le Gouguec
2023-09-22  6:40               ` Juri Linkov
2023-09-22  7:20                 ` Eli Zaretskii
2023-09-29  7:12                 ` Kévin Le Gouguec [this message]
2023-09-29 15:41                   ` Juri Linkov
2023-09-29 19:07                     ` StrawberryTea
2023-09-30 13:49                       ` Eli Zaretskii
2023-09-30 22:55                         ` StrawberryTea
2023-10-01  8:42                           ` Eli Zaretskii
2023-10-02  4:28                             ` StrawberryTea
2023-10-02  6:05                               ` Eli Zaretskii
2023-10-05 20:59                                 ` StrawberryTea
2023-09-13 11:48     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7hla1x4.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=65896@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    --cc=look@strawberrytea.xyz \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).