From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#66326: 29.1.50; There should be a way to promote warnings to errors Date: Sat, 14 Oct 2023 22:25:37 +0000 (UTC) Message-ID: <87o7h0yh7k.fsf@catern.com> References: <83y1gj5ya9.fsf@gnu.org> <87wmw3zfd3.fsf@catern.com> <83wmw353ny.fsf@gnu.org> <83mswlslxu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36492"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , 66326@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 15 00:27:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrn6B-0009GI-18 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Oct 2023 00:27:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrn5k-0004kH-JC; Sat, 14 Oct 2023 18:26:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrn5i-0004k5-JP for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 18:26:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrn5i-0005o9-BL for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 18:26:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrn65-0007jm-R9 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 18:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 22:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66326-submit@debbugs.gnu.org id=B66326.169732237229683 (code B ref 66326); Sat, 14 Oct 2023 22:27:01 +0000 Original-Received: (at 66326) by debbugs.gnu.org; 14 Oct 2023 22:26:12 +0000 Original-Received: from localhost ([127.0.0.1]:50840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrn5H-0007ih-RW for submit@debbugs.gnu.org; Sat, 14 Oct 2023 18:26:12 -0400 Original-Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:30528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrn5D-0007iG-51 for 66326@debbugs.gnu.org; Sat, 14 Oct 2023 18:26:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=QgGz763y81Yp/E4L2PCVuBS9YcHDVNIFDyxO6ghoj7I=; b=tDcXX3T2k2jTdKa7rLYM5xBhPKrwc+CyQFfyEI+Ukzh9hYGtc7zlpJi9M3rG3zCeIb5A W6VYJFQt/j9fuRVUqkSQ7vVE1H3CJ5+o8tVvg/dvYsStUfh66o7Gtg2GoJfmX29MFa+0I0 f8PHlpj9FU+4ZDyKV/X84SnWaWcjrx8d8+oOtlP6K2TzEs95kVa/3pulRzMgLa/DALfWyT pyfU6DTMmrmRcRBwJXi+iTMT+Wl5chDeX+Jn5JhHYYQl+8Xe0oBrdLD36WojlYGNidSwvA UFUwaSYdIyGNT+614GZjLau5yQDLdSl+niyRZJv8ghw2yZSYS2ufYkROL3w7OKOA== Original-Received: by filterdrecv-7b646558b-pm9ll with SMTP id filterdrecv-7b646558b-pm9ll-1-652B1561-1 2023-10-14 22:25:37.078731386 +0000 UTC m=+352971.488800247 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-6 (SG) with ESMTP id frAUlyncQUmRv78PcEF7jg Sat, 14 Oct 2023 22:25:36.838 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=gnu.org Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 1041463AE2; Sat, 14 Oct 2023 18:25:35 -0400 (EDT) In-Reply-To: <83mswlslxu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Oct 2023 10:27:41 +0300") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbLXcec13I6ZW+Y9l6jqrUTraDmqXKA+CBIgKF6v4DSWBdd3IwImU2sSlaEsJX5qWEnogdLMFcHlsP78LAk0VCVltLq5nb/Ccf15BnYPT68WIpClPwZ6mm3rAh+/MzxCU41mNLBebRwDK4MCQbSgf1LvnLJs3iSsiJ7+CHtZE8osOQ== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272473 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: sbaugh@catern.com, 66326@debbugs.gnu.org >> Date: Wed, 04 Oct 2023 08:20:49 -0400 >> >> Eli Zaretskii writes: >> > And in this case, duplication is a lesser evil than reordering of >> > logic, since the chances of unintended consequences would be lower in >> > the former case. >> >> OK, how about this version then? > > This is much better, thanks. But it still fails to execute this part > right away: > > (if (not (or after-init-time noninteractive (daemonp))) > ;; Ensure warnings that happen early in the startup sequence > ;; are visible when startup completes (bug#20792). > (delay-warning type message level buffer-name) > > We must preserve this functionality, unaffected by these changes. The > patch you propose doesn't seem to guarantee that, at least not > clearly enough for my palate. Ah, actually that's deliberate. This existing expression is meant to delay warnings until they can be properly displayed; for warnings, that user can't tell that the warning was delayed - whether the warning happens during startup or at the end is indistinguishable for the user. But if a warning is turned into an error, it would be incorrect to signal that error later after startup is finished; it would e.g. mean that --debug-init would just show the error being signaled at the end of startup, instead of in the actual code that warned. (And that's one of the motivations of this change: to make it easier to debug a warning that happens during startup, by turning it into an error that can be debug-init'd)