From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simon Pugnet Newsgroups: gmane.emacs.bugs Subject: bug#67150: eglot with typescript language server >= 4.1.0 Date: Wed, 15 Nov 2023 09:51:19 +0000 Message-ID: <87o7fvfip4.fsf@polaris64.net> References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contact@sivalik.com, joaotavora@gmail.com To: 67150@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 16:48:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3I7k-000AO5-7f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 16:48:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3I7a-0007IV-KZ; Wed, 15 Nov 2023 10:48:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3I7W-0007IC-Tz for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:48:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3I7W-0002gV-Li for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3I7V-0000pc-NY for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simon Pugnet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67150 X-GNU-PR-Package: emacs Original-Received: via spool by 67150-submit@debbugs.gnu.org id=B67150.17000632763161 (code B ref 67150); Wed, 15 Nov 2023 15:48:01 +0000 Original-Received: (at 67150) by debbugs.gnu.org; 15 Nov 2023 15:47:56 +0000 Original-Received: from localhost ([127.0.0.1]:52942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3I7Q-0000ou-FJ for submit@debbugs.gnu.org; Wed, 15 Nov 2023 10:47:56 -0500 Original-Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:49016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3I7N-0000np-Br for 67150@debbugs.gnu.org; Wed, 15 Nov 2023 10:47:55 -0500 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SVdj61j48z9t21; Wed, 15 Nov 2023 10:51:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polaris64.net; s=MBO0001; t=1700041882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sRapsE5pAw7tuyiLvw4kyu2IyW9sIljJgt2rtDAV4eg=; b=NId0PFiQNkfYSrQvAOCo5NtssRh4/aFWQ48N2yEUBZ7ZFmt7E5ISVXL2UD/COe6YoITsAL /DZoqeTCle1DQKjzUlZJF/3ju6vCtv6qQd4isQHuDMDmCnEOpVEeKJH0h8QdMnLsIugqsj VJhEhI7VA3QBuvdI4wmqybSr21Th4gc/bdNcho4gODruzp/4H3/T+6zF3T5k2NWnTRbaZF WOkjuHHhKHGfl0+ltHHg3bajw30hD2XWcfE6uSohadn0G680gC1gEfKaOQiz/6Atgnsu2V vkLj47LhYp4F1FPCHLekYKMOh5D7dAa6OPTa2kKSx8qUabkBZ58oA8mbhKA2cg== In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 14 Nov 2023 00:12:24 +0000") X-Rspamd-Queue-Id: 4SVdj61j48z9t21 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274350 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > Thanks. In the meantime I asked the server author some questions and > it seems the change has been rolled back, with the server accepting=20 > the old language-ids again. But I've pushed the change to eglot.el > anyway. I think this bug can be closed, but let me know if you=20 > disagree. I'm not sure if this fix is correct. In the documentation for `eglot-server-programs' it says: - * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a string identifying the language to the server; However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets the `:language-id' to symbols. So I think these should be strings instead, e.g. "javascript". Kind regards, Simon --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCAAyFiEEO/eF3hYsAMj7Tab9uhNZqCwLPvkFAmVUlJcUHHNpbW9uQHBv bGFyaXM2NC5uZXQACgkQuhNZqCwLPvmiBw//UbPRqVQ8Hh92jA30NQdzPgEwijYZ mQIXdYB8/O8GKBqFdE5n2kK3CMSIPXAvducTdL0S1A5DOckypDGUGwdwPhTu0bj5 5GTE22oA68F4P/AHzjU1JTrrgkg+VEJ3SukxXWkFh0343RTh6axquWMiIeebabm5 RUmKwThVmxmMpQXUBDy23NUoaEle+c1yIxkjouYQitXQhkbOOG2MEasD41bqkDr8 rP7TaAod4hU7+OFUpQXuBDrdxecJ44ulJFd351GxPq3qr5Dgl80ONq+PGxMxK6DB u7AnVvgGYSErBUpFJD9xV3/Ku1YScv8f68GB/Mqv9QnNpOh7SzEtop2AQq/eVAu/ wQuqM2kAJrwxRx8EA3tXMfSWnMb/9i0ciVt6ncyJ1Cih0lYxLcH3xm+6SzcXEevH wfABWahAgzUWGP3u5I59JC3WDmZqRxLsm5hg8AZGK2Eu2CY4mMRoehPSagy+aW7V EaPQeqrdqN7vkiTpQeG/ZTiZ7H801USLHR0uua5253B4tA/5RS04m5aTxtmcvUI1 yCfky/HtUMmWkr9kYYIkwAhKiIksGPRv+AQLp4g/XopkCPAEUV4QrOQniLj1QU5l hVtWzNwjtZw7+naE1W+5SQYyBnNtoUksW2dst9ffo3OQaeeQPDyVTMjGRh7/5aIG +4qgc8q1OH1i/po= =GrPf -----END PGP SIGNATURE----- --=-=-=--