From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69782: [PATCH] Fringe bitmaps should respect alpha-background Date: Mon, 18 Mar 2024 22:02:25 +0800 Message-ID: <87o7bbr632.fsf@yahoo.com> References: <87edcex7vl.fsf@posteo.de> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30418"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69782@debbugs.gnu.org To: Nate Sandy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 18 15:03:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmDak-0007jm-2O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Mar 2024 15:03:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmDaI-0008W5-WD; Mon, 18 Mar 2024 10:03:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmDaG-0008TG-CW for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2024 10:03:24 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmDaG-0005P3-2x for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2024 10:03:24 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rmDar-0006Fv-TS for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2024 10:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2024 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69782-submit@debbugs.gnu.org id=B69782.171077060523954 (code B ref 69782); Mon, 18 Mar 2024 14:04:01 +0000 Original-Received: (at 69782) by debbugs.gnu.org; 18 Mar 2024 14:03:25 +0000 Original-Received: from localhost ([127.0.0.1]:55163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rmDaG-0006EI-M5 for submit@debbugs.gnu.org; Mon, 18 Mar 2024 10:03:24 -0400 Original-Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:45512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rmDaD-0006Dt-LM for 69782@debbugs.gnu.org; Mon, 18 Mar 2024 10:03:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1710770555; bh=M0AVaZ+LNIEVcxGq3/L3QlN245KlbjfE/juXvTdA2Nk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=IrLoqwQ9/XJGj5Q5a424dBCDrBb9yCCaIEgmlf25HuNIW363cXKb3/CB8A5y3N9EgQTqvx4xzN/D8eM2zycHLCo0Gtph3f5DpZWuBcQ1xVVJUQ3fmrLl8Ov8PjKNjgpzgKXeOWZ+lTODwu6WAMU3PBVYt4gIqO5ANzaJbolFcAIqxTOStvdCra958rvd0s604uYIGWFTrJnC7hZdSph/L4y5SCzhYgtvRTDTwO88oNxe1IHDpsapQQbwy/doSuM0J5unuIpKtO6S+i9hEBc20dyBv84/71fwOOhyBHH2pbBW67CgsfB9ZFjdEoMTE5Dq2QD8PgJepviXX2M/Un450A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1710770555; bh=wT5fkJBCJIiDlory0kML26r9eVUeOwsSSACvgRcvTq3=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=V3/9yqfAB7MXhuZJRE1NqIX4ZeLIykItKpcJjPxzvTdxw+xAc7NeqBYyBPc45RVl6f9nO1DHVwDO3yG3pumtfOLu94nt8ZT3O38F9SqbE4dA7I32z7VNrePuWvAmwZ+CiMOqVbSFfJeD3yUYZpD+I+bJ41W5/qDRMRl39OTMGQ1QqtE+hGC+AQfS+jx1nbtxiz6RzzQWu9zxMfDBGkIIRkk0CxgHPMwlx30ZEA0dDwgs5i0Zd5qiuuypkmbqLJNZ9/9sSS6o3nNHCrqass0ImFF7pqTUjlULl54c3qC6a3d025PdzP2iu0yxckLMn4k6prlxUvBc4PrsAFJs2OJTZw== X-YMail-OSG: KPVSxvgVM1k1nbfxk42Fx2Dl2zB1Lcfu5SuO3Ul_kdrqixBRdJekpz7eQsn3J0w FT92_LJkVCa2lTRLN0fBQ.rpglPMz9SJIAv8vQplN5ROBakgToNYrTA3IhBMYyUWC9rzSgh3_JAE kZLFVthLHhmnmpL8Z5ZpxWfubrjTuS0zOb4T5iPsmRloOwZ7XRGf55Bd9EIY_ffou062jORJanLq jw7xC.fO5rxnuJXpnhcReDtEh9GB6qANlG64q6KiX0Ynam1raptITzt0hAFTMmoREAFB1XJ_DlQs wkpKYMx9vcCwjHJbW0m8mpu7Ie_vasa4NsKHefNAvFJr_fB9Plehd444ekUKWD7vTCG4CJ0ScbWh 6ZmF5pQ8RLc4iykKSA3s000AZVltEHJX8V3AenyCASZxGzSTDhPDS7IlVwaCWWIti9OkdM6Kb48O RJ5j7QErjdPaCkqCbajs04jabNgpQ.nigkP98595XlYcXgwmmXm8m58suyIKYfhYBguPxS4_bmZN 24wEDjWMBFNFHPp.ZA90V0FbesllCmrMkikl6L.GCNg1ZqliY4Yx1I.Lbtp7xKfByRhpm7FWCItG g3ZBGRGqOUGEiw8IXlKRIkeR1WOCuiXIvYeEciX2tjIyldNFBX8nNaB3C8BIstYY7F8bMxlBADdk Mj1XZdhvwHhb9MP1FvUDUrScGbMwyNQupSsbWuFtd0JpAadXZS2qP8Ph1uwqDJS_aInBTIyXK6TU pbi0Vn.M5nX.iDIXoj72PeIzbtmI2aMugQF2RWnicrqKEqgNNk3gz615ohhYJRGPeigEGJxRS3Xu t5KFwERG5.A.H0iGuTBkOoHlRScnMLM4CQbory0w.J X-Sonic-MF: X-Sonic-ID: 178ec22b-5ac4-41ae-a687-45b84ddd23be Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Mon, 18 Mar 2024 14:02:35 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-xcqgp (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fb5e4c666816bdaefd02a0feff6b2189; Mon, 18 Mar 2024 14:02:31 +0000 (UTC) In-Reply-To: <87edcex7vl.fsf@posteo.de> (Nate Sandy's message of "Wed, 13 Mar 2024 19:13:34 +0000") X-Mailer: WebService/1.1.22129 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281805 Archived-At: Nate Sandy writes: > Hi, > > fringe bitmaps currently don't respect the frame parameter > 'alpha-background', i.e., their background is opaque. But since the > fringe itself *does* respect 'alpha-background', fringe bitmaps should > do the same. This patch fixes that. See attached screenshots for the > effect. > The alpha-background used here was set with: > (set-frame-parameter nil 'alpha-background 50) > > I am not sure which other platforms support 'alpha-background', and > unfortunately I am not able to test with those. PGTK and GTK 3 or no-toolkit X builds, with either Cairo or XRender. > > The change is altering the parameter 'respect_alpha_background' in > {pgtk,x}_cr_draw_image - while this name sounds quite generic, I didn't > find any other usages of this function than drawing fringe bitmaps. I > hope I didn't miss any. What about x_draw_image_foreground? > I hope that I'm following the conventions here correctly - please let me > know if I can improve anything! This patch is missing a ChangeLog entry. Though your other patch fails in several more significant respects, that can wait until the methodological concerns are resolved. Thanks for your interest in Emacs.