From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70213: Info-mode side window fit-window-to-buffer issue Date: Sun, 07 Apr 2024 16:11:07 -0700 Message-ID: <87o7ak3gfs.fsf@breatheoutbreathe.in> References: <875xww2ncc.fsf@breatheoutbreathe.in> <86h6gg56vg.fsf@gnu.org> <871q7j3l4b.fsf@breatheoutbreathe.in> <87jzlbddt3.fsf@gmx.net> <87msq71n2a.fsf@breatheoutbreathe.in> <87sezzfo22.fsf@gmx.net> <87sezzs20t.fsf@breatheoutbreathe.in> <87y19qaff3.fsf@gmx.net> <877chaqtd4.fsf@breatheoutbreathe.in> <867chal4j1.fsf@mail.linkov.net> <5657beec-3caf-4e24-838a-111a9be63eb5@gmx.at> <87le5pt5eg.fsf@breatheoutbreathe.in> <877ch9ots8.fsf@gmx.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Eli Zaretskii , 70213@debbugs.gnu.org, Juri Linkov To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 08 01:25:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtbt0-0004ov-6q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Apr 2024 01:25:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtbsi-0004wi-27; Sun, 07 Apr 2024 19:25:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtbsg-0004wX-Av for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 19:24:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtbsg-0005vK-2h for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 19:24:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtbsm-0003aY-Pg for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 19:25:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2024 23:25:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 70213-submit@debbugs.gnu.org id=B70213.171253225413561 (code B ref 70213); Sun, 07 Apr 2024 23:25:04 +0000 Original-Received: (at 70213) by debbugs.gnu.org; 7 Apr 2024 23:24:14 +0000 Original-Received: from localhost ([127.0.0.1]:44985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtbrx-0003Wf-Ne for submit@debbugs.gnu.org; Sun, 07 Apr 2024 19:24:14 -0400 Original-Received: from out-188.mta1.migadu.com ([95.215.58.188]:56883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtbrw-0003WL-4G for 70213@debbugs.gnu.org; Sun, 07 Apr 2024 19:24:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1712532239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sf3rrSYH+iPZDRJ0cdBslajSZMK5a75WIAMoMztHFLU=; b=l6Mcu2EyVNmrPR0BhXzUJY7WFoiUCzqo5xSRFGPcZ32K3LdeCYCZuETEvxvl2+5WnMJUby Cb2J34dZ4P9Ip5j322miBOtKCh3Gpv7cbr56QqsKZIM9DCwL+bXgve0bKm2MxARHkEoMdI bR2hqWy0LEiiMxkNss7I/9gv0SL+NQg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <877ch9ots8.fsf@gmx.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282901 Archived-At: Stephen Berman writes: > On Sun, 07 Apr 2024 10:53:00 -0700 Joseph Turner wrote: > >> martin rudalics writes: >> >>>>> In emacs -Q on master after Jan 6 patch, eval this: >>>> >>>> Maybe Martin could help to solve this problem (Cc-ed). >>>> >>>>> (progn >>>>> (setq fit-window-to-buffer-horizontally t) >>>>> >>>>> (setq display-buffer-alist >>>>> '(((derived-mode . Info-mode) >>>>> display-buffer-in-side-window >>>>> (side . right) >>>>> (window-width . fit-window-to-buffer)) >>>>> ((derived-mode . messages-buffer-mode) >>>>> display-buffer-in-side-window >>>>> (side . right) >>>>> (window-width . fit-window-to-buffer))))) >>> >>> At the time we call 'fit-window-to-buffer' the buffer is empty so we >>> show only 'window-min-width' columns. Don't we have 'body-function' for >>> that? >> >> Thanks for the review! We have the same understanding of the issue. >> >> What do you mean by 'body-function'? >> >>>>> I would expect the *info* window to fit to the buffer contents >>>>> when it first appears. The patch I sent earlier fixes this. >>> >>> That patch is >>> >>> Display-buffer-after-ensuring-it-contains-text.patch >> >>> IIUC. It already explains the problem in its name and does look good to >>> me. >> >> Thanks for the review! Stephen, Juri, Eli, WDYT? > > I agree that your patch is an improvement when > fit-window-to-buffer-horizontally is set to t. However, as I noted > upthread, the resulting width of the right-side window is too small, > unlike when using the same setting of display-buffer-alist with > fit-window-to-buffer-horizontally set to nil, with which the setting of > display-buffer-alist works just as well without your patch. So even > with your patch, there remains a problem. It turns out that it's necessary to set window-resize-pixelwise also, as noted in (info "(elisp)Frame Layouts with Side Windows") . In emacs -Q with the patch, the following snippet should the width of the largest line, which on my machine is 74, the width of this line: In Emacs, you can click mouse button 2 on a menu item or cross reference (progn (setq fit-window-to-buffer-horizontally t) (setq window-resize-pixelwise t) (setq display-buffer-alist '(((derived-mode . Info-mode) display-buffer-in-side-window (side . right) (window-width . fit-window-to-buffer)))) (info) (window-width)) Joseph