From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70311: Crash when dnd-indicate-insertion-point is non-nil Date: Sun, 14 Apr 2024 17:24:12 +0800 Message-ID: <87o7ac1emb.fsf@yahoo.com> References: <86wmp1pqj3.fsf@gnu.org> <87il0l325a.fsf@yahoo.com> <867ch1pium.fsf@gnu.org> <878r1h30rl.fsf@yahoo.com> <86ttk5ntfq.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33486"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70311@debbugs.gnu.org, gregsexton@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 14 11:25:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvw6p-0008Tm-Dc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Apr 2024 11:25:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvw6Z-0003ei-4V; Sun, 14 Apr 2024 05:24:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvw6V-0003eJ-VX for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 05:24:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvw6V-0004fW-Mr for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 05:24:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvw6g-00067e-KM for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 05:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Apr 2024 09:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70311 X-GNU-PR-Package: emacs Original-Received: via spool by 70311-submit@debbugs.gnu.org id=B70311.171308668723336 (code B ref 70311); Sun, 14 Apr 2024 09:25:02 +0000 Original-Received: (at 70311) by debbugs.gnu.org; 14 Apr 2024 09:24:47 +0000 Original-Received: from localhost ([127.0.0.1]:34297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvw6P-00063u-6Z for submit@debbugs.gnu.org; Sun, 14 Apr 2024 05:24:46 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:36703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvw6M-00062X-6w for 70311@debbugs.gnu.org; Sun, 14 Apr 2024 05:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713086665; bh=SYt9190WG096Az3ZezpNbNhJpuIPadqU+FnXwqPdM3o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=qT0TUN5x1uTcaawXLcvDM0EW5BvPR4+KDjUHNE1mYuhtY6+htTpvleYY4c+9JLIS0bTvFtI7pQuT6nbxdtTvbwmaj6tHwLtv1Q4GSAaWVP0FDlu1XiHCpjx+NAh+Bfjzi7yWNHQIm5wVJodkDuiQn08ul0+Pk/BOeWt2cHjUL9H+UJzqkb35EAn03Mmac0I1O2rQzQbsp0bzTZBuFpEhYxQAI5K8Yy12DiBXIemHx2wSzhUtFudzre38BexilGbTo5osNsb+kDnRglqKcn6Y2vnYe2OS4pKgWGcOfFvvHNHh/y59UjaHNxwzb7yQDLrqpavPYd2pB+Og2xVB6+yTZg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713086665; bh=9/vcfIyBxMadnbvJQJBVHfg/FASGVEsvfE489DuGIqj=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XlHXFtspnh41VG2xBmQVHPdjOhQixVhQr/yt6/PiczhwbVgNYrp2puqlYqwYFGjOTCkqt6X78FPcyuxT4hqsy3nNQtVhkg4Ar/8oYoo6rfj81DISRUIB8L7IkQ2LqzxqsrJask/aGjHKzleQ6VAJLSzXwOXLcVpVDVVgUGvgAr1c6k7BPgf3dWRb0ffYGm5DeWyAv5qX0brHvkbvlkoRH+ZAieIE7Dac/Xh9dDC8+P7fs2e/nixhh2EsjCyK8k8m2QbeciV6HOknbf0mvh2kswoo6NI/ZLfW4Ss85yEzh+Wrr4gfjILT4a8yE75aClsWNcc8VQ0a+NpqEVeNhtfpGg== X-YMail-OSG: C9mim44VM1kUoSZPqpqMl5XjrM55qcHr4_shmnwrcga9lrejKYmMTKtDQFn3yzy fgiN4WAavwAeKh8yng4v2niNLpCxIk6m1z2FKEqKCBEBJI6zNN2vqakPvWCQ8dnmLLEpPYWxZju4 s.bZzWFgvLmeFfpOfJ4rchDz0bFPF2.ZpOgxr2mgK14NNKLFFRZ7VMX8yq7M2bbOgP_HQQbEMDKF e1ApD1_7SPEY4z5W5lnoQrI9XPVNYz5Hdsu8rN4eJCXpRUsMHEnBhdzfo8ZD2d3Gw6a8UQezO5uU EIYlo8IDXYzdDxnYqAUOdqscdlsOjhLb27_kbmXcBb.ae7zQeUKXNvdRbMUbQ.sFefM.Nqm.ItEa En8tk8vLxIw3oDPd42.vsHmMxoSCm0Z4eS.HUjVWPS2RLT.qVWpW2Fa8mWCfuzBgYlqzIhQ3jonv XIdWBWpUI3k8Er7I014efaTSqXUCgxhp6ttYOubFsVc5okA5k9Ue3juQV.CUXPE9sQiZimx0.yd0 KuaaBz4G60HSNY5Hs4aVBOuNixl_.EpLDT156cF.fJ5qvbFU280Lqpsp7ptgsiGoiKPRZ9YU5gSF gSuY4Qwm4cmkSto42boYFEYkCBVlhWg458Tk6L7FxtaNpf.6WyuDgW5HUAGSau.A94y1Kbty8A7w D67KZNmOxmvFAH5C_dsTe0QSJNwL41HB4T.5WXZqwuLeEw81NK76lZwaCWgfKDFdOsMssu1nU6IU s1THLORVvlzweNvAaJAXpqilEMCo1mHnbD3sM9Vxp3LT62IlyQPifVBpmMpO_F5ll2XH8OYZ8oUS oHrbFDWM3ntu0BlVuCNsvxHt70BHYcUJLrHh1I5APn X-Sonic-MF: X-Sonic-ID: 5e606f9e-f441-42c2-8be9-431deb802ff7 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 14 Apr 2024 09:24:25 +0000 Original-Received: by hermes--production-sg3-6f9f87bd85-t6lxr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID eda24d5cc5ca3f089b84487c71cbc09d; Sun, 14 Apr 2024 09:24:18 +0000 (UTC) In-Reply-To: <86ttk5ntfq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Apr 2024 19:00:57 +0300") X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283262 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: gregsexton@gmail.com, 70311@debbugs.gnu.org >> Date: Sat, 13 Apr 2024 20:28:14 +0800 >> >> Eli Zaretskii writes: >> >> > So you think the suggested band-aid is the best we can currently do to >> > prevent crashes in those cases? >> >> Yes, unfortunately. > > Does the band-aid below look OK to you? > > diff --git a/lisp/dnd.el b/lisp/dnd.el > index 89652d3..de1c58a 100644 > --- a/lisp/dnd.el > +++ b/lisp/dnd.el > @@ -149,8 +149,13 @@ dnd-handle-movement > (with-selected-window window > (scroll-down 1)))))))) > (when dnd-indicate-insertion-point > - (ignore-errors > - (goto-char (posn-point posn))))))) > + (let ((pos (posn-point posn))) > + ;; We avoid errors here, since on some systems this runs > + ;; when waiting_for_input is non-zero, and that aborts on > + ;; error. > + (if (and pos (<= (point-min) pos (point-max))) > + (goto-char pos) > + pos)))))) Yes, please install. Thanks.