bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

[Ag Ibragimov]

It's been a while since the last time I reported a bug, please don't get
mad if something is missing. Also, it seems web search on bug tracker is
broken, I'm not sure if someone already filed it.

I noticed that after instrumenting a function
(edebug-remove-instrumentation) doesn't let you uninstrument it,
showing:

byte-code: Found no functions to remove instrumentation from

I tried with emacs -Q -- same shit.

---------------

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-05-04 built on arch-machina
Repository revision: 043bb36312039f60a464b918daa1dd214cd369f1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101012
System Description: Manjaro Linux

Configured using:
 'configure --with-json --with-native-compilation --with-xwidgets
 --with-tree-sitter --verbose'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER
WEBP X11 XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: en_US.UTF-8
  value of $LC_NUMERIC: en_US.UTF-8
  value of $LC_TIME: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

[Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ag Ibragimov <agzam.ibragimov@gmail.com> writes:

> It's been a while since the last time I reported a bug, please don't get
> mad if something is missing.

A short recipe, maybe.

> I noticed that after instrumenting a function
> (edebug-remove-instrumentation) doesn't let you uninstrument it,
> showing:
>
> byte-code: Found no functions to remove instrumentation from
>
> I tried with emacs -Q -- same shit.

Hmm - interactively, `edebug-remove-instrumentation' doesn't even find
any instrumented functions. `edebug-remove-instrumentation' of a test
function terminated without error for me but also had no effect.

Maybe something in `edebug-unwrap*' or so has to be updated for the
interpreted functions are not lists anymore patch?  CC'ing Stefan.


TIA,

Michael.

bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> I noticed that after instrumenting a function
> (edebug-remove-instrumentation) doesn't let you uninstrument it,
> showing:

I believe it should be fixed now on `master`.  Thanks.

Side note: as it is currently implemented,
`edebug-remove-instrumentation` cannot work reliably (and the way it
discovers the set of functions that can be un-instrumented is quite
wasteful, tho it seems it does the job), so I recommend you `C-M-x` to
redefine the function instead.

We should probably rework this somehow.


        Stefan

bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

[Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ag Ibragimov <agzam.ibragimov@gmail.com> writes:

> Also, it seems web search on bug tracker is broken, I'm not sure if
> someone already filed it.

Not that I know, but I also see that debbugs-gnu.el (an Emacs interface
to the bug tracker) is and has been broken for a while.

Filed as a separate report: Bug#70805.

Thanks,

Michael.

bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

[Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> > I noticed that after instrumenting a function
> > (edebug-remove-instrumentation) doesn't let you uninstrument it,
> > showing:
>
> I believe it should be fixed now on `master`.  Thanks.

Works for me.  Did not test extensively but simple examples
work again.

> Side note: as it is currently implemented,
> `edebug-remove-instrumentation` cannot work reliably (and the way it
> discovers the set of functions that can be un-instrumented is quite
> wasteful, tho it seems it does the job), so I recommend you `C-M-x` to
> redefine the function instead.

One important use case is the ability to deinstrument all functions at
once in a convenient way, so I think we at least want to keep some kind
of deinstrumenting function.


Thanks,

Michael.

bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> Side note: as it is currently implemented,
>> `edebug-remove-instrumentation` cannot work reliably (and the way it
>> discovers the set of functions that can be un-instrumented is quite
>> wasteful, tho it seems it does the job), so I recommend you `C-M-x` to
>> redefine the function instead.
>
> One important use case is the ability to deinstrument all functions at
> once in a convenient way, so I think we at least want to keep some kind
> of deinstrumenting function.

But given that it's a "best effort" kind of work, I recommend to stay
away from it when possible (until a more reliable implementation is
provided, but that may be a long time, because it's not obvious to me
how to do it).


        Stefan