From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#71213: [PATCH] Use the current face foreground for read-passwd icons Date: Sun, 26 May 2024 19:53:23 +0200 Message-ID: <87o78stq7g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10697"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus To: 71213@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 26 19:54:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBI4L-0002e1-0q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 May 2024 19:54:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBI4D-0007hg-1V; Sun, 26 May 2024 13:53:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBI4B-0007gc-3p for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 13:53:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBI4A-0003yl-Qi for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 13:53:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBI4I-0001Oa-LV; Sun, 26 May 2024 13:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: michael.albinus@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Michael Albinus Original-Received: via spool by submit@debbugs.gnu.org id=B.17167460215331 (code B ref -1); Sun, 26 May 2024 17:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 May 2024 17:53:41 +0000 Original-Received: from localhost ([127.0.0.1]:42511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBI3w-0001Nu-OV for submit@debbugs.gnu.org; Sun, 26 May 2024 13:53:41 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBI3u-0001Nm-AY for submit@debbugs.gnu.org; Sun, 26 May 2024 13:53:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBI3l-0007dT-Q8 for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 13:53:29 -0400 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBI3j-0003y5-SN for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 13:53:29 -0400 Original-Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42016c8db2aso42902875e9.0 for ; Sun, 26 May 2024 10:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716746005; x=1717350805; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=F+ofj9O+wgKiPUFsMqtwETFI+Yk7TOxATXpkS2777yA=; b=Fq+oqG4PQtH0IMEYEX1fKVw6QzYnnSKAfilIvvjn1Be9pZhfSxhHoLcl5RTgRHR4ev q+ZbZcRIICbGAFxcnKmZEs4LBSJZgJGukwsj64C+Z0ixrgSgGnbzDQkiIoqn2g1F/IAz 6hkBg+2sZSy8kAnIO7u6du3UYS/4eUxowqZk0bGEoRaqtfu3m5xFdyJ+vv0ChENxo9Gb v/+yeNEnVVTYnHXkprCDnOJbVq0Jo+37RVBjwpgaOEz8EnsyulkW9RHQnSCezdmObWZD 0mupOfledcTTv35ZxH2osE7HFIsEVX/vMYY34MSbZ6nqTrfn1sCyxiGFYOvl+LP5aWaN E6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716746005; x=1717350805; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=F+ofj9O+wgKiPUFsMqtwETFI+Yk7TOxATXpkS2777yA=; b=UgYhLGn9PQMzn4X0KN7tA1AP/qFHsjjp5YWfJBTsmRlXaWqf34Pwq6GPcY6qdn8QS6 mj2RyDpLs4twkJTy9mmVyBsdNgJ8kh2S7usgg1fSSDq/gNYtimkgw1VPF83micMgJs8p JKqFOY1SK9Q1QlFZAYbYKQ3Ne8LLklQ1+GxGKSVaDB+3hfOhlE0WliqQ74eCWd2YBU3t 0A1jmVZsW7aWjClXghv1pWR8Gwk/ibPWi4jNQWvT6wmG/XO+deIshcHBL3yVQvxmI3nc OxJ77jV+TgexR9qkup6zOM9Nb8zTaWL4ZsM2dctVwci2DfK/lPXUl4Vp75A7VnTTC/d1 +2hA== X-Gm-Message-State: AOJu0Yxr4m5vUCKJGsWbltZclmizW0KSFgF7oba2Pc6cgS7LQbyT/n6Y ZTtYrbYEGoPf3j9Dwz13KoTmTLVkzO8Pb7QxEgPNcVx5YDC0TljBB/0ClQ== X-Google-Smtp-Source: AGHT+IE4a9A54l3zTy6cNvyP/yL2AKdwFs426gB78P8e4ZYwPKwapqbsYZTXQHKGon+BfcSaqn3zTg== X-Received: by 2002:a05:600c:214c:b0:41b:3c4c:211b with SMTP id 5b1f17b1804b1-421089ffd41mr60032025e9.22.1716746004831; Sun, 26 May 2024 10:53:24 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42108966ce0sm84511195e9.8.2024.05.26.10.53.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 10:53:24 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285989 Archived-At: --=-=-= Content-Type: text/plain Tags: patch Been driving with this one for some time and somehow never got around to submitting it. We've done something similar for other icons, e.g. in 2021-11-02 "Use current face foreground for SVG icons in customize" (11702a6dd7c). I think it makes sense for these too, since "#2e3436" (and any shade of not-strictly-gray-but-close-enough) is liable to have low contrast with the mode line background depending on the theme (e.g. modus-vivendi). Let me know what you think. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-03-24 built on amdahl30 Repository revision: 0da57fa2789d180ae533b6721d60eac14f76eaee Repository branch: master Windowing system distributor 'SUSE LINUX', version 11.0.12401000 System Description: openSUSE Tumbleweed Configured using: 'configure --prefix=/home/peniblec/apps/emacs --with-cairo --with-sqlite3 --with-xinput2' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Use-the-current-face-foreground-for-read-passwd-icon.patch Content-Transfer-Encoding: quoted-printable >From 18a9430e438dbf7894bebed4374f51bce0e040ad Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?K=3DC3=3DA9vin=3D20Le=3D20Gouguec?=3D Date: Fri, 22 Mar 2024 20:24:46 +0100 Subject: [PATCH] Use the current face foreground for read-passwd icons * etc/images/conceal.svg: * etc/images/reveal.svg: Remove 'fill' attribute so that the current face's background is applied: this helps the icon's SVG representation remain legible regardless of how the mode-line is themed. --- etc/images/conceal.svg | 2 +- etc/images/reveal.svg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/etc/images/conceal.svg b/etc/images/conceal.svg index 172b73ed3d3..65695c0024e 100644 --- a/etc/images/conceal.svg +++ b/etc/images/conceal.svg @@ -1,4 +1,4 @@ - + diff --git a/etc/images/reveal.svg b/etc/images/reveal.svg index 41ae3733a53..f950311ac5a 100644 --- a/etc/images/reveal.svg +++ b/etc/images/reveal.svg @@ -1,4 +1,4 @@ - + --=20 2.45.1 --=-=-=--