From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Sun, 24 Nov 2024 09:34:51 +0200 Organization: LINKOV.NET Message-ID: <87o725f5p4.fsf@mail.linkov.net> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <86h680rhxr.fsf@gnu.org> <87h680fotv.fsf@mail.linkov.net> <864j40pfbw.fsf@gnu.org> <87bjy8e5qc.fsf@mail.linkov.net> <86y11cnyws.fsf@gnu.org> <87iksfpwlr.fsf@mail.linkov.net> <86jzcvof10.fsf@gnu.org> <87h67xren9.fsf@mail.linkov.net> <864j3xlr2r.fsf@gnu.org> <87r071oj96.fsf@mail.linkov.net> <8634jhlp3p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15446"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: dmitry@gutov.dev, 74361@debbugs.gnu.org, rudalics@gmx.at To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 24 08:38:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tF7C9-0003qZ-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Nov 2024 08:38:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tF7C0-0003Nj-1A; Sun, 24 Nov 2024 02:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tF7By-0003NE-9t for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 02:38:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tF7By-00070U-0y for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 02:38:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=rV3RpsGilIauEVpBZ+I9pToQJXI99+OMaefrghlWlQo=; b=JJuADWLI2Nn+AKCnoiqusoIflAakzzmckrSzL/SEo1VoYURRdKxsCKCupz2A9yafyIv2VLXYr38u9PO4HhF2+HoTCSKfZwIwT7MulPCOglI7wEuk7fR0J/TT5baK+ZVxan3A4VI8YlmSQS33DAgXbLi9YvAk/vfOxj39soaW0Hbsedn3oWKk7vS8Rl2nccTVRb9oros/6ig2p1tMZ7efrS/JbEsE1SHwPnaXGwv58RvOYgx6w2rG2kyS0YS/fz8N5tE4Dvx+8di5XLdq0EHsprJGBvkNd4/MPxu7zx2UBmGxqsV1tAiHbB7gmx2wmbfHYLYnBd7ciJ1ChmT/T1B0LQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tF7Bx-0003bN-S4 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 02:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Nov 2024 07:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173243383213781 (code B ref 74361); Sun, 24 Nov 2024 07:38:01 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 24 Nov 2024 07:37:12 +0000 Original-Received: from localhost ([127.0.0.1]:60576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF7B9-0003aD-UN for submit@debbugs.gnu.org; Sun, 24 Nov 2024 02:37:12 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:49169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tF7B8-0003Zx-3M for 74361@debbugs.gnu.org; Sun, 24 Nov 2024 02:37:10 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 40BCA240002; Sun, 24 Nov 2024 07:36:41 +0000 (UTC) In-Reply-To: <8634jhlp3p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Nov 2024 21:36:10 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295892 Archived-At: >> Adapting config files means replacing such settings >> >> (setopt display-comint-buffer-action >> '((display-buffer-same-window) >> (inhibit-same-window . nil))) >> >> with >> >> (add-to-list 'display-buffer-alist >> '((category . comint) >> (display-buffer-same-window) >> (inhibit-same-window . nil))) >> >> This already works since all corresponding display-buffer calls >> already provide the 'comint' category. > > They do? I thought they use display-comint-buffer-action instead? Indeed, they do this via display-comint-buffer-action. > I just searched the entire Lisp tree, and didn't find even a single > match for "(category . comint)" except in the default value of > display-comint-buffer-action. So if that user option's value is > changed, the replacement above will stop working, no? Do you mean that the users might want to shoot themselves in the foot and remove '(category . comint)' from the default value of display-comint-buffer-action? Then indeed we need to move '(category . comint)' directly to every display-buffer call that currently uses display-comint-buffer-action.