bug#75018: 30.0.93; Dired icon missing in tool-bar

bug#75018: 30.0.93; Dired icon missing in tool-bar

[john muhl]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

The usual Dired icon is missing and instead shows up as a couple
of tiny triangles in the normal state and as a very generic file
icon on hover. Happens on emacs-30 and master and X11 and PGTK
builds. Lucid and Motif builds are unaffected.


[-- Attachment #2: dired-normal.webp --]
[-- Type: image/webp, Size: 7770 bytes --]

[-- Attachment #3: dired-hover.webp --]
[-- Type: image/webp, Size: 8638 bytes --]

[-- Attachment #4: Type: text/plain, Size: 3022 bytes --]





In GNU Emacs 30.0.93 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.2) of 2024-12-21 built on thelio
Repository revision: 5e97079cc7587ce338679ed237efb911723e4367
Repository branch: emacs-30
Windowing system distributor 'The X.Org Foundation', version 11.0.12401004
System Description: Fedora Linux 41 (Workstation Edition)

Configured using:
 'configure --without-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 39074 9525) (symbols 48 5370 0) (strings 32 12568 1723)
 (string-bytes 1 306626) (vectors 16 9335)
 (vector-slots 8 111559 4018) (floats 8 21 3) (intervals 56 228 2)
 (buffers 992 10))

bug#75018: 30.0.93; Dired icon missing in tool-bar

[Eli Zaretskii]

> From: john muhl <jm@pub.pink>
> Date: Sat, 21 Dec 2024 18:19:57 -0600
> 
> The usual Dired icon is missing and instead shows up as a couple
> of tiny triangles in the normal state and as a very generic file
> icon on hover. Happens on emacs-30 and master and X11 and PGTK
> builds. Lucid and Motif builds are unaffected.

Where do the tool-bar icons come from in that build?  They are not
from the Emacs's etc/images/ directory, AFAICT.  Can you post the
Dired icon file from where your build takes them?

Also, is this problem new in the last pretest, or did previous
pretests behave the same?

bug#75018: 30.0.93; Dired icon missing in tool-bar

[john muhl]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote:
>> From: john muhl <jm@pub.pink>
>> Date: Sat, 21 Dec 2024 18:19:57 -0600
>> 
>> The usual Dired icon is missing and instead shows up as a couple
>> of tiny triangles in the normal state and as a very generic file
>> icon on hover. Happens on emacs-30 and master and X11 and PGTK
>> builds. Lucid and Motif builds are unaffected.
>
> Where do the tool-bar icons come from in that build?  They are not
> from the Emacs's etc/images/ directory, AFAICT.

They are the stock GTK icons. On this system they are located in
/usr/share/icons/. The option x-gtk-stock-map is responsible for
the mapping between Emacs' etc/images/* and the system's
icons. The attached patch fixes it here.

> Can you post the Dired icon file from where your build takes them?

Unfortunately I can't find those particular icons among the ~7000
icons in the /usr/share/icons/ directory but they're probably in
there somewhere.

> Also, is this problem new in the last pretest, or did previous
> pretests behave the same?

I tried 30.0.90 and 29.4 and they too are using the incorrect
icons. I suspect upgrading to Fedora 41 is what causes the
issue.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-Dired-icon-in-tool-bar-for-GTK-builds.patch --]
[-- Type: text/x-patch; name="0001-Fix-Dired-icon-in-tool-bar-for-GTK-builds.patch", Size: 1645 bytes --]

From 8d8f570ca0379e508330f27b7192e8e05b58602d Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Sun, 22 Dec 2024 09:10:15 -0600
Subject: [PATCH] Fix Dired icon in tool-bar for GTK builds

* lisp/term/pgtk-win.el (x-gtk-stock-map):
* lisp/term/x-win.el (x-gtk-stock-map): Update mapping for gtk-directory
icon.  (Bug#75018)
---
 lisp/term/pgtk-win.el | 2 +-
 lisp/term/x-win.el    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/term/pgtk-win.el b/lisp/term/pgtk-win.el
index 505174048f6..e49c5905ba8 100644
--- a/lisp/term/pgtk-win.el
+++ b/lisp/term/pgtk-win.el
@@ -191,7 +191,7 @@ x-gtk-stock-map
   '(
     ("etc/images/new" . ("document-new" "gtk-new"))
     ("etc/images/open" . ("document-open" "gtk-open"))
-    ("etc/images/diropen" . "gtk-directory")
+    ("etc/images/diropen" . ("system-file-manager" "gtk-directory"))
     ("etc/images/close" . ("window-close" "gtk-close"))
     ("etc/images/save" . ("document-save" "gtk-save"))
     ("etc/images/saveas" . ("document-save-as" "gtk-save-as"))
diff --git a/lisp/term/x-win.el b/lisp/term/x-win.el
index ced2750202b..8b4b869173d 100644
--- a/lisp/term/x-win.el
+++ b/lisp/term/x-win.el
@@ -1380,7 +1380,7 @@ x-gtk-stock-map
   '(
     ("etc/images/new" . ("document-new" "gtk-new"))
     ("etc/images/open" . ("document-open" "gtk-open"))
-    ("etc/images/diropen" . "gtk-directory")
+    ("etc/images/diropen" . ("system-file-manager" "gtk-directory"))
     ("etc/images/close" . ("window-close" "gtk-close"))
     ("etc/images/save" . ("document-save" "gtk-save"))
     ("etc/images/saveas" . ("document-save-as" "gtk-save-as"))
-- 
2.47.1


[-- Attachment #3: dired-fixed.webp --]
[-- Type: image/webp, Size: 7574 bytes --]

bug#75018: 30.0.93; Dired icon missing in tool-bar

[Eli Zaretskii]

> Date: Sun, 22 Dec 2024 09:32:23 -0600
> From: "john muhl" <jm@pub.pink>
> Cc: 75018@debbugs.gnu.org
> 
> On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote:
> >> From: john muhl <jm@pub.pink>
> >> Date: Sat, 21 Dec 2024 18:19:57 -0600
> >> 
> >> The usual Dired icon is missing and instead shows up as a couple
> >> of tiny triangles in the normal state and as a very generic file
> >> icon on hover. Happens on emacs-30 and master and X11 and PGTK
> >> builds. Lucid and Motif builds are unaffected.
> >
> > Where do the tool-bar icons come from in that build?  They are not
> > from the Emacs's etc/images/ directory, AFAICT.
> 
> They are the stock GTK icons. On this system they are located in
> /usr/share/icons/. The option x-gtk-stock-map is responsible for
> the mapping between Emacs' etc/images/* and the system's
> icons. The attached patch fixes it here.

Can you explain the rationale for the patch and how it solves the
problem?

> > Can you post the Dired icon file from where your build takes them?
> 
> Unfortunately I can't find those particular icons among the ~7000
> icons in the /usr/share/icons/ directory but they're probably in
> there somewhere.

If you run Emacs under GDB with a breakpoint in lookup_image, you
should see all the tool-bar icons being loaded during startup.  You
can use the following GDB commands for the breakpoint, to see when the
icon you are interested in gets loaded:

  pp spec

This should show you the full absolute file name of the icon file
Emacs is loading.

The command "pp" is defined in src/.gdbinit, so if you don't start GDB
from that directory, you will need to say

  (gdb) source /path/to/emacs/src/.gdbinit

before running Emacs, to be able to use this useful command.

> > Also, is this problem new in the last pretest, or did previous
> > pretests behave the same?
> 
> I tried 30.0.90 and 29.4 and they too are using the incorrect
> icons. I suspect upgrading to Fedora 41 is what causes the
> issue.

Yes, that's usually the first suspect in such cases.

Thanks.

bug#75018: 30.0.93; Dired icon missing in tool-bar

[Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Sun, 22 Dec 2024 18:40:45 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> Date: Sun, 22 Dec 2024 09:32:23 -0600
>> From: "john muhl" <jm@pub.pink>
>> Cc: 75018@debbugs.gnu.org
[...]
>> > Can you post the Dired icon file from where your build takes them?
>>
>> Unfortunately I can't find those particular icons among the ~7000
>> icons in the /usr/share/icons/ directory but they're probably in
>> there somewhere.
>
> If you run Emacs under GDB with a breakpoint in lookup_image, you
> should see all the tool-bar icons being loaded during startup.  You
> can use the following GDB commands for the breakpoint, to see when the
> icon you are interested in gets loaded:
>
>   pp spec
>
> This should show you the full absolute file name of the icon file
> Emacs is loading.

When I do that it shows that all the icon files are from etc/images in
the Emacs source tree and are xpm files.  However, the icons actually
displayed are the same as in screenshots John Muhl posted, except that I
also have an icon for the `dired' command.  This icon is located at
/usr/share/icons/gnome/24x24/places/folder.png (or possibly a different
size) on my system.  The other icons (which are the same as in John's
screenshots) are located under /usr/share/icons/Adwaita/symbolic here;
there is also an icon there that looks similar to the folder.png icon
used for `dired' but matches the look of the other icons, so I wonder
why Emacs uses an icon from a different set of icons in this case.  My
system is GNU/Linux with the Gtk3 toolkit and Xfce4 desktop.  It seems
that the Gtk3 build overrides the icons provided by Emacs, but not in a
completely consistent way.

Steve Berman

bug#75018: 30.0.93; Dired icon missing in tool-bar

[Eli Zaretskii]

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: "john muhl" <jm@pub.pink>,  75018@debbugs.gnu.org
> Date: Sun, 22 Dec 2024 19:15:43 +0100
> 
> On Sun, 22 Dec 2024 18:40:45 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
> 
> >> Date: Sun, 22 Dec 2024 09:32:23 -0600
> >> From: "john muhl" <jm@pub.pink>
> >> Cc: 75018@debbugs.gnu.org
> [...]
> >> > Can you post the Dired icon file from where your build takes them?
> >>
> >> Unfortunately I can't find those particular icons among the ~7000
> >> icons in the /usr/share/icons/ directory but they're probably in
> >> there somewhere.
> >
> > If you run Emacs under GDB with a breakpoint in lookup_image, you
> > should see all the tool-bar icons being loaded during startup.  You
> > can use the following GDB commands for the breakpoint, to see when the
> > icon you are interested in gets loaded:
> >
> >   pp spec
> >
> > This should show you the full absolute file name of the icon file
> > Emacs is loading.
> 
> When I do that it shows that all the icon files are from etc/images in
> the Emacs source tree and are xpm files.  However, the icons actually
> displayed are the same as in screenshots John Muhl posted, except that I
> also have an icon for the `dired' command.  This icon is located at
> /usr/share/icons/gnome/24x24/places/folder.png (or possibly a different
> size) on my system.  The other icons (which are the same as in John's
> screenshots) are located under /usr/share/icons/Adwaita/symbolic here;
> there is also an icon there that looks similar to the folder.png icon
> used for `dired' but matches the look of the other icons, so I wonder
> why Emacs uses an icon from a different set of icons in this case.  My
> system is GNU/Linux with the Gtk3 toolkit and Xfce4 desktop.  It seems
> that the Gtk3 build overrides the icons provided by Emacs, but not in a
> completely consistent way.

The reason I asked about the file is because we should try to
understand why it is not shown as expected.  If this is the result of
upgrading the system, it would be good to know how did this particular
icon file change as result of the upgrade, and why that caused the
display to fail.

bug#75018: 30.0.93; Dired icon missing in tool-bar

[john muhl]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sun, 22 Dec 2024 09:32:23 -0600
>> From: "john muhl" <jm@pub.pink>
>> Cc: 75018@debbugs.gnu.org
>> 
>> On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote:
>> >> From: john muhl <jm@pub.pink>
>> >> Date: Sat, 21 Dec 2024 18:19:57 -0600
>> >> 
>> >> The usual Dired icon is missing and instead shows up as a couple
>> >> of tiny triangles in the normal state and as a very generic file
>> >> icon on hover. Happens on emacs-30 and master and X11 and PGTK
>> >> builds. Lucid and Motif builds are unaffected.
>> >
>> > Where do the tool-bar icons come from in that build?  They are not
>> > from the Emacs's etc/images/ directory, AFAICT.
>> 
>> They are the stock GTK icons. On this system they are located in
>> /usr/share/icons/. The option x-gtk-stock-map is responsible for
>> the mapping between Emacs' etc/images/* and the system's
>> icons. The attached patch fixes it here.
>
> Can you explain the rationale for the patch and how it solves the
> problem?

Honestly I don’t understand how x-gtk-stock-map does its thing. I
was just trying to get an icon to appear.

My first idea was to remove mapping for etc/images/diropen hoping
it would fall back on the included image but that didn’t work. In
fact setting x-g-s-m to nil (PROBLEMS suggests this should cause
Emacs’ included icons to be used) causes all the icons to fail to
be found and end up looking the same way as the broken Dired icon.

>> > Can you post the Dired icon file from where your build takes them?
>> 
>> Unfortunately I can't find those particular icons among the ~7000
>> icons in the /usr/share/icons/ directory but they're probably in
>> there somewhere.
>
> If you run Emacs under GDB with a breakpoint in lookup_image, you
> should see all the tool-bar icons being loaded during startup.  You
> can use the following GDB commands for the breakpoint, to see when the
> icon you are interested in gets loaded:
>
>   pp spec
>
> This should show you the full absolute file name of the icon file
> Emacs is loading.
>
> The command "pp" is defined in src/.gdbinit, so if you don't start GDB
> from that directory, you will need to say
>
>   (gdb) source /path/to/emacs/src/.gdbinit
>
> before running Emacs, to be able to use this useful command.

With the breakpoint in place I see:

  (image :type xpm
         :file "/home/jm/tmp/emacs-30/etc/images/diropen.xpm"
         :scale default)

All the others icons similarly claim to be loaded from an XMP file
in the Emacs source directory. Of course those XMP files look
nothing like those that actually appear in the tool-bar. The icons
that are actually used are all somewhere under
/usr/share/icons/Adwaita/symbolic/.

>> > Also, is this problem new in the last pretest, or did previous
>> > pretests behave the same?
>> 
>> I tried 30.0.90 and 29.4 and they too are using the incorrect
>> icons. I suspect upgrading to Fedora 41 is what causes the
>> issue.
>
> Yes, that's usually the first suspect in such cases.
>
> Thanks.

Actually now that I’m paying attention I see missing icons all
over the place. This message-mode buffer is missing icons for
“File this draft message and exit” and “Preview”. Info mode is
missing “Goto previous node”, “Goto next node” and “Go up the info
tree”. A VC-log buffer is missing another handful...

bug#75018: 30.0.93; Dired icon missing in tool-bar

[john muhl]

Confirmation it’s not just me:

https://discussion.fedoraproject.org/t/the-gdb-toolbar-icons-are-displayed-incorrectly-in-emacs-on-fedora-41-with-gnome/136650

john muhl <jm@pub.pink> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Sun, 22 Dec 2024 09:32:23 -0600
>>> From: "john muhl" <jm@pub.pink>
>>> Cc: 75018@debbugs.gnu.org
>>> 
>>> On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote:
>>> >> From: john muhl <jm@pub.pink>
>>> >> Date: Sat, 21 Dec 2024 18:19:57 -0600
>>> >> 
>>> >> The usual Dired icon is missing and instead shows up as a couple
>>> >> of tiny triangles in the normal state and as a very generic file
>>> >> icon on hover. Happens on emacs-30 and master and X11 and PGTK
>>> >> builds. Lucid and Motif builds are unaffected.
>>> >
>>> > Where do the tool-bar icons come from in that build?  They are not
>>> > from the Emacs's etc/images/ directory, AFAICT.
>>> 
>>> They are the stock GTK icons. On this system they are located in
>>> /usr/share/icons/. The option x-gtk-stock-map is responsible for
>>> the mapping between Emacs' etc/images/* and the system's
>>> icons. The attached patch fixes it here.
>>
>> Can you explain the rationale for the patch and how it solves the
>> problem?
>
> Honestly I don’t understand how x-gtk-stock-map does its thing. I
> was just trying to get an icon to appear.
>
> My first idea was to remove mapping for etc/images/diropen hoping
> it would fall back on the included image but that didn’t work. In
> fact setting x-g-s-m to nil (PROBLEMS suggests this should cause
> Emacs’ included icons to be used) causes all the icons to fail to
> be found and end up looking the same way as the broken Dired icon.
>
>>> > Can you post the Dired icon file from where your build takes them?
>>> 
>>> Unfortunately I can't find those particular icons among the ~7000
>>> icons in the /usr/share/icons/ directory but they're probably in
>>> there somewhere.
>>
>> If you run Emacs under GDB with a breakpoint in lookup_image, you
>> should see all the tool-bar icons being loaded during startup.  You
>> can use the following GDB commands for the breakpoint, to see when the
>> icon you are interested in gets loaded:
>>
>>   pp spec
>>
>> This should show you the full absolute file name of the icon file
>> Emacs is loading.
>>
>> The command "pp" is defined in src/.gdbinit, so if you don't start GDB
>> from that directory, you will need to say
>>
>>   (gdb) source /path/to/emacs/src/.gdbinit
>>
>> before running Emacs, to be able to use this useful command.
>
> With the breakpoint in place I see:
>
>   (image :type xpm
>          :file "/home/jm/tmp/emacs-30/etc/images/diropen.xpm"
>          :scale default)
>
> All the others icons similarly claim to be loaded from an XMP file
> in the Emacs source directory. Of course those XMP files look
> nothing like those that actually appear in the tool-bar. The icons
> that are actually used are all somewhere under
> /usr/share/icons/Adwaita/symbolic/.
>
>>> > Also, is this problem new in the last pretest, or did previous
>>> > pretests behave the same?
>>> 
>>> I tried 30.0.90 and 29.4 and they too are using the incorrect
>>> icons. I suspect upgrading to Fedora 41 is what causes the
>>> issue.
>>
>> Yes, that's usually the first suspect in such cases.
>>
>> Thanks.
>
> Actually now that I’m paying attention I see missing icons all
> over the place. This message-mode buffer is missing icons for
> “File this draft message and exit” and “Preview”. Info mode is
> missing “Goto previous node”, “Goto next node” and “Go up the info
> tree”. A VC-log buffer is missing another handful...