From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>, 74963@debbugs.gnu.org
Subject: bug#74963: Ambiguous treesit named and anonymous nodes in ruby-ts-mode
Date: Wed, 25 Dec 2024 09:49:24 +0200 [thread overview]
Message-ID: <87o7102oar.fsf@mail.linkov.net> (raw)
In-Reply-To: <49EB9C70-DB16-4846-9646-F0C89B2D28D8@gmail.com> (Yuan Fu's message of "Tue, 24 Dec 2024 13:03:45 -0800")
>> This mismatched "string" in TypeScript is even more
>> unexpected than "unless" in Ruby.
>>
>> So probably we need a way to mark all used nodes as named
>> to avoid such unexpected matches. Maybe matching anonymous nodes
>> should be opt-in, and by default match only named nodes.
>
> IMHO this is just an unfortunate bug that needs to be fixed. I agree that
> this type of bug are hard to avoid, which is a bad thing, but that doesn’t
> mean we should try to alleviate it at any cost. Making predicates named by
> default just adds complexity and inflexibility for not much benefit.
Not sure if a possible flexibility is better than unintended matches.
When the authors of a ts-mode carefully selected a list of named nodes to match,
why treesit should try to match some random and unintended anonymous nodes?
next prev parent reply other threads:[~2024-12-25 7:49 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 5:06 bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes Mickey Petersen
2024-09-26 7:42 ` Yuan Fu
2024-09-26 9:56 ` Mickey Petersen
2024-09-26 10:53 ` Eli Zaretskii
2024-09-26 12:13 ` Mickey Petersen
2024-09-26 13:46 ` Eli Zaretskii
2024-09-26 15:21 ` Mickey Petersen
2024-09-26 15:45 ` Eli Zaretskii
2024-09-27 5:43 ` Yuan Fu
2024-09-29 16:56 ` Juri Linkov
2024-10-01 3:57 ` Yuan Fu
2024-10-01 17:49 ` Juri Linkov
2024-10-02 6:14 ` Yuan Fu
2024-12-05 18:52 ` Juri Linkov
2024-12-05 19:53 ` Juri Linkov
2024-12-10 17:20 ` Juri Linkov
2024-12-11 6:31 ` Yuan Fu
2024-12-11 15:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 15:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 16:50 ` Mickey Petersen
2024-12-11 18:27 ` Yuan Fu
2024-12-12 7:17 ` Juri Linkov
2024-12-12 7:40 ` Eli Zaretskii
2024-12-12 7:58 ` Juri Linkov
2024-12-12 8:14 ` Juri Linkov
2024-12-12 16:31 ` Juri Linkov
2024-12-12 17:49 ` Juri Linkov
2024-12-12 19:13 ` Eli Zaretskii
2024-12-13 7:06 ` Juri Linkov
2024-12-14 11:02 ` Eli Zaretskii
2024-12-14 18:14 ` Juri Linkov
2024-12-18 7:37 ` Juri Linkov
2024-12-19 4:04 ` Yuan Fu
2024-12-19 7:14 ` Juri Linkov
2024-12-19 7:18 ` bug#74963: Ambiguous treesit named and anonymous nodes in ruby-ts-mode Juri Linkov
2024-12-24 3:02 ` Yuan Fu
2024-12-24 7:17 ` Juri Linkov
2024-12-24 7:41 ` Juri Linkov
2025-01-13 7:31 ` Juri Linkov
2025-01-13 7:47 ` Yuan Fu
2024-12-25 3:25 ` Dmitry Gutov
2024-12-25 7:52 ` Juri Linkov
2024-12-26 1:00 ` Dmitry Gutov
2024-12-27 7:42 ` Juri Linkov
2024-12-24 17:52 ` Juri Linkov
2024-12-24 21:03 ` Yuan Fu
2024-12-25 7:49 ` Juri Linkov [this message]
2024-12-25 9:11 ` Yuan Fu
2024-12-25 17:39 ` Juri Linkov
2024-12-19 7:34 ` bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes Juri Linkov
2024-12-24 19:05 ` Juri Linkov
2024-12-24 21:14 ` Yuan Fu
2024-12-25 7:44 ` Juri Linkov
2024-12-25 8:34 ` Yuan Fu
2024-12-25 17:36 ` Juri Linkov
2024-12-27 7:59 ` Juri Linkov
2024-12-25 17:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25 18:01 ` Juri Linkov
2024-12-25 19:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-27 7:54 ` Juri Linkov
2024-12-29 17:58 ` Juri Linkov
2024-12-30 7:15 ` Juri Linkov
2024-12-30 8:00 ` Yuan Fu
2025-01-04 17:46 ` Juri Linkov
2025-01-04 19:05 ` Eli Zaretskii
2025-01-05 7:32 ` Juri Linkov
2025-01-05 11:46 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 12:18 ` Eli Zaretskii
2025-01-05 12:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 16:59 ` Eli Zaretskii
2025-01-05 18:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 17:59 ` Juri Linkov
2025-01-05 19:50 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-06 7:54 ` Juri Linkov
2025-01-06 14:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-06 17:40 ` Juri Linkov
2025-01-06 18:04 ` Yuan Fu
2025-01-06 20:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-07 18:05 ` Juri Linkov
2025-01-07 19:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-11 18:19 ` Juri Linkov
2025-01-11 19:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-12 7:34 ` Juri Linkov
2025-01-12 15:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 13:02 ` Eli Zaretskii
2025-01-05 18:05 ` Juri Linkov
2025-01-05 19:54 ` Eli Zaretskii
2025-01-06 18:02 ` Juri Linkov
2025-01-06 18:45 ` Eli Zaretskii
2025-01-06 20:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 7:37 ` Juri Linkov
2025-01-05 14:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 18:10 ` Juri Linkov
2025-01-06 8:56 ` Yuan Fu
2025-01-07 17:56 ` Juri Linkov
2025-01-07 19:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-08 2:27 ` Yuan Fu
2025-01-09 7:42 ` Juri Linkov
2025-01-09 18:39 ` Dmitry Gutov
2025-01-09 18:44 ` Juri Linkov
2025-01-10 3:14 ` Yuan Fu
2025-01-10 7:34 ` Juri Linkov
2024-12-30 13:40 ` Eli Zaretskii
2024-12-30 18:54 ` Juri Linkov
2024-12-30 19:36 ` Eli Zaretskii
2024-12-30 16:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-30 18:59 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7102oar.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=74963@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).