find-grep makes raw terminal ANSI

find-grep makes raw terminal ANSI

[jidanni]

Why when I append additional filters on find-grep, are the results
flaky? Ah, one day instead of those filters, I tried cat -v:

(find-grep "find . -type f -print0 | xargs -0 -e grep -nH -e table|cat -v")
./article-category.html:298: </^[[01;31mtable^[[m>

That's right: raw terminal highlighting characters right there in the
output. Gentlemen, I'm sure this is the wrong layer to do this. Or at
least warn in the docstring to find-grep. emacs-version "22.1.1"

Re: find-grep makes raw terminal ANSI

[Richard Stallman]

    (find-grep "find . -type f -print0 | xargs -0 -e grep -nH -e table|cat -v")
    ./article-category.html:298: </^[[01;31mtable^[[m>

    That's right: raw terminal highlighting characters right there in the
    output. Gentlemen, I'm sure this is the wrong layer to do this.

I am lost.  Which layer are you talking about, and what does it do?

Re: find-grep makes raw terminal ANSI

[jidanni]

>>>>> "r" == Richard Stallman <rms@gnu.org> writes:

r> I am lost.

Allow us to take the case of
(find-grep "find /etc/passwd -type f -print0 | xargs -0 -e grep -nH -e roo")
which works fine unless one then smacks at the end an additional filter:
(find-grep "find /etc/passwd -type f -print0 | xargs -0 -e grep -nH -e roo|grep :root")
Grep finished with no matches found at Wed Nov 14 12:03:40
whereas the same command in the shell finds something:
$ find /etc/passwd -type f -print0 | xargs -0 -e grep -nH -e roo|grep :root
/etc/passwd:1:root:x:0:0:root:/root:/bin/bash

Thus the user walks away thinking there was nothing to be found, when
all along what is happening is that ANSI terminal control characters
are being injected, as can be seen with
(find-grep "find /etc/passwd -type f -print0 | xargs -0 -e grep -nH -e roo|cat -v")

Thus the user is mislead thinking he can merely extend the UNIX filter
by another pipe, but instead unwittingly throwing away valid matches.

ANSI terminal codes have no business being injected at this layer of
the program.

Wait, I see what is going on,
12 matches for "highlight" in buffer: grep.el.gz
7 matches for "color" in buffer: grep.el.gz,
(including "The deprecated environment variable GREP_COLOR." as noted
on grep(1).)

It would be much better to put --color right there in the command line
where the user can be aware of what is going on. But that line is
already crowded.

Anyway, just wanted to let you know "I told the boss that we have no
record of that client, when all along that color jazz
undermined my extra search filter. How was I to know?"