From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4896: DocView: Continuous mode Date: Mon, 23 Nov 2009 22:43:32 +0200 Organization: JURTA Message-ID: <87my2dyzh7.fsf@mail.jurta.org> References: <87tyx2anec.fsf@mail.jurta.org> <87ocn8i9qn.fsf@mail.jurta.org> <87aayst364.fsf@thinkpad.tsdh.de> <87d43o2dgc.fsf@mail.jurta.org> <871vk3ubwj.fsf@thinkpad.tsdh.de> <87r5rpindl.fsf@mail.jurta.org> <87my2dlcs3.fsf@thinkpad.tsdh.de> Reply-To: Juri Linkov , 4896@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259011468 17277 80.91.229.12 (23 Nov 2009 21:24:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Nov 2009 21:24:28 +0000 (UTC) Cc: 4896@emacsbugs.donarmstrong.com, Stefan Monnier To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 23 22:24:21 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NCgOS-0003AR-3v for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Nov 2009 22:24:20 +0100 Original-Received: from localhost ([127.0.0.1]:52973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCgOR-0000t3-Bx for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Nov 2009 16:24:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCg8C-000237-4N for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCg86-0001zl-8p for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:30 -0500 Original-Received: from [199.232.76.173] (port=58054 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCg86-0001zf-4U for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37943) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NCg85-0007qn-7z for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nANL7LrB022250; Mon, 23 Nov 2009 13:07:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nANKt8rl020565; Mon, 23 Nov 2009 12:55:08 -0800 Resent-Date: Mon, 23 Nov 2009 12:55:08 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 23 Nov 2009 20:55:08 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4896 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4896-submit@emacsbugs.donarmstrong.com id=B4896.125900931719947 (code B ref 4896); Mon, 23 Nov 2009 20:55:08 +0000 Original-Received: (at 4896) by emacsbugs.donarmstrong.com; 23 Nov 2009 20:48:37 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nANKmZxN019943 for <4896@emacsbugs.donarmstrong.com>; Mon, 23 Nov 2009 12:48:36 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.34.24.cable.starman.ee [82.131.34.24]) by mx2.starman.ee (Postfix) with ESMTP id D324A3F40D1; Mon, 23 Nov 2009 22:48:28 +0200 (EET) In-Reply-To: <87my2dlcs3.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Mon, 23 Nov 2009 12:07:56 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 23 Nov 2009 16:07:30 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32862 Archived-At: >> The following patch adds a new variable `doc-view-continuous-mode' and >> uses it in two new commands `doc-view-next-line-or-next-page' and >> `doc-view-previous-line-or-previous-page'. > > Looks good to me, except that I have the feeling that this whole "check > if scolling happened" thingy could be refactored into its own functions > and used from doc-view-scroll-up-or-next-page and > doc-view-next-line-or-next-page (and the other two). Yes, this could be refactored after we reach a more/less final implementation. >> However, I still have no idea how make the mouse-wheel to jump to the >> next/previous page depending on the value of >> `doc-view-continuous-mode'. > > Can't you simply bind mouse-4/5 to the two new functions? mwheel.el provides many useful settings like `mouse-wheel-scroll-amount' that we should respect in DocView. -- Juri Linkov http://www.jurta.org/emacs/