From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 5148@emacsbugs.donarmstrong.com
Subject: bug#5148: Lossage in comint history
Date: Mon, 07 Dec 2009 23:05:16 +0200 [thread overview]
Message-ID: <87my1upjtq.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvbpia6177.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Mon, 07 Dec 2009 14:23:46 -0500")
>> The following patch make `comint-input-ring-size' customizable.
>> The type should be `integer' because this value is used by `make-ring'
>> to create the history ring. The default value increased to 500
>> to be the same as the default value of HISTFILESIZE and HISTSIZE.
>
> Actually, to fix the bug right, comint-read-input-ring should be changed
> to grow the ring so as to accomodate all the saved history. This might
> still truncate it more than bash would have, but at least it won't make
> your .bash_history shorter than it was.
Someone still might want to truncate the history to the length defined
by `comint-input-ring-size'. So adding defcustom is useful in any case.
Later we could add more options to `comint-input-ring-size' e.g. `t'
like in `message-log-max'. It's easy to implement this (by reading
all history in `comint-read-input-ring' and using `ring-insert+extend'
while adding new elements) but I don't think this should be the default
because bash users might prefer `comint-input-ring-size' to have the
same value as `HISTFILESIZE'. Maybe we should add another option
for `comint-input-ring-size' to set it to (getenv "HISTFILESIZE")
when it is used by `M-x shell'.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-12-07 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87y6kh8y0j.fsf@stupidchicken.com>
2009-12-07 17:27 ` bug#5148: Lossage in comint history Juri Linkov
2009-12-07 19:23 ` Stefan Monnier
2009-12-07 21:05 ` Juri Linkov [this message]
2010-01-01 18:46 ` bug#5148: marked as done (Lossage in comint history) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87my1upjtq.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=5148@emacsbugs.donarmstrong.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).