From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5732: css-mode doesn't correctly highlight "grouped" selectors Date: Sat, 10 Apr 2010 13:16:30 -0400 Message-ID: <87mxxbjki9.fsf@stupidchicken.com> References: <7b501d5c1003170425t50af9a6bhd52eb01df72b4682@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1270920573 13622 80.91.229.12 (10 Apr 2010 17:29:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 10 Apr 2010 17:29:33 +0000 (UTC) Cc: 5732@debbugs.gnu.org To: Deniz Dogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 10 19:29:31 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O0eUs-0005Rq-BX for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2010 19:29:30 +0200 Original-Received: from localhost ([127.0.0.1]:43935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0eUr-0007yi-QB for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2010 13:29:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0eUD-0007d5-4u for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 13:28:49 -0400 Original-Received: from [140.186.70.92] (port=36427 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0eUA-0007bg-W3 for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 13:28:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0eU9-0004Zf-Lu for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 13:28:46 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48061) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0eU9-0004ZU-Dp for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 13:28:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O0eIn-0002lA-PN; Sat, 10 Apr 2010 13:17:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <7b501d5c1003170425t50af9a6bhd52eb01df72b4682@mail.gmail.com> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2010 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5732-submit@debbugs.gnu.org id=B5732.127091979410597 (code B ref 5732); Sat, 10 Apr 2010 17:17:01 +0000 Original-Received: (at 5732) by debbugs.gnu.org; 10 Apr 2010 17:16:34 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0eIM-0002ks-Ho for submit@debbugs.gnu.org; Sat, 10 Apr 2010 13:16:34 -0400 Original-Received: from pantheon-po17.its.yale.edu ([130.132.50.73]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0eIL-0002kn-2O for 5732@debbugs.gnu.org; Sat, 10 Apr 2010 13:16:33 -0400 Original-Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po17.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3AHGUhF012949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 10 Apr 2010 13:16:31 -0400 Original-Received: by furry (Postfix, from userid 1000) id A8295C055; Sat, 10 Apr 2010 13:16:30 -0400 (EDT) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 10 Apr 2010 13:17:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36166 Archived-At: > css-mode doesn't seem to correctly highlight anything but the last > selector if grouping them as such: > > #topic span, > #topic b, > #topic i { > ... > } How bout something like this? *** lisp/textmodes/css-mode.el 2010-01-13 08:35:10 +0000 --- lisp/textmodes/css-mode.el 2010-04-10 17:13:44 +0000 *************** *** 236,242 **** ;; thus prevent this highlighting from being applied (actually now that ;; I use `append' this should work better). But really the part of hte ;; selector between [...] should simply not be highlighted. ! (,(concat "^\\([ \t]*[^@:{\n][^:{\n]+\\(?::" (regexp-opt css-pseudo-ids t) "\\(?:([^)]+)\\)?[^:{\n]*\\)*\\)\\(?:\n[ \t]*\\)*{") (1 'css-selector append)) ;; In the above rule, we allow the open-brace to be on some subsequent --- 236,242 ---- ;; thus prevent this highlighting from being applied (actually now that ;; I use `append' this should work better). But really the part of hte ;; selector between [...] should simply not be highlighted. ! (,(concat "^\\([ \t]*[^@:{}\n][^:{}]+\\(?::" (regexp-opt css-pseudo-ids t) "\\(?:([^)]+)\\)?[^:{\n]*\\)*\\)\\(?:\n[ \t]*\\)*{") (1 'css-selector append)) ;; In the above rule, we allow the open-brace to be on some subsequent