From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#6100: c-beginning-of-defun doesn't push mark Date: Tue, 04 May 2010 19:01:45 +0300 Organization: JURTA Message-ID: <87mxwf942y.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1273036632 26571 80.91.229.12 (5 May 2010 05:17:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 5 May 2010 05:17:12 +0000 (UTC) To: 6100@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 05 07:17:10 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Wys-0001xp-1A for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 May 2010 07:17:10 +0200 Original-Received: from localhost ([127.0.0.1]:57935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9Wyr-0007uD-8r for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 May 2010 01:17:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9Kwh-0003nI-KW for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:26:07 -0400 Original-Received: from [140.186.70.92] (port=38108 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9Kwf-0003mN-K2 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9Kwd-0000Fx-Vn for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:26:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50445) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Kwd-0000Fo-Tj for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O9Kuf-0000nA-NH; Tue, 04 May 2010 12:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2010 16:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6100 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.12729901883030 (code B ref -1); Tue, 04 May 2010 16:24:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 May 2010 16:23:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Kto-0000mp-8V for submit@debbugs.gnu.org; Tue, 04 May 2010 12:23:08 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Ktm-0000mN-Ri for submit@debbugs.gnu.org; Tue, 04 May 2010 12:23:07 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:39556) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O9Kth-0003mn-V8 for submit@debbugs.gnu.org; Tue, 04 May 2010 12:23:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9Ktg-00022C-U0 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:23:01 -0400 Original-Received: from [140.186.70.92] (port=41065 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9Ktb-0001wy-N3 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:22:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9Kta-00086u-80 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:22:55 -0400 Original-Received: from smtp-out1.starman.ee ([85.253.0.3]:49317 helo=mx1.starman.ee) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Kta-00086F-2U for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:22:54 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.30.129.cable.starman.ee [82.131.30.129]) by mx1.starman.ee (Postfix) with ESMTP id 1F4E23F40FE for ; Tue, 4 May 2010 19:22:48 +0300 (EEST) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 04 May 2010 12:24:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36686 Archived-At: There is one annoying difference between `beginning-of-defun' and `c-beginning-of-defun': `beginning-of-defun' and `end-of-defun' pushes the mark for the old point location to the mark ring with this code: (or (not (eq this-command 'beginning-of-defun)) (eq last-command 'beginning-of-defun) (and transient-mark-mode mark-active) (push-mark)) but `c-beginning-of-defun' doesn't do that. This patch add the same code to `c-beginning-of-defun' and `c-end-of-defun': === modified file 'lisp/progmodes/cc-cmds.el' --- lisp/progmodes/cc-cmds.el 2010-04-19 15:07:52 +0000 +++ lisp/progmodes/cc-cmds.el 2010-05-04 16:01:05 +0000 @@ -1501,6 +1501,11 @@ (defun c-beginning-of-defun (&optional a (interactive "p") (or arg (setq arg 1)) + (or (not (eq this-command 'c-beginning-of-defun)) + (eq last-command 'c-beginning-of-defun) + (and transient-mark-mode mark-active) + (push-mark)) + (c-save-buffer-state (beginning-of-defun-function end-of-defun-function (start (point)) @@ -1604,6 +1609,11 @@ (defun c-end-of-defun (&optional arg) (interactive "p") (or arg (setq arg 1)) + (or (not (eq this-command 'c-end-of-defun)) + (eq last-command 'c-end-of-defun) + (and transient-mark-mode mark-active) + (push-mark)) + (c-save-buffer-state (beginning-of-defun-function end-of-defun-function (start (point)) -- Juri Linkov http://www.jurta.org/emacs/