From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jari Aalto Newsgroups: gmane.emacs.bugs Subject: bug#7640: [PATCH] lisp/finder.el: Define used buffer names in variables Date: Tue, 14 Dec 2010 20:27:48 +0200 Message-ID: <87mxo843bv.fsf@picasso.cante.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1292352825 9155 80.91.229.12 (14 Dec 2010 18:53:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 14 Dec 2010 18:53:45 +0000 (UTC) To: 7640@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 14 19:53:36 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PSa0C-0000YC-W9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Dec 2010 19:53:36 +0100 Original-Received: from localhost ([127.0.0.1]:46857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSa0B-0002xB-JG for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Dec 2010 13:53:31 -0500 Original-Received: from [140.186.70.92] (port=60384 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSZzr-0002oF-SN for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2010 13:53:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSZzF-00050z-FO for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2010 13:53:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PSZzF-00050v-Dc for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2010 13:52:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PSZVi-0004yU-4l; Tue, 14 Dec 2010 13:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jari Aalto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2010 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7640 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.129235090119087 (code B ref -1); Tue, 14 Dec 2010 18:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Dec 2010 18:21:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSZVM-0004xo-FP for submit@debbugs.gnu.org; Tue, 14 Dec 2010 13:21:40 -0500 Original-Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSZVJ-0004xY-Cg for submit@debbugs.gnu.org; Tue, 14 Dec 2010 13:21:39 -0500 Original-Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh03-2.mail.saunalahti.fi (Postfix) with SMTP id 89831EBA78 for ; Tue, 14 Dec 2010 20:27:50 +0200 (EET) Original-Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A05C83561BA; Tue, 14 Dec 2010 20:27:50 +0200 Original-Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id 6340141BE4 for ; Tue, 14 Dec 2010 20:27:48 +0200 (EET) Mail-Copies-To: poster X-Antivirus: VAMS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 14 Dec 2010 13:22:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42514 Archived-At: --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: wishlist Instead of using hardcoded buffer names, define and use variables `finder-keyword-buffer-name' abd `finder-commentary-buffer-name'. This patch is against Git: 1595eb5 2010-12-14 Merge branch 'master' of git://git.sv.gnu.org/emacs 2010-12-14 Jari Aalto * finder.el (finder-keyword-buffer-name): New variable. (finder-commentary-buffer-name): New variable. (finder-list-keywords): Use `finder-keyword-buffer-name'. (finder-commentary): Use `finder-commentary-buffer-name'. -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-finder.el-Define-used-buffer-names-in-variables.patch >From 71ed9690581ba917c6683ce45855dc1b95f573f4 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Tue, 14 Dec 2010 20:24:06 +0200 Subject: [PATCH] finder.el: Define used buffer names in variables. Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Instead of using hardcoded buffer names, define and use variables `finder-keyword-buffer-name' abd `finder-commentary-buffer-name'. Signed-off-by: Jari Aalto --- lisp/finder.el | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/lisp/finder.el b/lisp/finder.el index 655ad53..9bfbdeb 100644 --- a/lisp/finder.el +++ b/lisp/finder.el @@ -35,6 +35,12 @@ (require 'find-func) ;for find-library(-suffixes) (require 'finder-inf nil t) +(defconst finder-keyword-buffer-name "*Finder*" + "Name of the byffer displayed by `finder-list-keywords'.") + +(defconst finder-commentary-buffer-name "*Finder-package*" + "Name of the byffer displayed by `finder-commentary'.) + ;; These are supposed to correspond to top-level customization groups, ;; says rms. (defvar finder-known-keywords @@ -293,9 +299,9 @@ not `finder-known-keywords'." (defun finder-list-keywords () "Display descriptions of the keywords in the Finder buffer." (interactive) - (if (get-buffer "*Finder*") - (pop-to-buffer "*Finder*") - (pop-to-buffer (get-buffer-create "*Finder*")) + (if (get-buffer finder-keyword-buffer-name) + (pop-to-buffer finder-keyword-buffer-name) + (pop-to-buffer (get-buffer-create finder-keyword-buffer-name)) (finder-mode) (let ((inhibit-read-only t)) (erase-buffer) @@ -342,7 +348,7 @@ FILE should be in a form suitable for passing to `locate-library'." (or str (error "Can't find any Commentary section")) ;; This used to use *Finder* but that would clobber the ;; directory of categories. - (pop-to-buffer "*Finder-package*") + (pop-to-buffer finder-commentary-buffer-name) (setq buffer-read-only nil buffer-undo-list t) (erase-buffer) @@ -422,7 +428,7 @@ finder directory, \\[finder-exit] = quit, \\[finder-summary] = help"))) Delete the window and kill all Finder-related buffers." (interactive) (ignore-errors (delete-window)) - (let ((buf "*Finder*")) + (let ((buf finder-keyword-buffer-name)) (and (get-buffer buf) (kill-buffer buf)))) -- 1.7.2.3 --=-=-=--