* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
@ 2010-12-16 5:12 Keitaro Miyazaki
2011-01-22 3:04 ` Chong Yidong
0 siblings, 1 reply; 7+ messages in thread
From: Keitaro Miyazaki @ 2010-12-16 5:12 UTC (permalink / raw)
To: 7650
I found that the check mark of a menu item "Case sensiteve"
of "Re-Builder" menu won't be updated properly, even if
I choose that menu.
This patch may fix this problem.
--- lisp/emacs-lisp/re-builder.el.orig 2010-04-04 07:26:09.000000000 +0900
+++ lisp/emacs-lisp/re-builder.el 2010-12-16 13:22:52.000000000 +0900
@@ -247,7 +247,7 @@ Except for Lisp syntax this is the same
:help "Quit the RE Builder mode"))
(define-key menu-map [rt]
'(menu-item "Case sensitive" reb-toggle-case
- :button (:toggle . case-fold-search)
+ :button (:toggle . (with-current-buffer reb-target-buffer
case-fold-search))
:help "Toggle case sensitivity of searches for RE Builder target buffer"))
(define-key menu-map [rb]
'(menu-item "Change target buffer..." reb-change-target-buffer
Best regards,
In GNU Emacs 23.2.1 (x86_64-apple-darwin10.5.0, NS apple-appkit-1038.35)
of 2010-11-29 on mac
Windowing system distributor `Apple', version 10.3.1038
configured using `configure '--with-ns''
Important settings:
value of $LC_ALL: ja_JP.UTF-8
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: ja_JP.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: RE Builder
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
M-x r e - b u <tab> <return> <menu-bar> <reb-mode>
<rt> <help-echo> M-x r e o p <backspace> <backspace>
p o <tab> r t <tab> <return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
200 matches (limit reached) [3 times]
Making completion list...
Load-path shadows:
None found.
Features:
(shadow sort mail-extr message ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1
hex-util hashcash mail-utils emacsbug help-mode view re-builder
japan-util tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win
easymenu tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process ns multi-tty emacs)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
2010-12-16 5:12 bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly Keitaro Miyazaki
@ 2011-01-22 3:04 ` Chong Yidong
2011-01-22 8:39 ` Lennart Borgman
[not found] ` <AANLkTimnazibO7AVqdX7NTkXkwpBT4dbmog4Djfr6Kr0@mail.gmail.com>
0 siblings, 2 replies; 7+ messages in thread
From: Chong Yidong @ 2011-01-22 3:04 UTC (permalink / raw)
To: Keitaro Miyazaki; +Cc: 7650
Keitaro Miyazaki <keitaro.miyazaki@gmail.com> writes:
> I found that the check mark of a menu item "Case sensiteve"
> of "Re-Builder" menu won't be updated properly, even if
> I choose that menu.
>
> This patch may fix this problem.
Thanks, but I could not reproduce the bug. Could you provide an exact
step-by-step recipe that demonstrates the problem?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
2011-01-22 3:04 ` Chong Yidong
@ 2011-01-22 8:39 ` Lennart Borgman
[not found] ` <AANLkTimnazibO7AVqdX7NTkXkwpBT4dbmog4Djfr6Kr0@mail.gmail.com>
1 sibling, 0 replies; 7+ messages in thread
From: Lennart Borgman @ 2011-01-22 8:39 UTC (permalink / raw)
To: Chong Yidong; +Cc: 7650, Keitaro Miyazaki
On Sat, Jan 22, 2011 at 4:04 AM, Chong Yidong <cyd@stupidchicken.com> wrote:
> Keitaro Miyazaki <keitaro.miyazaki@gmail.com> writes:
>
>> I found that the check mark of a menu item "Case sensiteve"
>> of "Re-Builder" menu won't be updated properly, even if
>> I choose that menu.
>>
>> This patch may fix this problem.
>
> Thanks, but I could not reproduce the bug. Could you provide an exact
> step-by-step recipe that demonstrates the problem?
I might be worth do know that I have a heavily rewritten re-builder
(with better integration with isearch and rx). I have not had time to
finish all details, but I hope I can do that really soon.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
[not found] ` <AANLkTimnazibO7AVqdX7NTkXkwpBT4dbmog4Djfr6Kr0@mail.gmail.com>
@ 2011-01-22 20:53 ` Chong Yidong
2011-01-23 7:08 ` Keitaro Miyazaki
0 siblings, 1 reply; 7+ messages in thread
From: Chong Yidong @ 2011-01-22 20:53 UTC (permalink / raw)
To: Keitaro Miyazaki; +Cc: 7650
Keitaro Miyazaki <keitaro.miyazaki@gmail.com> writes:
>> Thanks, but I could not reproduce the bug. Could you provide an exact
>> step-by-step recipe that demonstrates the problem?
>
> Below is the procedure to reproduce the problem:
Thanks, now I see it. I've commited your patch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
2011-01-22 20:53 ` Chong Yidong
@ 2011-01-23 7:08 ` Keitaro Miyazaki
2011-01-23 20:58 ` Chong Yidong
0 siblings, 1 reply; 7+ messages in thread
From: Keitaro Miyazaki @ 2011-01-23 7:08 UTC (permalink / raw)
To: Chong Yidong; +Cc: 7650
On Sun, Jan 23, 2011 at 5:53 AM, Chong Yidong <cyd@stupidchicken.com> wrote:
> Thanks, now I see it. I've commited your patch.
I tried your commit, though it seems that the menu
"Case sensitive" still won't be updated properly.
I think that a check mark on the menu should be TURNED ON
at step 6 of my step-by-step procedure, because this menu
should tell the status of a variable `case-fold-search'
in `reb-target-buffer' (in my example, the buffer "*scratch*"
is set to this variable) to user.
Could you try my patch again?
--- emacs/lisp/emacs-lisp/re-builder.el.orig 2011-01-23 15:44:02.000000000 +0900
+++ emacs/lisp/emacs-lisp/re-builder.el 2011-01-23 15:46:41.000000000 +0900
@@ -243,7 +243,7 @@ Except for Lisp syntax this is the same
:help "Quit the RE Builder mode"))
(define-key menu-map [rt]
'(menu-item "Case sensitive" reb-toggle-case
- :button (:toggle . (null case-fold-search))
+ :button (:toggle . (with-current-buffer reb-target-buffer
case-fold-search))
:help "Toggle case sensitivity of searches for RE Builder target buffer"))
(define-key menu-map [rb]
'(menu-item "Change target buffer..." reb-change-target-buffer
Best regards,
Keitaro
--
This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your report will be posted to the bug-gnu-emacs@gnu.org mailing list
and the gnu.emacs.bug news group, and at http://debbugs.gnu.org.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug. If you can, give
a recipe starting from `emacs -Q':
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Users/kay/Work/emacs-current/emacs/nextstep/Emacs.app/Contents/Resources/etc/DEBUG.
In GNU Emacs 24.0.50.2 (x86_64-apple-darwin10.6.0, NS apple-appkit-1038.35)
of 2011-01-23 on mac
Windowing system distributor `Apple', version 10.3.1038
configured using `configure '--with-ns''
Important settings:
value of $LC_ALL: ja_JP.UTF-8
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: ja_JP.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: RE Builder
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
<help-echo> C-x b * s c r a t c h * <return> A b C
d M-x r e - b u <tab> <return> a b c d <menu-bar> <reb-mode>
<rt> <menu-bar> <reb-mode> <rt> M-x r e p o r t - e m a c s
- b u g <tab> <return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
195 matches [2 times]
11 matches
1 match [3 times]
No matches
1 match
Making completion list...
Load-path shadows:
None found.
Features:
(shadow sort gnus-util mail-extr message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug
help-mode easymenu view re-builder japan-util tooltip ediff-hook
vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
loaddefs button minibuffer faces cus-face files text-properties overlay
md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process ns multi-tty
emacs)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
2011-01-23 7:08 ` Keitaro Miyazaki
@ 2011-01-23 20:58 ` Chong Yidong
2011-01-24 4:32 ` Keitaro Miyazaki
0 siblings, 1 reply; 7+ messages in thread
From: Chong Yidong @ 2011-01-23 20:58 UTC (permalink / raw)
To: Keitaro Miyazaki; +Cc: 7650
Keitaro Miyazaki <keitaro.miyazaki@gmail.com> writes:
> I tried your commit, though it seems that the menu
> "Case sensitive" still won't be updated properly.
It's on the emacs-23 branch, not on the trunk yet.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly.
2011-01-23 20:58 ` Chong Yidong
@ 2011-01-24 4:32 ` Keitaro Miyazaki
0 siblings, 0 replies; 7+ messages in thread
From: Keitaro Miyazaki @ 2011-01-24 4:32 UTC (permalink / raw)
To: Chong Yidong; +Cc: 7650
On Mon, Jan 24, 2011 at 5:58 AM, Chong Yidong <cyd@stupidchicken.com> wrote:
> It's on the emacs-23 branch, not on the trunk yet.
Sorry for my misunderstanding.
I tried emacs-23 branch, and
the patch seems to be working fine.
Best regards,
Keitaro
--text follows this line--
This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your report will be posted to the bug-gnu-emacs@gnu.org mailing list
and the gnu.emacs.bug news group, and at http://debbugs.gnu.org.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug. If you can, give
a recipe starting from `emacs -Q':
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Users/kay/Work/emacs-current/emacs-23/nextstep/Emacs.app/Contents/Resources/etc/DEBUG.
In GNU Emacs 23.2.92.1 (x86_64-apple-darwin10.6.0, NS apple-appkit-1038.35)
of 2011-01-24 on mac
Windowing system distributor `Apple', version 10.3.1038
configured using `configure '--with-ns''
Important settings:
value of $LC_ALL: ja_JP.UTF-8
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: ja_JP.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: RE Builder
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
C-x b * s c r a t c h * <return> A b C d M-x r e -
b u <tab> <return> a b c d <menu-bar> <reb-mode> <rt>
<menu-bar> <reb-mode> <rt> M-x r e p o r t - e m a
c s - b u g <return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
195 matches [2 times]
11 matches
1 match [3 times]
No matches
1 match
Load-path shadows:
None found.
Features:
(shadow sort mail-extr message ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1
hex-util hashcash mail-utils emacsbug re-builder japan-util tooltip
ediff-hook vc-hooks lisp-float-type mwheel ns-win easymenu tool-bar dnd
fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer
select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces
cus-face files text-properties overlay md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote
make-network-process ns multi-tty emacs)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-24 4:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-16 5:12 bug#7650: Subject: 23.2; [PATCH] re-builder.el: "Case sensitive" menu won't be updated properly Keitaro Miyazaki
2011-01-22 3:04 ` Chong Yidong
2011-01-22 8:39 ` Lennart Borgman
[not found] ` <AANLkTimnazibO7AVqdX7NTkXkwpBT4dbmog4Djfr6Kr0@mail.gmail.com>
2011-01-22 20:53 ` Chong Yidong
2011-01-23 7:08 ` Keitaro Miyazaki
2011-01-23 20:58 ` Chong Yidong
2011-01-24 4:32 ` Keitaro Miyazaki
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).