unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Christoph Scholtes <cschol2112@googlemail.com>
Cc: 8454@debbugs.gnu.org, "Dirk-Jan C. Binnema" <djcb.bulk@gmail.com>
Subject: bug#8454: deftheme, :inherit & overriding existing values
Date: Sun, 08 May 2011 16:14:53 -0400	[thread overview]
Message-ID: <87mxix7xvm.fsf@stupidchicken.com> (raw)
In-Reply-To: <87r58980f7.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 08 May 2011 15:19:56 -0400")

Chong Yidong <cyd@stupidchicken.com> writes:

> I'm afraid both bug reports are too vague for me to figure out exactly
> what is supposed to be going wrong.  Could someone provide a precise,
> step-by-step recipe for reproducing the problem?

OK, I found a bug in the case where defface is called after loading a
theme with settings for that face.  The defface settings were not being
applied; I've checked a fix into the trunk.  However, I'm not sure this
is the issue you are talking about, since this bug was not specific to
the :inherit property.  Could you check if your problem is fixed?

One possible source of confusion, which may apply to Dirk-Jan's report,
is that :inherit only tells Emacs to consult the parent face if a face
attribute is unspecified.  If the attribute is specified, it overrides
the inheritance.  So if your Custom theme want to "cancel out", say, any
existing foreground attribute setting, you need something like

 '(froob ((t (:foreground unspecified :inherit parent-face))))





  reply	other threads:[~2011-05-08 20:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110507091706.DC97939C792@djcbsoftware.nl>
     [not found] ` <4DC54D3D.7090409@gmail.com>
2011-05-08 19:19   ` bug#8454: deftheme, :inherit & overriding existing values Chong Yidong
2011-05-08 20:14     ` Chong Yidong [this message]
2011-05-09 20:41       ` Dirk-Jan C. Binnema
2011-05-10  3:18       ` Christoph Scholtes
2011-05-13  4:50         ` Dirk-Jan C. Binnema

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxix7xvm.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=8454@debbugs.gnu.org \
    --cc=cschol2112@googlemail.com \
    --cc=djcb.bulk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).