From: Christopher Schmidt <christopher@ch.ristopher.com>
To: 13379-done@debbugs.gnu.org
Subject: bug#13379: 24.3.50; compilation-start-hook: misleading docstring
Date: Sat, 2 Feb 2013 06:32:04 +0000 (GMT) [thread overview]
Message-ID: <87mwvnxm3f@ch.ristopher.com> (raw)
In-Reply-To: <87lic4zr96@ch.ristopher.com> (Christopher Schmidt's message of "Mon, 7 Jan 2013 20:12:51 +0000 (GMT)")
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
Christopher Schmidt <christopher@ch.ristopher.com> writes:
> The docstring of compilation-start-hook is misleading.
>
> The reference to run-hook-with-args is superfluous, so is the
> reference to omake. I do not think set-process-query-on-exit-flag
> should be used in compilation-start-hook - compilation-always-kill is
> the way to go, or it should be explained why the lambda is added
> buffer locally and where this form should be evaled.
I went ahead and committed this in r111661.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 961 bytes --]
--- lisp/ChangeLog
+++ lisp/ChangeLog
@@ -2,6 +2,7 @@
* progmodes/compile.el (compilation-error-regexp-alist-alist):
Identify g++ template instantiation trace. (Bug#12287)
+ (compilation-start-hook): Simplify docstring. (Bug#13379)
2013-02-02 Stefan Monnier <monnier@iro.umontreal.ca>
--- lisp/progmodes/compile.el
+++ lisp/progmodes/compile.el
@@ -48,12 +48,8 @@
;;;###autoload
(defcustom compilation-start-hook nil
- "List of hook functions run by `compilation-start' on the compilation process.
-\(See `run-hook-with-args').
-If you use \"omake -P\" and do not want \\[save-buffers-kill-terminal] to ask whether you want
-the compilation to be killed, you can use this hook:
- (add-hook 'compilation-start-hook
- (lambda (process) (set-process-query-on-exit-flag process nil)) nil t)"
+ "Hook run after starting a new compilation process. The hook
+is run with one argument, the new process."
:type 'hook
:group 'compilation)
[-- Attachment #3: Type: text/plain, Size: 146 bytes --]
If there is any doubt whatsoever regarding what I have just done, please
revert immediately and reopen the bug. Thank you!
Christopher
next prev parent reply other threads:[~2013-02-02 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:12 bug#13379: 24.3.50; compilation-start-hook: misleading docstring Christopher Schmidt
2013-02-02 6:32 ` Christopher Schmidt [this message]
2013-02-02 7:39 ` Andreas Schwab
2013-02-02 8:46 ` Christopher Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwvnxm3f@ch.ristopher.com \
--to=christopher@ch.ristopher.com \
--cc=13379-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).