unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
@ 2013-12-14 12:15 Kenjiro NAKAYAMA
  2013-12-21 20:44 ` Ted Zlatanov
  2013-12-24  7:28 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 5+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-14 12:15 UTC (permalink / raw)
  To: 16142

The key map to eww-submit with Enter key in the text field should be
deleted. It is easy to mistake.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

        * net/eww.el (eww-text-map): Delete keymap to eww-submit with
          Enter in the text field.

---
 lisp/net/eww.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..011d3fb 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -571,7 +571,6 @@ appears in a <link> or <a> tag."
 (defvar eww-text-map
   (let ((map (make-keymap)))
     (set-keymap-parent map text-mode-map)
-    (define-key map "\r" 'eww-submit)
     (define-key map [(control a)] 'eww-beginning-of-text)
     (define-key map [(control c) (control c)] 'eww-submit)
     (define-key map [(control e)] 'eww-end-of-text)
-- 
1.8.3.1

Kenjiro





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
  2013-12-14 12:15 bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field Kenjiro NAKAYAMA
@ 2013-12-21 20:44 ` Ted Zlatanov
  2013-12-24  7:28 ` Lars Ingebrigtsen
  1 sibling, 0 replies; 5+ messages in thread
From: Ted Zlatanov @ 2013-12-21 20:44 UTC (permalink / raw)
  To: Kenjiro NAKAYAMA; +Cc: Lars Magne Ingebrigtsen, 16142

On Sat, 14 Dec 2013 21:15:47 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote: 

KN> The key map to eww-submit with Enter key in the text field should be
KN> deleted. It is easy to mistake.

I'm not sure, leaving for Lars to decide.

Ted





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
  2013-12-14 12:15 bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field Kenjiro NAKAYAMA
  2013-12-21 20:44 ` Ted Zlatanov
@ 2013-12-24  7:28 ` Lars Ingebrigtsen
  2013-12-25 10:37   ` Kenjiro NAKAYAMA
  1 sibling, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2013-12-24  7:28 UTC (permalink / raw)
  To: Kenjiro NAKAYAMA; +Cc: 16142

Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:

> The key map to eww-submit with Enter key in the text field should be
> deleted. It is easy to mistake.

It's how all other web browsers work, and is necessary for using the web
at all.  It's common now to eschew submit buttons.  So rejected.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
  2013-12-24  7:28 ` Lars Ingebrigtsen
@ 2013-12-25 10:37   ` Kenjiro NAKAYAMA
  2013-12-25 15:33     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-25 10:37 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Kenjiro NAKAYAMA, 16142

> It's how all other web browsers work, and is necessary for using the web
> at all.  It's common now to eschew submit buttons.  So rejected.

You are right, it was my mistake. But it is the problem that users can't
distiguish input text from textarea, like following HTML.

 <form method="POST" action="./dummy.php">
 <input type="text" name="example1" size="10">
 <p>
 <textarea name="example1" rows="1"></textarea>
 </form>

I think eww should change the color to distinguish. I send new patch,
please reconsider and review it.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

        * net/eww.el(eww-form-textarea): New defface for textarea.
        (eww-tag-textarea): Apply textarea color.

---
 lisp/net/eww.el | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 02c93a0..576778c 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -115,6 +115,14 @@ See also `eww-form-checkbox-selected-symbol'."
   :version "24.4"
   :group 'eww)
 
+(defface eww-form-textarea
+  '((t (:background "#C0C0C0"
+		    :foreground "black"
+		    :box (:line-width 1))))
+  "Face for eww text inputs."
+  :version "24.4"
+  :group 'eww)
+
 (defvar eww-current-url nil)
 (defvar eww-current-dom nil)
 (defvar eww-current-source nil)
@@ -776,7 +784,7 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
 	(when (> pad 0)
 	  (insert (make-string pad ? ))))
       (add-face-text-property (line-beginning-position)
-			      (point) 'eww-form-text)
+			      (point) 'eww-form-textarea)
       (put-text-property (line-beginning-position) (point)
 			 'local-map eww-textarea-map)
       (forward-line 1))
-- 
1.8.3.1

Regards,

Kenjiro


larsi@gnus.org writes:

> Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:
>
>> The key map to eww-submit with Enter key in the text field should be
>> deleted. It is easy to mistake.
>
> It's how all other web browsers work, and is necessary for using the web
> at all.  It's common now to eschew submit buttons.  So rejected.






^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
  2013-12-25 10:37   ` Kenjiro NAKAYAMA
@ 2013-12-25 15:33     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2013-12-25 15:33 UTC (permalink / raw)
  To: Kenjiro NAKAYAMA; +Cc: 16142

Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:

> You are right, it was my mistake. But it is the problem that users can't
> distiguish input text from textarea, like following HTML.

Makes sense.  Applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-12-25 15:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 12:15 bug#16142: 24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field Kenjiro NAKAYAMA
2013-12-21 20:44 ` Ted Zlatanov
2013-12-24  7:28 ` Lars Ingebrigtsen
2013-12-25 10:37   ` Kenjiro NAKAYAMA
2013-12-25 15:33     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).