bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[Thierry Volpiatto]

Hi, with a prompt with many lines I expect (y-or-no-p) to be visible in
minibuffer.

To reproduce in emacs -Q, eval the following code in scratch:

--8<---------------cut here---------------start------------->8---
(let ((files '("foo" "bar" "baz" "ert"
               "rty" "yui" "riri" "fifi"
               "lolo" "ppom" "mlk" "bgt"
               "gfr" "sdf" "ghj" "vcx" "qsd")))
  (y-or-n-p
   (format "Delete *%s File(s):\n%s"
           (length files)
           (mapconcat (lambda (f) (format "- %s\n" f)) files ""))))
--8<---------------cut here---------------end--------------->8---

You can see the (y-or-n) is no more visible.



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, X toolkit)
 of 2014-01-08 on dell-14z
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
System Description:	Ubuntu 12.04.4 LTS

Configured using:
 `configure --with-x-toolkit=lucid --without-toolkit-scroll-bars
 --without-gconf --without-gsettings'

Important settings:
  value of $LC_MONETARY: fr_FR.UTF-8
  value of $LC_NUMERIC: fr_FR.UTF-8
  value of $LC_TIME: fr_FR.UTF-8
  value of $LANG: fr_FR.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  diff-auto-refine-mode: t
  psession-mode: t
  global-semanticdb-minor-mode: t
  global-semantic-idle-scheduler-mode: t
  semantic-mode: t
  golden-ratio-mode: t
  winner-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  auto-image-file-mode: t
  eldoc-in-minibuffer-mode: t
  show-paren-mode: t
  display-time-mode: t
  recentf-mode: t
  savehist-mode: t
  eldoc-mode: t
  minibuffer-depth-indicate-mode: t
  helm-mode: t
  helm-descbinds-mode: t
  shell-dirtrack-mode: t
  helm-adaptative-mode: t
  helm-match-plugin-mode: t
  helm-occur-match-plugin-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <down> <down> <down> 
<backspace> <backspace> M-( l e n SPC f i l e s <up> 
<up> <tab> <down> <tab> <down> <tab> <down> <tab> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<up> <up> <up> <up> C-e ) ) <down> <tab> <down> <tab> 
<down> <tab> <down> <tab> C-e ) C-x C-e q <up> <left> 
<left> <left> <left> <left> <left> <left> g t h <down> 
C-e C-x C-e C-g <up> <up> <up> <up> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <return> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <return> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <return> <up> <up> 
<up> C-M-" " " " " " " " " " " " " " " " " " <right> 
<right> <right> <right> <down> <tab> <down> <tab> <down> 
<tab> <down> <tab> C-e <up> <up> <up> <up> <up> <up> 
<up> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> C-M-SPC 
M-w C-M-SPC M-w <down> <down> <down> <down> <down> 
<down> <down> <down> <down> M-x r e p o r t - e m a 
<return>

Recent messages:
Type a prefix key to toggle it. Run 'actions' with their prefixes. '?' for more help.
Beginning of buffer [6 times]
View mode: type C-h for help, h for commands, q to quit.
Mark set [2 times]
Auto-saving...done
Entering debugger...
Back to top level.
Quit
Auto-saving...
Mark set [2 times]

Load-path shadows:
/usr/local/share/emacs/24.3.50/lisp/gnus/.dir-locals hides ~/elisp/magit/.dir-locals
~/elisp/auctex/lpath hides ~/elisp/emacs-wget/lpath
/usr/local/share/emacs/24.3.50/lisp/emacs-lisp/tq hides ~/elisp/emms/lisp/tq

Features:
(shadow epa-mail emacsbug helm-command help-mode debug cl-indent
filecache pcmpl-unix magit-cherry magit-bisect magit-log-edit log-edit
add-log magit-key-mode magit view iswitchb ediff-merg ediff-wind
ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff diff-mode
magit-compat tabify imenu woman man helm-man helm-eshell ido helm-sys
gnus-fun gnus-html url-cache smiley gnus-cite flow-fill mm-archive
mail-extr gnus-async gnus-bcklg gnus-ml nndraft nnmh utf-7 nnimap utf7
nnml nnfolder parse-time netrc network-stream starttls tls gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu
mml2015 mm-view mml-smime smime dig nntp gnus-cache gnus-dired nnir
gnus-sum gnus-group gnus-undo nnmail mail-source nnoo gnus-start
gnus-spec gnus-int gnus-range gnus-win sh-script smie executable vc-rcs
conf-mode vc-git naquadah-theme em-unix em-script em-prompt em-ls
em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias
align-let git-gutter server persistent-sessions semantic/db-mode
semantic/db eieio-base semantic/idle semantic/format ezimage
semantic/tag-ls semantic/find semantic/ctxt semantic/util-modes
semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local
cedet package golden-ratio winner undo-tree diff image-file newsticker
newst-treeview newst-plainview newst-reader newst-ticker newst-backend
shr xdvi-search preview-latex tex-site auto-loads pcomplete-extension
em-term term disp-table ehelp helm-ipython helm-elisp helm-eval python
eldoc-eval warnings whitespace paren time avoid recentf tree-widget
savehist smtpmail-async smtpmail sendmail helm-async iterator
simple-call-tree iedit-rect rect iedit iedit-lib smallurl mm-url gnus
gnus-ems nnheader wid-edit rectangle-utils ledger-config ledger esh-var
esh-io esh-cmd esh-opt esh-ext esh-proc eldoc esh-groups eshell
esh-module esh-mode esh-arg esh-util tv-utils async pcvs vc-cvs
pcvs-parse pcvs-info pcvs-defs pcvs-util ewoc mb-depth cl-info
slime-autoloads esh-toggle flymake no-word htmlize dired-extension cl
emms-mpd-config emms-playlist-limit emms-volume emms-volume-amixer
emms-i18n emms-history emms-score emms-stream-info
emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon
emms-browser sort emms-playlist-sort emms-last-played emms-player-xine
emms-player-mpd tq emms-playing-time emms-lyrics emms-url hl-line
emms-tag-editor emms-mark emms-mode-line emms-cache emms-info-ogginfo
emms-info-mp3info emms-playlist-mode emms-player-vlc emms-player-mplayer
emms-info emms-streams later-do emms-source-playlist emms-source-file
emms-player-simple emms-setup emms emms-compat org-config-thierry ob-sh
org-crypt cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew
holidays hol-loaddefs appt diary-lib diary-loaddefs org-element
org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view
jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org-agenda
org-annotation-helper addressbook-bookmark message rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev mail-utils gmm-utils mailheader firefox-protocol
bookmark-firefox-handler bookmark-extensions org org-macro org-footnote
org-pcomplete org-list org-faces org-entities noutline outline
easy-mmode org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob
ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs
org-loaddefs find-func cal-menu calendar cal-loaddefs init-helm-thierry
helm-mode helm-dictionary helm-ls-git helm-descbinds helm-ls-hg
helm-files image-dired tramp tramp-compat tramp-loaddefs trampver shell
pcomplete format-spec dired-x dired-aux ffap thingatpt helm-buffers
helm-elscreen helm-tags helm-bookmark helm-adaptative helm-info helm-net
browse-url xml url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util url-parse url-vars mailcap
helm-plugin bookmark pp helm-help helm-match-plugin helm-grep wgrep-helm
wgrep helm-regexp grep helm-external helm-utils dired compile comint
ansi-color ring helm-locate helm vc vc-dispatcher helm-config
helm-aliases epa-file epa derived epg epg-config auth-source eieio
byte-opt bytecomp byte-compile cconv eieio-core gnus-util time-date
mm-util mail-prsvr password-cache info easymenu cl-macs gv edmacro
kmacro advice help-fns net-utils cl-loaddefs cl-lib tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting font-render-setting x-toolkit x
multi-tty emacs)

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[martin rudalics]

> Hi, with a prompt with many lines I expect (y-or-no-p) to be visible in
> minibuffer.

I don't.

> To reproduce in emacs -Q, eval the following code in scratch:
...
> You can see the (y-or-n) is no more visible.

Try (setq max-mini-window-height 0.9)

But there _is_ a limit ...

martin

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[Thierry Volpiatto]

martin rudalics <rudalics@gmx.at> writes:

>> Hi, with a prompt with many lines I expect (y-or-no-p) to be visible in
>> minibuffer.
>
> I don't.
>
>> To reproduce in emacs -Q, eval the following code in scratch:
> ...
>> You can see the (y-or-n) is no more visible.
>
> Try (setq max-mini-window-height 0.9)

It is working yes, but it is not the same behavior as in emacs-24.3 and
previous version (I use this code since long time now).
When modifying this it seems the window is growing on top to leave place
on bottom.
When there is too much lines, I expect (and IMO it is the right thing to
do) the top of the miniwindow invisible but the bottom (where the
y-or-n-p prompt is) _visible_.

> But there _is_ a limit ...

What are these limits (float and integer) ?

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[Drew Adams]

OT for this bug, but you might (anyway) consider using a different
function for this question about acting on a list of files.

Dired offers some code for this kind of thing.  See, for instance,
`dired-map-over-marks-check'.  Some of what it does might be
pertinent here.

In Dired+ I have a function `diredp-y-or-n-files-p', which does
just the following, and so is probably more pertinent here (but
it does not log errors as `dired-map-over-marks-check' does):

,----
| diredp-y-or-n-files-p is a compiled Lisp function in `dired+'.
| (diredp-y-or-n-files-p PROMPT FILES &optional PREDICATE)
| 
| PROMPT user with a "y or n" question about a list of FILES.
| Return t if answer is "y".  Otherwise, return nil.
| 
| Like `y-or-n-p', but the user can also hit `l' to display the list of
| files that the confirmation is for, in buffer `*Files'.  When
| finished, buffer `*Files*' is killed if it was never shown, or is
| hidden and buried otherwise.  Thus, if it was shown then it is still
| available to revisit afterward (even if the user quit using `C-g').
| 
| PREDICATE is passed to `diredp-list-files', to list only file names
| for which it returns non-nil.
`----

`diredp-list-files' does this:

,----
| diredp-list-files is a compiled Lisp function in `dired+'.
| (diredp-list-files FILES &optional DIR BUFNAME PREDICATE)
| 
| Display FILES, a list of file names.  Wildcard patterns are expanded.
| The files are shown in a new buffer, `*Files*' by default.
| Optional arg DIR serves as the default directory for expanding file
|  names that are not absolute.  It defaults to `default-directory'.
| Optional arg BUFNAME is the name of the buffer for the display.
|  It defaults to `*Files*' (or `*Files*<N>' if `*Files*' exists).
`----

These functions are not really Dired-specific, as you can tell from
the descriptions.

HTH.  Again, I realize it is OT for the bug.

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[Thierry Volpiatto]

Drew Adams <drew.adams@oracle.com> writes:

> OT for this bug, but you might (anyway) consider using a different
> function for this question about acting on a list of files.

Thanks Drew, I have another function waiting displaying the list of
files in another window using `with-temp-buffer-window'.
But I think there is a bug here anyway.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[martin rudalics]

 > When there is too much lines, I expect (and IMO it is the right thing to
 > do) the top of the miniwindow invisible but the bottom (where the
 > y-or-n-p prompt is) _visible_.

It's a regression, indeed.  The last line of the prompt becomes
invisible.

martin

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[martin rudalics]

 > To reproduce in emacs -Q, eval the following code in scratch:
 >
 > --8<---------------cut here---------------start------------->8---
 > (let ((files '("foo" "bar" "baz" "ert"
 >                "rty" "yui" "riri" "fifi"
 >                "lolo" "ppom" "mlk" "bgt"
 >                "gfr" "sdf" "ghj" "vcx" "qsd")))
 >   (y-or-n-p
 >    (format "Delete *%s File(s):\n%s"
 >            (length files)
 >            (mapconcat (lambda (f) (format "- %s\n" f)) files ""))))
 > --8<---------------cut here---------------end--------------->8---
 >
 > You can see the (y-or-n) is no more visible.

Should be fixed now.  Please try again.

martin

bug#16424: 24.3.50; y-or-n-p prompt no more visible in minibuffer

[Thierry Volpiatto]

martin rudalics <rudalics@gmx.at> writes:

> Should be fixed now.  Please try again.

It is fixed now, thanks Martin.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997