From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16854: 24.3.50; ert-run-tests-interactively t selector not working Date: Sun, 23 Feb 2014 19:21:00 +0200 Message-ID: <87mwhhkao3.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393176137 19660 80.91.229.3 (23 Feb 2014 17:22:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Feb 2014 17:22:17 +0000 (UTC) Cc: 16854@debbugs.gnu.org To: Helmut Eller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 23 18:22:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WHckt-0002Nd-Ti for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Feb 2014 18:22:20 +0100 Original-Received: from localhost ([::1]:53648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHckt-0004D2-FN for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Feb 2014 12:22:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHckk-0004C3-2e for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 12:22:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHckc-000459-L4 for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 12:22:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHckc-000453-GH for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 12:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WHckc-000395-AC for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 12:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Feb 2014 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16854-submit@debbugs.gnu.org id=B16854.139317608012036 (code B ref 16854); Sun, 23 Feb 2014 17:22:02 +0000 Original-Received: (at 16854) by debbugs.gnu.org; 23 Feb 2014 17:21:20 +0000 Original-Received: from localhost ([127.0.0.1]:36748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHcjv-000383-MV for submit@debbugs.gnu.org; Sun, 23 Feb 2014 12:21:20 -0500 Original-Received: from mail-ee0-f43.google.com ([74.125.83.43]:44721) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHcjt-00037p-1N for 16854@debbugs.gnu.org; Sun, 23 Feb 2014 12:21:17 -0500 Original-Received: by mail-ee0-f43.google.com with SMTP id e51so2509059eek.16 for <16854@debbugs.gnu.org>; Sun, 23 Feb 2014 09:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=vd0L40FbMmQtagY96Ly3ugOn3DEiPfb/hvS6tsVI0PI=; b=Iu1hpJPqr7IEHmTI08NKcA+T14aeL5wJOalVHW93jDjaI63FVFYNrUv3v4jJdpVr08 lXs76XgtdUGmY5yVu7bPQyKrM5InDdXJKLEqxMXYL42A0g9HqFpdPR9KO9yWdFrgqXoi 7Zs7IozkyBOnCwZzsfLOo8zHFTq7yZrzBJ+v3mrMULpfSvYfJ6tb3x6Vgo+SPdxoGD91 +/NbsyHl8bcWbs7WxnBHT+ouJg3DWXLUMJPHsVG7CzG4vH73OGZHVpsqtBKEAjq7c8Ek 4dhS1mD+4vl0rOpvodFbLYDDtyRXM2T2iFiS3ZqbD1cH0Fra9xjLFyifvPNdWZfU5KEp qMxA== X-Received: by 10.14.103.67 with SMTP id e43mr19576238eeg.94.1393176071217; Sun, 23 Feb 2014 09:21:11 -0800 (PST) Original-Received: from axl ([93.109.195.252]) by mx.google.com with ESMTPSA id l4sm18270720eeo.9.2014.02.23.09.21.08 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 23 Feb 2014 09:21:10 -0800 (PST) In-Reply-To: (Helmut Eller's message of "Sun, 23 Feb 2014 15:57:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86076 Archived-At: Helmut Eller writes: > When I run this > > (require 'ert) > (ert-deftest infloop0 () (while t)) > > with: emacs -Q -nw -l infloops.el -f ert > > Emacs starts up and asks: "Run tests (default t): " > If I enter: "t RET" > then ERT does not run anything and simply writes: > "Ran 0 tests, 0 results were as expected" > > The expected result is that all tests should be executed. Same here. Apparently, this is fallout from 114803 (bug#9756). The code before it used `read-from-minibuffer' with t READ argument, so "t" was converted to `t'. But now `ert-select-tests' receives SELECTOR as "t". The patch below fixes it for me. === modified file 'lisp/emacs-lisp/ert.el' --- lisp/emacs-lisp/ert.el 2014-02-04 17:37:08 +0000 +++ lisp/emacs-lisp/ert.el 2014-02-23 17:16:26 +0000 @@ -1882,11 +1882,12 @@ ;; defined without cl. (car ert--selector-history) "t"))) - (completing-read (if (null default) - "Run tests: " - (format "Run tests (default %s): " default)) - obarray #'ert-test-boundp nil nil - 'ert--selector-history default nil)) + (intern + (completing-read (if (null default) + "Run tests: " + (format "Run tests (default %s): " default)) + obarray #'ert-test-boundp nil nil + 'ert--selector-history default nil))) nil)) (unless message-fn (setq message-fn 'message)) (let ((output-buffer-name output-buffer-name)