From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.bugs Subject: bug#16935: 24.3.50; when tab-completing in 'M-x' : "Wrong type argument: numberp, nil" Date: Tue, 04 Mar 2014 15:39:33 +0100 Message-ID: <87mwh62fkq.fsf@bzg.ath.cx> References: <871tyiyrvp.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393944012 5025 80.91.229.3 (4 Mar 2014 14:40:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Mar 2014 14:40:12 +0000 (UTC) Cc: Nicolas Richard , 16935@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 04 15:40:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WKqW2-0003qk-9Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Mar 2014 15:40:18 +0100 Original-Received: from localhost ([::1]:45551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqW1-00052O-U5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Mar 2014 09:40:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqVv-00050L-1C for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 09:40:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKqVp-00082w-AW for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 09:40:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqVp-00082L-7L for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 09:40:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WKqVn-0002rE-2x for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 09:40:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Mar 2014 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16935-submit@debbugs.gnu.org id=B16935.139394399410963 (code B ref 16935); Tue, 04 Mar 2014 14:40:01 +0000 Original-Received: (at 16935) by debbugs.gnu.org; 4 Mar 2014 14:39:54 +0000 Original-Received: from localhost ([127.0.0.1]:49955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKqVc-0002qk-CP for submit@debbugs.gnu.org; Tue, 04 Mar 2014 09:39:53 -0500 Original-Received: from rs249.mailgun.us ([209.61.151.249]:43246) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKqVY-0002qY-8a for 16935@debbugs.gnu.org; Tue, 04 Mar 2014 09:39:49 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=kickhub.com; q=dns/txt; s=mailo; t=1393943987; h=From: To: Cc: Subject: In-Reply-To: References: Date: Message-Id: Mime-Version: Content-Type: Sender; bh=kLQa2ahqN31m8HDD2v/pWFI8ShkfxDEoVLV1WqNrU08=; b=yYGdAc/as6JBgQ1jA2MJOouHsoJLh76GidnOs/ro/w95pLIaAJlJYlZyidU0S2Ssyclp3Zcv SfB12MvHebZA+SSxwAJne6/4cfDD182/dBGFJbKwitxbfraXl3rlTv2R3gZsz2I0tvIL963I zEdDSDezJ+2CMebvfImqbLHGhXw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=kickhub.com; s=mailo; q=dns; h=From: To: Cc: Subject: In-Reply-To: References: Date: Message-Id: Mime-Version: Content-Type: Sender; b=tDPV9TMeJMxRQk8au5roBs3+St2eCTqlnyso1sSVdLq3coxrRZ/KZsJU1xNXVMIwrDly+y OwfUgvV9ANSxBLyNzrIFdb9NEzA9pDKZRWeU4PA1Xq1//+Qqijbmzu51pSR6ZTk+5gosMpQ5 6KfHZyyTNsbznHsGX3hG168NCu0fQ= Original-Received: from bzg.localdomain (AMontsouris-651-1-21-222.w82-123.abo.wanadoo.fr [82.123.168.222]) by mxa.mailgun.org with ESMTP id 5315e5a7.67aeed8-in3; Tue, 04 Mar 2014 14:39:35 -0000 (UTC) Original-Received: by bzg.localdomain (Postfix, from userid 1000) id 9428D1C20D88; Tue, 4 Mar 2014 15:39:33 +0100 (CET) In-Reply-To: (Leo Liu's message of "Tue, 04 Mar 2014 22:27:22 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Mailgun-Sid: WyIxMjQ3MSIsICIxNjkzNUBkZWJidWdzLmdudS5vcmciLCAiMTY0ODgiXQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86533 Archived-At: Leo Liu writes: > On 2014-03-04 22:12 +0800, Nicolas Richard wrote: >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -1753,7 +1753,7 @@ variables.") >> (if completions "Sole completion" "No completions"))) >> >> (let* ((last (last completions)) >> - (base-size (cdr last)) >> + (base-size (or (cdr last) 0)) >> (prefix (unless (zerop base-size) (substring string 0 base-size))) >> (all-md (completion--metadata (buffer-substring-no-properties >> start (point)) > > I noticed this error too. (base-size (cdr last)) is used in 24.3 and no > errors there. So it will be good to know where the problem originated > and fix it. Sorry -- I just saw Nicolas email and yours. Hopefully, I came up with the same fix. The error originated here: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=66c5fecc The commit makes `base-size' optional, so we need to ensure it falls back to 0 instead of nil. -- Bastien